Skip to content

MessageBar: Dismiss button and overflow button aria labels #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynamemi merged 4 commits into from
Mar 7, 2018
Merged

MessageBar: Dismiss button and overflow button aria labels #4166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b4fa4d
Added overflowButtonAriaLabel
lynamemi Mar 2, 2018
29337cb
Updated examples to include aria labels for buttons
lynamemi Mar 2, 2018
67ebff9
One more dismiss button label
lynamemi Mar 2, 2018
00ea27b
Added change file
lynamemi Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/messagebar-aria_2018-03-02-23-40.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "MessageBar: Aria label for truncated text overflow button and added aria labels for buttons in examples.",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "lynam.emily@gmail.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/MessageBar/MessageBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class MessageBar extends BaseComponent<IMessageBarProps, IMessageBarState
className={ css('ms-MessageBar-expand', styles.expand) }
onClick={ this._onClick }
iconProps={ { iconName: this.state.expandSingleLine ? 'DoubleChevronUp' : 'DoubleChevronDown' } }
ariaLabel={ this.props.dismissButtonAriaLabel }
ariaLabel={ this.props.overflowButtonAriaLabel }
/>
</div>
);
Expand Down
5 changes: 5 additions & 0 deletions packages/office-ui-fabric-react/src/components/MessageBar/MessageBar.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ export interface IMessageBarProps extends React.HTMLAttributes<HTMLElement> {
* @defaultvalue false
*/
truncated?: boolean;

/**
* Aria label on overflow button if truncated is defined.
*/
overflowButtonAriaLabel?: string;
}

export enum MessageBarType {
Expand Down
4 changes: 4 additions & 0 deletions ...es/office-ui-fabric-react/src/components/MessageBar/examples/MessageBar.Basic.Example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export const MessageBarBasicExample = () => (
messageBarType={ MessageBarType.error }
isMultiline={ false }
onDismiss={ log('test') }
dismissButtonAriaLabel='Close'
>
Error lorem ipsum dolor sit amet, a elit sem interdum consectetur adipiscing elit. <Link href='www.bing.com'>Visit our website.</Link>
</MessageBar>
Expand All @@ -29,7 +30,9 @@ export const MessageBarBasicExample = () => (
messageBarType={ MessageBarType.blocked }
isMultiline={ false }
onDismiss={ log('test') }
dismissButtonAriaLabel='Close'
truncated={ true }
overflowButtonAriaLabel='Overflow'
>
Blocked lorem ipsum dolor sit amet, consectetur adipiscing elit. Morbi luctus, purus a lobortis tristique, odio augue pharetra metus, ac placerat nunc mi nec dui. Vestibulum aliquam et nunc semper scelerisque. Curabitur vitae orci nec quam condimentum porttitor et sed lacus. Vivamus ac efficitur leo. Cras faucibus mauris libero, ac placerat erat euismod et. Donec pulvinar commodo odio sit amet faucibus. In hac habitasse platea dictumst. Duis eu ante commodo, condimentum nibh pellentesque, laoreet enim. Fusce massa lorem, ultrices eu mi a, fermentum suscipit magna. Integer porta purus pulvinar, hendrerit felis eget, condimentum mauris. <Link href='www.bing.com'>Visit our website.</Link>
</MessageBar>
Expand Down Expand Up @@ -65,6 +68,7 @@ export const MessageBarBasicExample = () => (
<Label>Warning MessageBar - defaults to multiline, with dismiss and action buttons</Label>
<MessageBar
onDismiss={ log('test') }
dismissButtonAriaLabel='Close'
messageBarType={ MessageBarType.warning }
ariaLabel='Aria help text here'
actions={
Expand Down