Skip to content

Contextual Menu: Added aria-setsize and aria-posinset for rendering split buttons #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 7 commits into from
Feb 21, 2018
Merged

Contextual Menu: Added aria-setsize and aria-posinset for rendering split buttons #4044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
334fb03
added split button aria for contetual menu
Feb 21, 2018
53e37aa
add change files
Feb 21, 2018
f8337a8
added change file
Feb 21, 2018
0112519
added change file
Feb 21, 2018
80cf562
added change file
Feb 21, 2018
0456b8a
aqdded change file
Feb 21, 2018
9e3aea7
removed extra change files that appereard due to case error with bran…
Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/splitbuttonMeny_2018-02-21-18-32.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Contextual Menu - Added aria-posinset and aria-setsize to split buttons",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "chiechan@microsoft.com"
}
2 changes: 2 additions & 0 deletions packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,8 @@ export class ContextualMenu extends BaseComponent<IContextualMenuProps, IContext
aria-haspopup={ true }
aria-describedby={ item.ariaDescription }
aria-checked={ item.isChecked || item.checked }
aria-posinset={ focusableElementIndex + 1 }
Copy link
Copy Markdown
Member

@dzearing dzearing Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a change file so that this change gets published?

Copy link
Copy Markdown
Contributor Author

@chang47 chang47 Feb 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I knew I forgot something. Added.

aria-setsize={ totalItemCount }
>
<span
aria-hidden={ true }
Expand Down