Skip to content

Dropdown: Custom render options for multiselect - Bug fix #3571 #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 7 commits into from
Mar 2, 2018
Merged

Dropdown: Custom render options for multiselect - Bug fix #3571 #3589

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a564de
#3571 onRenderOption fix for Dropdown multiselect Mode
rohitjindal18 Dec 16, 2017
e27144a
Fixed Dropdown mutliselect onRenderOption #3571
rohitjindal18 Dec 17, 2017
8cf40e0
Fixed review comments
rohitjindal18 Feb 18, 2018
0b774db
Merge branch 'master' into bugFix3571
dzearing Feb 20, 2018
000e349
Added change file to PR
rohitjindal18 Feb 21, 2018
19f6556
Merge branch 'bugFix3571' of github.com:rohitjindal18/office-ui-fabri…
rohitjindal18 Feb 21, 2018
44aaad6
Update bugFix3571_2018-02-21-04-00.json
dzearing Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/office-ui-fabric-react/src/components/Dropdown/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@ export class Dropdown extends BaseComponent<IDropdownInternalProps, IDropdownSta
onMouseMove: this._onItemMouseMove.bind(this, item)
} }
label={ item.text }
onRenderLabel={ this._renderCustomLabel.bind(this, item) }

@erichdev erichdev Dec 23, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use @autobind. Also, _onRenderLabel might be a better name to match existing naming conventions in this file

className={ css(
'ms-ColumnManagementPanel-checkbox',
'ms-Dropdown-item', styles.item, {
Expand All @@ -531,8 +532,7 @@ export class Dropdown extends BaseComponent<IDropdownInternalProps, IDropdownSta
checkboxCheckedHovered: checkboxStyles.checkboxChecked,
textHovered: checkboxStyles.text
} }
>{ onRenderOption(item, this._onRenderOption) }
</Checkbox>
/>
)
);
}
Expand Down Expand Up @@ -843,5 +843,8 @@ export class Dropdown extends BaseComponent<IDropdownInternalProps, IDropdownSta
});
}
}

}
private _renderCustomLabel(item: IDropdownOption) {

@erichdev erichdev Dec 23, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor -- I don't think Fabric has any style guidelines on this, but I'd move this method up with all the other render functions, around line 545

const { onRenderOption = this._onRenderOption } = this.props;
return onRenderOption(item, this._onRenderOption);
}
}