Dropdown: Custom render options for multiselect - Bug fix #3571 #3589
Merged
dzearing merged 7 commits intomicrosoft:masterfrom Mar 2, 2018
Merged
Dropdown: Custom render options for multiselect - Bug fix #3571 #3589dzearing merged 7 commits intomicrosoft:masterfrom
dzearing merged 7 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@jakob101 Can you please review the changes |
Member
|
Yeah, give me a sec ;)
…________________________________
From: Rohit Jindal <notifications@github.com>
Sent: Monday, December 18, 2017 5:34:01 PM
To: OfficeDev/office-ui-fabric-react
Cc: Jakob Werner; Mention
Subject: Re: [OfficeDev/office-ui-fabric-react] Bug fix #3571 (#3589)
@jakob101<https://github.com/jakob101> Can you please review the changes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#3589 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA-v2q0xHgvtGwWiRdQ7CnO8v55VO9AQks5tBpP5gaJpZM4RElL->.
|
Contributor
Author
|
@jakob101 Are any changes required in the code? |
erichdev
suggested changes
Dec 23, 2017
Contributor
erichdev
left a comment
erichdev
left a comment
There was a problem hiding this comment.
Please also add a change file
| onMouseMove: this._onItemMouseMove.bind(this, item) | ||
| } } | ||
| label={ item.text } | ||
| onRenderLabel={ this._renderCustomLabel.bind(this, item) } |
Contributor
There was a problem hiding this comment.
Use @autobind. Also, _onRenderLabel might be a better name to match existing naming conventions in this file
| } | ||
|
|
||
| } | ||
| private _renderCustomLabel(item: IDropdownOption) { |
Contributor
There was a problem hiding this comment.
Minor -- I don't think Fabric has any style guidelines on this, but I'd move this method up with all the other render functions, around line 545
erichdev
changed the title
Collaborator
|
Hi @rohitjindal18, this has been open for a while. The comments are simple to fix. Do you still want to merge this? |
Contributor
Author
|
@manishgarg1 Have fixed the review comments, one screener check is not passing, saw the dashboard, there is visual change in multi select example for dropdown, but doesn't look like an issue. |
Member
|
We need a change file here. You can run |
|
|
Contributor
Author
|
Added change file @dzearing @manishgarg1 |
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Mar 4, 2018
* master: (30 commits) Addressing Issue microsoft#4147 - Nav Buttons have invalid `aria-describedby` value (microsoft#4159) Fix issue 3608: DetailsList horizontal scroll (microsoft#4164) Update package.json Image SCSS to MergeStyles Part 2: Style Conversion (microsoft#4151) Applying package updates. [SpinButton] Consistent styles to Button and TextField (microsoft#4098) ChoiceGroup: Flex layout for image and icon options (microsoft#4137) Initial set of Keytips work in experiments (microsoft#4062) Updating tsconfig in button bundle. BaseExtendedPicker: Create contextmenu for renderedItem, fix auto focus (microsoft#3954) Dropdown: Custom render options for multiselect - Bug fix microsoft#3571 (microsoft#3589) Fix documentcard theming (microsoft#4155) BasePicker: Fix not used onBlur callback of inputProps (microsoft#4000) (microsoft#4131) Allow Elements as Callout targets (microsoft#4134) CommandBar: Fixed null commandItemWidths (microsoft#4136) add check for when this.suggestionElement may be undefined (microsoft#4157) Addressing Issue microsoft#4143 - is-selected missing on ms-Nav-link (microsoft#4158) Aria selected (microsoft#4161) Move fabric to TypeScript 2.7.2 (microsoft#4153) Updating SearchBox examples to have the removed string in placeholder prop. ...
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Mar 5, 2018
* master: (51 commits) Applying package updates. No unused variable (microsoft#4173) Use correct _list ref string (microsoft#4168) Nav: wire a link to expand/collapse behavior if it has no URL but has children (microsoft#4171) Addressing Issue microsoft#4147 - Nav Buttons have invalid `aria-describedby` value (microsoft#4159) Fix issue 3608: DetailsList horizontal scroll (microsoft#4164) Update package.json Image SCSS to MergeStyles Part 2: Style Conversion (microsoft#4151) Applying package updates. [SpinButton] Consistent styles to Button and TextField (microsoft#4098) ChoiceGroup: Flex layout for image and icon options (microsoft#4137) Initial set of Keytips work in experiments (microsoft#4062) Updating tsconfig in button bundle. BaseExtendedPicker: Create contextmenu for renderedItem, fix auto focus (microsoft#3954) Dropdown: Custom render options for multiselect - Bug fix microsoft#3571 (microsoft#3589) Fix documentcard theming (microsoft#4155) BasePicker: Fix not used onBlur callback of inputProps (microsoft#4000) (microsoft#4131) Allow Elements as Callout targets (microsoft#4134) CommandBar: Fixed null commandItemWidths (microsoft#4136) add check for when this.suggestionElement may be undefined (microsoft#4157) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
onRenderOptiondoesnt work. #3571$ npm run changeDescription of changes
Dropdown used Checkbox component in case of multiselect mode, and CommandButton component in case of non multiselect mode.
onRenderOption was not getting used in Dropdown multiselect Mode, onRenderOption was being passed as Checkbox children, but Checkbox was not making use of its children, instead it accepts a onRenderLabel prop to render custom JSX.
Passed onRenderOption in onRenderLabel props
Focus areas to test
Pass multiSelect as true and onRenderOption to render custom JXS for Dropdown options.