ci(vrt): bump vr-approval-cli to 0.4.5 and use new create policy api #32110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanWatanabe
changed the title
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 76 | 87 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 634 | 668 | 5000 | |
| Button | mount | 298 | 296 | 5000 | |
| Field | mount | 1142 | 1141 | 5000 | |
| FluentProvider | mount | 704 | 744 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 87 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 41 | 37 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 78 | 10 | |
| MakeStyles | mount | 843 | 870 | 50000 | |
| Persona | mount | 1748 | 1715 | 5000 | |
| SpinButton | mount | 1388 | 1401 | 5000 | |
| SwatchPicker | mount | 1654 | 1675 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AccordionMinimalPerf.default | 95 | 79 | 1.2:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| FlexMinimalPerf.default | 171 | 150 | 1.14:1 |
| PortalMinimalPerf.default | 95 | 83 | 1.14:1 |
| RefMinimalPerf.default | 122 | 110 | 1.11:1 |
| SkeletonMinimalPerf.default | 217 | 199 | 1.09:1 |
| FormMinimalPerf.default | 226 | 210 | 1.08:1 |
| RadioGroupMinimalPerf.default | 277 | 258 | 1.07:1 |
| ButtonMinimalPerf.default | 91 | 86 | 1.06:1 |
| LoaderMinimalPerf.default | 190 | 179 | 1.06:1 |
| PopupMinimalPerf.default | 369 | 347 | 1.06:1 |
| AttachmentSlotsPerf.default | 643 | 612 | 1.05:1 |
| ImageMinimalPerf.default | 236 | 225 | 1.05:1 |
| TextAreaMinimalPerf.default | 291 | 276 | 1.05:1 |
| DividerMinimalPerf.default | 210 | 202 | 1.04:1 |
| DropdownManyItemsPerf.default | 396 | 379 | 1.04:1 |
| LabelMinimalPerf.default | 219 | 210 | 1.04:1 |
| TextMinimalPerf.default | 198 | 190 | 1.04:1 |
| AlertMinimalPerf.default | 171 | 166 | 1.03:1 |
| CheckboxMinimalPerf.default | 1164 | 1132 | 1.03:1 |
| DialogMinimalPerf.default | 456 | 441 | 1.03:1 |
| MenuMinimalPerf.default | 510 | 497 | 1.03:1 |
| MenuButtonMinimalPerf.default | 962 | 934 | 1.03:1 |
| SplitButtonMinimalPerf.default | 2257 | 2188 | 1.03:1 |
| ToolbarMinimalPerf.default | 536 | 520 | 1.03:1 |
| TooltipMinimalPerf.default | 1275 | 1232 | 1.03:1 |
| TreeMinimalPerf.default | 482 | 467 | 1.03:1 |
| TreeWith60ListItems.default | 93 | 90 | 1.03:1 |
| AnimationMinimalPerf.default | 305 | 299 | 1.02:1 |
| BoxMinimalPerf.default | 200 | 197 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 723 | 707 | 1.02:1 |
| ListCommonPerf.default | 378 | 371 | 1.02:1 |
| ProviderMergeThemesPerf.default | 643 | 633 | 1.02:1 |
| SegmentMinimalPerf.default | 196 | 192 | 1.02:1 |
| CarouselMinimalPerf.default | 259 | 257 | 1.01:1 |
| HeaderMinimalPerf.default | 211 | 208 | 1.01:1 |
| InputMinimalPerf.default | 545 | 542 | 1.01:1 |
| SliderMinimalPerf.default | 752 | 742 | 1.01:1 |
| ListMinimalPerf.default | 306 | 307 | 1:1 |
| ListWith60ListItems.default | 369 | 368 | 1:1 |
| ProviderMinimalPerf.default | 208 | 209 | 1:1 |
| VideoMinimalPerf.default | 447 | 445 | 1:1 |
| ButtonSlotsPerf.default | 312 | 315 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 155 | 157 | 0.99:1 |
| ChatMinimalPerf.default | 431 | 436 | 0.99:1 |
| DropdownMinimalPerf.default | 1383 | 1395 | 0.99:1 |
| RosterPerf.default | 1594 | 1616 | 0.99:1 |
| StatusMinimalPerf.default | 382 | 385 | 0.99:1 |
| CustomToolbarPrototype.default | 1449 | 1457 | 0.99:1 |
| AvatarMinimalPerf.default | 102 | 104 | 0.98:1 |
| ButtonOverridesMissPerf.default | 633 | 644 | 0.98:1 |
| ChatWithPopoverPerf.default | 196 | 199 | 0.98:1 |
| DatepickerMinimalPerf.default | 3524 | 3600 | 0.98:1 |
| EmbedMinimalPerf.default | 1890 | 1923 | 0.98:1 |
| HeaderSlotsPerf.default | 461 | 470 | 0.98:1 |
| LayoutMinimalPerf.default | 200 | 204 | 0.98:1 |
| IconMinimalPerf.default | 379 | 387 | 0.98:1 |
| TableManyItemsPerf.default | 1099 | 1122 | 0.98:1 |
| GridMinimalPerf.default | 185 | 190 | 0.97:1 |
| ListNestedPerf.default | 312 | 326 | 0.96:1 |
| ReactionMinimalPerf.default | 203 | 211 | 0.96:1 |
| TableMinimalPerf.default | 219 | 228 | 0.96:1 |
| AttachmentMinimalPerf.default | 77 | 81 | 0.95:1 |
| CardMinimalPerf.default | 287 | 312 | 0.92:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 632 | 647 | 5000 | |
| Breadcrumb | mount | 1708 | 1700 | 1000 | |
| Checkbox | mount | 1676 | 1718 | 5000 | |
| CheckboxBase | mount | 1503 | 1528 | 5000 | |
| ChoiceGroup | mount | 2894 | 3060 | 5000 | |
| ComboBox | mount | 681 | 691 | 1000 | |
| CommandBar | mount | 6603 | 6575 | 1000 | |
| ContextualMenu | mount | 13142 | 13308 | 1000 | |
| DefaultButton | mount | 817 | 801 | 5000 | |
| DetailsRow | mount | 2185 | 2230 | 5000 | |
| DetailsRowFast | mount | 2221 | 2244 | 5000 | |
| DetailsRowNoStyles | mount | 2032 | 2032 | 5000 | |
| Dialog | mount | 2707 | 2756 | 1000 | |
| DocumentCardTitle | mount | 245 | 239 | 1000 | |
| Dropdown | mount | 2047 | 2016 | 5000 | |
| FocusTrapZone | mount | 1191 | 1147 | 5000 | |
| FocusZone | mount | 1109 | 1127 | 5000 | |
| GroupedList | mount | 42053 | 42387 | 2 | |
| GroupedList | virtual-rerender | 20287 | 20256 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51663 | 51833 | 2 | |
| GroupedListV2 | mount | 234 | 222 | 2 | |
| GroupedListV2 | virtual-rerender | 217 | 212 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 236 | 227 | 2 | |
| IconButton | mount | 1126 | 1135 | 5000 | |
| Label | mount | 344 | 339 | 5000 | |
| Layer | mount | 2747 | 2737 | 5000 | |
| Link | mount | 397 | 399 | 5000 | |
| MenuButton | mount | 990 | 1006 | 5000 | |
| MessageBar | mount | 21775 | 21884 | 5000 | |
| Nav | mount | 2033 | 2114 | 1000 | |
| OverflowSet | mount | 805 | 803 | 5000 | |
| Panel | mount | 1849 | 1891 | 1000 | |
| Persona | mount | 715 | 764 | 1000 | |
| Pivot | mount | 887 | 887 | 1000 | |
| PrimaryButton | mount | 924 | 931 | 5000 | |
| Rating | mount | 4710 | 4654 | 5000 | |
| SearchBox | mount | 932 | 942 | 5000 | |
| Shimmer | mount | 1914 | 1889 | 5000 | |
| Slider | mount | 1341 | 1356 | 5000 | |
| SpinButton | mount | 2969 | 3035 | 5000 | |
| Spinner | mount | 395 | 391 | 5000 | |
| SplitButton | mount | 1875 | 1900 | 5000 | |
| Stack | mount | 416 | 431 | 5000 | |
| StackWithIntrinsicChildren | mount | 865 | 865 | 5000 | |
| StackWithTextChildren | mount | 2761 | 2815 | 5000 | |
| SwatchColorPicker | mount | 6358 | 6440 | 5000 | |
| TagPicker | mount | 1508 | 1458 | 5000 | |
| Text | mount | 389 | 404 | 5000 | |
| TextField | mount | 945 | 919 | 5000 | |
| ThemeProvider | mount | 861 | 875 | 5000 | |
| ThemeProvider | virtual-rerender | 592 | 585 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1294 | 1294 | 5000 | |
| Toggle | mount | 616 | 635 | 5000 | |
| buttonNative | mount | 195 | 197 | 5000 |
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Jul 25, 2024
Hotell
reviewed
Jul 26, 2024
TristanWatanabe
changed the title
TristanWatanabe
deleted the
tristan/remove-usage-of-secret-in-update-vr-policy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
vr-approval-clito latest0.4.5and uses newcreate-policyAPI in VR PR pipelines which removes the need for passing client secrets_NEWpostfix (actual variable value changes have been applied in the pipeline behind the scenes)Related Changes: