Skip to content

ci(vrt): upgrade VR tool to be security compliant #31997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TristanWatanabe merged 25 commits into from
Jul 19, 2024
Merged

ci(vrt): upgrade VR tool to be security compliant #31997

TristanWatanabe merged 25 commits into from
Jul 19, 2024

Conversation

@TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Jul 15, 2024 •
edited
Loading

Changes:

  • bumps vr-tool-cli to latest 0.4.3 which supports Managed Identity authentication with azure storage
    • as part of this process, now using AzureCLI@2 task instead of plain bash scripts within job steps as that allows for managed identity auth
    • also addds new required environment variables all stored in Azure Key Vault: 
       STORAGE_ACCOUNT_ID
 TENANT_ID
 PRINCIPAL_CLIENT_ID
 SERVICE_CONNECTION_ID
 SYSTEM_ACCESSTOKEN
    • now using new function app stored as VR_APP_API_URL_NEW

@github-actions github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 15, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 15, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 635 641 5000
Button mount 311 313 5000
Field mount 1147 1111 5000
FluentProvider mount 733 737 5000
FluentProviderWithTheme mount 80 82 10
FluentProviderWithTheme virtual-rerender 38 47 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 67 10
MakeStyles mount 893 887 50000
Persona mount 1786 1765 5000
SpinButton mount 1429 1444 5000
SwatchPicker mount 1699 1674 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 15, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 129 108 1.19:1
ChatDuplicateMessagesPerf.default 168 146 1.15:1
PortalMinimalPerf.default 92 81 1.14:1
AttachmentMinimalPerf.default 88 80 1.1:1
GridMinimalPerf.default 202 185 1.09:1
TableMinimalPerf.default 247 227 1.09:1
ButtonMinimalPerf.default 98 91 1.08:1
LabelMinimalPerf.default 234 219 1.07:1
TooltipMinimalPerf.default 1368 1284 1.07:1
SegmentMinimalPerf.default 207 195 1.06:1
HeaderSlotsPerf.default 484 463 1.05:1
SkeletonMinimalPerf.default 200 190 1.05:1
TextMinimalPerf.default 199 189 1.05:1
ToolbarMinimalPerf.default 562 537 1.05:1
ButtonSlotsPerf.default 321 310 1.04:1
DialogMinimalPerf.default 454 436 1.04:1
SliderMinimalPerf.default 774 745 1.04:1
AnimationMinimalPerf.default 314 305 1.03:1
BoxMinimalPerf.default 200 194 1.03:1
ChatMinimalPerf.default 457 445 1.03:1
DividerMinimalPerf.default 210 203 1.03:1
FormMinimalPerf.default 228 221 1.03:1
ImageMinimalPerf.default 236 229 1.03:1
ListMinimalPerf.default 316 306 1.03:1
ListNestedPerf.default 340 329 1.03:1
LoaderMinimalPerf.default 193 188 1.03:1
MenuButtonMinimalPerf.default 982 953 1.03:1
TableManyItemsPerf.default 1120 1088 1.03:1
CardMinimalPerf.default 326 319 1.02:1
ChatWithPopoverPerf.default 209 205 1.02:1
EmbedMinimalPerf.default 1864 1829 1.02:1
ItemLayoutMinimalPerf.default 696 682 1.02:1
LayoutMinimalPerf.default 205 201 1.02:1
ReactionMinimalPerf.default 222 218 1.02:1
RefMinimalPerf.default 117 115 1.02:1
IconMinimalPerf.default 383 376 1.02:1
CustomToolbarPrototype.default 1534 1497 1.02:1
CheckboxMinimalPerf.default 1131 1121 1.01:1
DatepickerMinimalPerf.default 3881 3837 1.01:1
DropdownMinimalPerf.default 1440 1426 1.01:1
FlexMinimalPerf.default 162 160 1.01:1
ProviderMergeThemesPerf.default 660 651 1.01:1
RosterPerf.default 1606 1605 1:1
ProviderMinimalPerf.default 206 205 1:1
RadioGroupMinimalPerf.default 259 259 1:1
HeaderMinimalPerf.default 203 205 0.99:1
InputMinimalPerf.default 534 537 0.99:1
ListCommonPerf.default 403 409 0.99:1
ListWith60ListItems.default 365 367 0.99:1
MenuMinimalPerf.default 505 511 0.99:1
PopupMinimalPerf.default 352 358 0.98:1
SplitButtonMinimalPerf.default 2294 2339 0.98:1
TreeMinimalPerf.default 483 491 0.98:1
AttachmentSlotsPerf.default 621 641 0.97:1
VideoMinimalPerf.default 435 447 0.97:1
StatusMinimalPerf.default 384 399 0.96:1
ButtonOverridesMissPerf.default 645 680 0.95:1
CarouselMinimalPerf.default 253 266 0.95:1
DropdownManyItemsPerf.default 390 410 0.95:1
TextAreaMinimalPerf.default 288 305 0.94:1
AlertMinimalPerf.default 154 166 0.93:1
TreeWith60ListItems.default 85 93 0.91:1
AccordionMinimalPerf.default 85 95 0.89:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 15, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 15, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 629 641 5000
Breadcrumb mount 1668 1717 1000
Checkbox mount 1689 1709 5000
CheckboxBase mount 1489 1476 5000
ChoiceGroup mount 3011 2940 5000
ComboBox mount 662 680 1000
CommandBar mount 6562 6608 1000
ContextualMenu mount 11986 12054 1000
DefaultButton mount 776 782 5000
DetailsRow mount 2274 2247 5000
DetailsRowFast mount 2267 2224 5000
DetailsRowNoStyles mount 2063 2029 5000
Dialog mount 2659 2791 1000
DocumentCardTitle mount 218 238 1000
Dropdown mount 2028 2007 5000
FocusTrapZone mount 1149 1165 5000
FocusZone mount 1065 1079 5000
GroupedList mount 42209 42453 2
GroupedList virtual-rerender 20496 20357 2
GroupedList virtual-rerender-with-unmount 52117 51565 2
GroupedListV2 mount 220 235 2
GroupedListV2 virtual-rerender 224 220 2
GroupedListV2 virtual-rerender-with-unmount 233 230 2
IconButton mount 1152 1149 5000
Label mount 343 347 5000
Layer mount 2779 2739 5000
Link mount 397 397 5000
MenuButton mount 966 1004 5000
MessageBar mount 21218 21265 5000
Nav mount 2073 2052 1000
OverflowSet mount 789 765 5000
Panel mount 1893 1841 1000
Persona mount 756 767 1000
Pivot mount 908 903 1000
PrimaryButton mount 933 946 5000
Rating mount 4722 4708 5000
SearchBox mount 946 931 5000
Shimmer mount 2006 1987 5000
Slider mount 1351 1346 5000
SpinButton mount 3033 2985 5000
Spinner mount 400 407 5000
SplitButton mount 1927 1865 5000
Stack mount 430 427 5000
StackWithIntrinsicChildren mount 874 876 5000
StackWithTextChildren mount 2770 2800 5000
SwatchColorPicker mount 6476 6440 5000
TagPicker mount 1510 1465 5000
Text mount 381 418 5000
TextField mount 926 940 5000
ThemeProvider mount 873 854 5000
ThemeProvider virtual-rerender 585 587 5000
ThemeProvider virtual-rerender-with-unmount 1308 1298 5000
Toggle mount 633 626 5000
buttonNative mount 195 190 5000

@TristanWatanabe TristanWatanabe force-pushed the tristan/vr-tool-compliance branch from 5966c65 to daefa7e Compare July 16, 2024 18:44
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 16, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 16, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam
fabricteam reviewed Jul 17, 2024
View reviewed changes
@TristanWatanabe TristanWatanabe changed the title chore(CI): make VR tool compliant ci(vrt): upgrade VR tool to be security compliant Jul 19, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 19, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

@TristanWatanabe TristanWatanabe marked this pull request as ready for review July 19, 2024 16:58
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner July 19, 2024 16:58
@TristanWatanabe TristanWatanabe enabled auto-merge (squash) July 19, 2024 17:55
@TristanWatanabe TristanWatanabe merged commit 651b92e into master Jul 19, 2024
@TristanWatanabe TristanWatanabe deleted the tristan/vr-tool-compliance branch July 19, 2024 17:56
@TristanWatanabe TristanWatanabe mentioned this pull request Jul 19, 2024
Closed
@Hotell Hotell mentioned this pull request Jul 22, 2024
Merged
@TristanWatanabe TristanWatanabe mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@dmytrokirpa dmytrokirpa dmytrokirpa approved these changes

@dannyvv dannyvv dannyvv approved these changes

Assignees

No one assigned

Labels

Area: Storywright CI

Projects

None yet

Milestone

July Project Cycle Q3 2024

Development

Successfully merging this pull request may close these issues.

6 participants

@TristanWatanabe @fabricteam @dmytrokirpa @dannyvv @Hotell