fix(workspace-tools): make generators work with new project.json#name pattern which doesn't include npmScope - #31959
Merged
Martin Hochel (Hotell) merged 2 commits intoJul 10, 2024
Conversation
… pattern which doesn't include npmScope
Martin Hochel (Hotell)
changed the title
Collaborator
📊 Bundle size report✅ No changes found |
Dmytro Kirpa (dmytrokirpa)
approved these changes
Jul 10, 2024
Tristan Watanabe (TristanWatanabe)
approved these changes
Jul 10, 2024
Tristan Watanabe (TristanWatanabe)
left a comment
Tristan Watanabe (TristanWatanabe)
left a comment
Member
There was a problem hiding this comment.
Just a couple of nits
…on#name pattern which doesn't include npmScope
Martin Hochel (Hotell)
enabled auto-merge (squash)
July 10, 2024 15:36
Martin Hochel (Hotell)
deleted the
nx/fix/generators-issues-after-project-name-changes
branch
July 10, 2024 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
all workspace generators are broken
New Behavior
all workspace generators work
Related Issue(s)