Skip to content

fix: revert incorectly set react versions in all packages - #31937

Merged
Martin Hochel (Hotell) merged 6 commits into
microsoft:masterfrom
Hotell:nx/fix/release-react-package-mismatch
Jul 8, 2024
Merged

fix: revert incorectly set react versions in all packages#31937
Martin Hochel (Hotell) merged 6 commits into
microsoft:masterfrom
Hotell:nx/fix/release-react-package-mismatch

Conversation

@Hotell

@Hotell Martin Hochel (Hotell) commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

  • dependency-mismatch generator has been fixed
  • all affected packages have been reverted to contain proper version/version range for npm dependency
  • added missing tags to project.json

Related Issue(s)

@github-actions github-actions Bot added this to the July Project Cycle Q3 2024 milestone Jul 8, 2024
@Hotell
fix(workspace-plugin): update only workspace dependencies when runnin…
504c6a0 
…g dependency-mismatch generator during release
fabricteam
Fluent UI Team (fabricteam) reviewed Jul 8, 2024
View reviewed changes
Comment thread apps/perf-test-react-components/package.json
@fabricteam

Fluent UI Team (fabricteam) commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 602 592 5000
Button mount 303 303 5000
Field mount 1149 1130 5000
FluentProvider mount 696 689 5000
FluentProviderWithTheme mount 83 78 10
FluentProviderWithTheme virtual-rerender 36 38 10
FluentProviderWithTheme virtual-rerender-with-unmount 67 75 10
MakeStyles mount 868 888 50000
Persona mount 1769 1710 5000
SpinButton mount 1439 1393 5000
SwatchPicker mount 1608 1658 5000

fabricteam
Fluent UI Team (fabricteam) reviewed Jul 8, 2024
View reviewed changes
Comment thread apps/perf-test-react-components/package.json
@fabricteam

Fluent UI Team (fabricteam) commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 88 76 1.16:1
BoxMinimalPerf.default 205 181 1.13:1
CardMinimalPerf.default 329 296 1.11:1
ButtonMinimalPerf.default 93 85 1.09:1
ImageMinimalPerf.default 229 213 1.08:1
ChatWithPopoverPerf.default 205 193 1.06:1
HeaderMinimalPerf.default 214 202 1.06:1
ListNestedPerf.default 330 311 1.06:1
PortalMinimalPerf.default 83 78 1.06:1
AttachmentSlotsPerf.default 667 637 1.05:1
CheckboxMinimalPerf.default 1145 1093 1.05:1
FormMinimalPerf.default 228 218 1.05:1
LoaderMinimalPerf.default 192 183 1.05:1
RefMinimalPerf.default 116 112 1.04:1
SkeletonMinimalPerf.default 205 198 1.04:1
AnimationMinimalPerf.default 300 290 1.03:1
GridMinimalPerf.default 182 177 1.03:1
ItemLayoutMinimalPerf.default 712 691 1.03:1
LayoutMinimalPerf.default 197 192 1.03:1
MenuMinimalPerf.default 509 494 1.03:1
SegmentMinimalPerf.default 203 197 1.03:1
StatusMinimalPerf.default 400 388 1.03:1
TextMinimalPerf.default 196 191 1.03:1
ButtonSlotsPerf.default 312 307 1.02:1
CarouselMinimalPerf.default 266 262 1.02:1
ChatMinimalPerf.default 442 434 1.02:1
DialogMinimalPerf.default 448 438 1.02:1
DividerMinimalPerf.default 209 205 1.02:1
PopupMinimalPerf.default 350 342 1.02:1
ProviderMergeThemesPerf.default 649 635 1.02:1
TableManyItemsPerf.default 1123 1105 1.02:1
ChatDuplicateMessagesPerf.default 146 144 1.01:1
DropdownManyItemsPerf.default 387 383 1.01:1
EmbedMinimalPerf.default 1871 1848 1.01:1
FlexMinimalPerf.default 154 153 1.01:1
InputMinimalPerf.default 545 539 1.01:1
ListCommonPerf.default 386 384 1.01:1
ListMinimalPerf.default 307 303 1.01:1
MenuButtonMinimalPerf.default 951 944 1.01:1
IconMinimalPerf.default 385 380 1.01:1
TextAreaMinimalPerf.default 285 283 1.01:1
CustomToolbarPrototype.default 1456 1445 1.01:1
TreeMinimalPerf.default 478 475 1.01:1
LabelMinimalPerf.default 218 217 1:1
RadioGroupMinimalPerf.default 265 264 1:1
ReactionMinimalPerf.default 217 217 1:1
TableMinimalPerf.default 235 234 1:1
ToolbarMinimalPerf.default 528 530 1:1
TreeWith60ListItems.default 83 83 1:1
AvatarMinimalPerf.default 110 111 0.99:1
DatepickerMinimalPerf.default 3528 3570 0.99:1
DropdownMinimalPerf.default 1394 1408 0.99:1
ListWith60ListItems.default 358 363 0.99:1
ProviderMinimalPerf.default 203 205 0.99:1
AccordionMinimalPerf.default 87 89 0.98:1
ButtonOverridesMissPerf.default 657 669 0.98:1
VideoMinimalPerf.default 430 440 0.98:1
SliderMinimalPerf.default 715 734 0.97:1
SplitButtonMinimalPerf.default 2209 2276 0.97:1
TooltipMinimalPerf.default 1245 1286 0.97:1
HeaderSlotsPerf.default 451 468 0.96:1
AlertMinimalPerf.default 157 167 0.94:1
RosterPerf.default 1514 1626 0.93:1

@fabricteam

Fluent UI Team (fabricteam) commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@Hotell
fixup! fix(workspace-plugin): update only workspace dependencies when…
7bfd933 
… running dependency-mismatch generator during release
@fabricteam

Fluent UI Team (fabricteam) commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam

Fluent UI Team (fabricteam) commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 619 642 5000
Breadcrumb mount 1674 1681 1000
Checkbox mount 1670 1705 5000
CheckboxBase mount 1477 1503 5000
ChoiceGroup mount 2978 2971 5000
ComboBox mount 690 695 1000
CommandBar mount 6591 6583 1000
ContextualMenu mount 12461 12105 1000
DefaultButton mount 819 786 5000
DetailsRow mount 2244 2198 5000
DetailsRowFast mount 2272 2264 5000
DetailsRowNoStyles mount 2030 2028 5000
Dialog mount 2664 2823 1000
DocumentCardTitle mount 230 229 1000
Dropdown mount 2003 1995 5000
FocusTrapZone mount 1149 1167 5000
FocusZone mount 1094 1099 5000
GroupedList mount 37703 42620 2
GroupedList virtual-rerender 17918 20544 2
GroupedList virtual-rerender-with-unmount 51969 51173 2
GroupedListV2 mount 226 228 2
GroupedListV2 virtual-rerender 219 214 2
GroupedListV2 virtual-rerender-with-unmount 238 231 2
IconButton mount 1114 1172 5000
Label mount 341 351 5000
Layer mount 2742 2736 5000
Link mount 395 396 5000
MenuButton mount 979 989 5000
MessageBar mount 21633 21764 5000
Nav mount 2084 2050 1000
OverflowSet mount 784 766 5000
Panel mount 1805 1833 1000
Persona mount 737 743 1000
Pivot mount 946 923 1000
PrimaryButton mount 950 941 5000
Rating mount 4656 4688 5000
SearchBox mount 908 903 5000
Shimmer mount 1878 1944 5000
Slider mount 1303 1334 5000
SpinButton mount 3038 2891 5000
Spinner mount 393 404 5000
SplitButton mount 1865 1916 5000
Stack mount 418 428 5000
StackWithIntrinsicChildren mount 876 851 5000
StackWithTextChildren mount 2821 2832 5000
SwatchColorPicker mount 6522 6309 5000
TagPicker mount 1503 1554 5000
Text mount 379 382 5000
TextField mount 950 928 5000
ThemeProvider mount 846 847 5000
ThemeProvider virtual-rerender 595 586 5000
ThemeProvider virtual-rerender-with-unmount 1279 1308 5000
Toggle mount 608 604 5000
buttonNative mount 185 195 5000

fabricteam
Fluent UI Team (fabricteam) reviewed Jul 8, 2024
View reviewed changes
Comment thread apps/perf-test-react-components/package.json
@Hotell
Martin Hochel (Hotell) marked this pull request as ready for review July 8, 2024 11:35
@Hotell
Martin Hochel (Hotell) merged commit 4edb54e into microsoft:master Jul 8, 2024
@Hotell
Martin Hochel (Hotell) deleted the nx/fix/release-react-package-mismatch branch July 8, 2024 11:46
This was referenced Jul 8, 2024
Merged
Merged
@Hotell Martin Hochel (Hotell) mentioned this pull request Aug 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam Fluent UI Team (fabricteam) fabricteam left review comments
@dmytrokirpa Dmytro Kirpa (dmytrokirpa) dmytrokirpa approved these changes
@jurokapsiar Juraj Kapsiar (jurokapsiar) jurokapsiar approved these changes
@sopranopillow Esteban Munoz Facusse (sopranopillow) Awaiting requested review from sopranopillow sopranopillow is a code owner
@Mitch-At-Work Mitch-At-Work Awaiting requested review from Mitch-At-Work Mitch-At-Work is a code owner
@tomi-msft Tomi Olubeko (tomi-msft) Awaiting requested review from tomi-msft
@marcosmoura Marcos Moura (marcosmoura) Awaiting requested review from marcosmoura
@mltejera Mason Tejera (mltejera) Awaiting requested review from mltejera
@smhigley Sarah Higley (smhigley) Awaiting requested review from smhigley
@GeoffCoxMSFT Geoff Cox (Microsoft) (GeoffCoxMSFT) Awaiting requested review from GeoffCoxMSFT
@khmakoto Makoto Morimoto (khmakoto) Awaiting requested review from khmakoto khmakoto is a code owner
@ms-acalzaretto ms-acalzaretto Awaiting requested review from ms-acalzaretto
@chpalac chajun (chpalac) Awaiting requested review from chpalac chpalac is a code owner
@ling1726 ling1726 Awaiting requested review from ling1726
@behowell Ben Howell (behowell) Awaiting requested review from behowell
@spmonahan Sean Monahan (spmonahan) Awaiting requested review from spmonahan
@micahgodbolt Micah Godbolt (micahgodbolt) Awaiting requested review from micahgodbolt
@dzearing David Zearing (dzearing) Awaiting requested review from dzearing dzearing is a code owner
@Jahnp Peter Jahn (Jahnp) Awaiting requested review from Jahnp Jahnp is a code owner
@bigbadcapers C. Perez (bigbadcapers) Awaiting requested review from bigbadcapers bigbadcapers is a code owner

Assignees

No one assigned

Labels

Fluent UI react (v8) Issues about @fluentui/react (v8) Fluent UI react-components (v9)

Projects

None yet

Milestone

July Project Cycle Q3 2024

Development

Successfully merging this pull request may close these issues.

[Bug]: App not run in dev mode

4 participants

@Hotell @fabricteam @dmytrokirpa @jurokapsiar