feat: replace lerna-alias with nx APIs

package.json

@@ -162,7 +162,6 @@
     "@types/jest-axe": "3.5.5",
     "@types/jju": "1.4.1",
     "@types/json-schema": "^7.0.8",
-    "@types/lerna-alias": "3.0.0",
     "@types/loader-utils": "2.0.3",
     "@types/lodash": "4.14.182",
     "@types/markdown-table": "2.0.0",
@@ -272,7 +271,6 @@
     "just-scripts": "1.8.2",
     "lage": "1.8.8",
     "lerna": "7.1.3",
-    "lerna-alias": "3.0.3-0",
     "license-webpack-plugin": "2.3.10",
     "lint-staged": "10.2.10",
     "loader-utils": "2.0.4",

packages/fluentui/accessibility/package.json

@@ -12,8 +12,7 @@
     "@fluentui/eslint-plugin": "*",
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
-    "@fluentui/scripts-jest": "*",
-    "lerna-alias": "^3.0.3-0"
+    "@fluentui/scripts-jest": "*"
   },
   "files": [
     "dist"

packages/fluentui/e2e/package.json

@@ -10,7 +10,6 @@
     "@fluentui/react-northstar": "*",
     "@fluentui/react-northstar-prototypes": "*",
     "@types/react-router-dom": "^5.1.5",
-    "lerna-alias": "^3.0.3-0",
     "lodash": "^4.17.15",
     "react-router-dom": "^5.2.0"
   },

packages/fluentui/perf/gulp/webpack.config.ts

@@ -56,7 +56,7 @@ export const webpackConfig: webpack.Configuration = {
     },
     extensions: ['.ts', '.tsx', '.js', '.json'],
     alias: {
-      ...config.lernaAliases({ type: 'webpack' }),
+      ...config.webpackAliases,
 
       // We are using React in production mode with tracing.
       // https://gist.github.com/bvaughn/25e6233aeb1b4f0cdb8d8366e54a3977

packages/fluentui/react-bindings/package.json

@@ -24,8 +24,7 @@
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
     "@fluentui/scripts-jest": "*",
-    "@types/classnames": "^2.2.9",
-    "lerna-alias": "^3.0.3-0"
+    "@types/classnames": "^2.2.9"
   },
   "files": [
     "dist"

packages/fluentui/react-builder/package.json

@@ -26,8 +26,7 @@
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
     "@fluentui/scripts-jest": "*",
-    "@types/react-frame-component": "^4.1.1",
-    "lerna-alias": "^3.0.3-0"
+    "@types/react-frame-component": "^4.1.1"
   },
   "peerDependencies": {
     "@babel/standalone": "^7.8.3",

packages/fluentui/react-component-event-listener/package.json

@@ -13,7 +13,6 @@
     "@fluentui/scripts-gulp": "*",
     "@fluentui/scripts-jest": "*",
     "@types/simulant": "^0.2.0",
-    "lerna-alias": "^3.0.3-0",
     "simulant": "^0.2.2"
   },
   "files": [

packages/fluentui/react-component-nesting-registry/package.json

@@ -12,8 +12,7 @@
     "@fluentui/eslint-plugin": "*",
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
-    "@fluentui/scripts-jest": "*",
-    "lerna-alias": "^3.0.3-0"
+    "@fluentui/scripts-jest": "*"
   },
   "files": [
     "dist"

packages/fluentui/react-component-ref/package.json

@@ -12,8 +12,7 @@
     "@fluentui/eslint-plugin": "*",
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
-    "@fluentui/scripts-jest": "*",
-    "lerna-alias": "^3.0.3-0"
+    "@fluentui/scripts-jest": "*"
   },
   "files": [
     "dist"

packages/fluentui/react-icons-northstar/package.json

@@ -15,8 +15,7 @@
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
     "@fluentui/scripts-jest": "*",
-    "@types/classnames": "^2.2.9",
-    "lerna-alias": "^3.0.3-0"
+    "@types/classnames": "^2.2.9"
   },
   "files": [
     "dist"

packages/fluentui/react-northstar-emotion-renderer/package.json

@@ -19,8 +19,7 @@
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
     "@fluentui/scripts-jest": "*",
-    "@types/stylis": "4.0.0",
-    "lerna-alias": "^3.0.3-0"
+    "@types/stylis": "4.0.0"
   },
   "files": [
     "dist"

packages/fluentui/react-northstar-fela-renderer/package.json

@@ -25,7 +25,6 @@
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
     "@fluentui/scripts-jest": "*",
-    "lerna-alias": "^3.0.3-0",
     "react-fela": "^10.6.1"
   },
   "files": [

packages/fluentui/react-northstar-styles-renderer/package.json

@@ -10,8 +10,7 @@
   "devDependencies": {
     "@fluentui/eslint-plugin": "*",
     "@fluentui/scripts-babel": "*",
-    "@fluentui/scripts-gulp": "*",
-    "lerna-alias": "^3.0.3-0"
+    "@fluentui/scripts-gulp": "*"
   },
   "files": [
     "dist"

packages/fluentui/react-northstar/package.json

@@ -41,7 +41,6 @@
     "csstype": "^3.0.2",
     "faker": "^4.1.0",
     "fela-tools": "^10.6.1",
-    "lerna-alias": "^3.0.3-0",
     "qs": "^6.8.0",
     "simulant": "^0.2.2"
   },

packages/fluentui/react-proptypes/package.json

@@ -13,8 +13,7 @@
     "@fluentui/eslint-plugin": "*",
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
-    "@fluentui/scripts-jest": "*",
-    "lerna-alias": "^3.0.3-0"
+    "@fluentui/scripts-jest": "*"
   },
   "files": [
     "dist"

packages/fluentui/react-telemetry/package.json

@@ -15,8 +15,7 @@
     "@fluentui/eslint-plugin": "*",
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
-    "@types/react-table": "^7.0.19",
-    "lerna-alias": "^3.0.3-0"
+    "@types/react-table": "^7.0.19"
   },
   "files": [
     "dist"

packages/fluentui/state/package.json

@@ -10,8 +10,7 @@
   "devDependencies": {
     "@fluentui/eslint-plugin": "*",
     "@fluentui/scripts-babel": "*",
-    "@fluentui/scripts-gulp": "*",
-    "lerna-alias": "^3.0.3-0"
+    "@fluentui/scripts-gulp": "*"
   },
   "files": [
     "dist"

packages/fluentui/styles/package.json

@@ -13,8 +13,7 @@
     "@fluentui/eslint-plugin": "*",
     "@fluentui/scripts-babel": "*",
     "@fluentui/scripts-gulp": "*",
-    "@fluentui/scripts-jest": "*",
-    "lerna-alias": "^3.0.3-0"
+    "@fluentui/scripts-jest": "*"
   },
   "files": [
     "dist"

scripts/gulp/src/config.ts

@@ -1,15 +1,32 @@
 /* eslint-disable @typescript-eslint/naming-convention */
 import * as path from 'path';
-import * as _ from 'lodash';
-import * as webpack from 'webpack';
 import { URL } from 'url';
 
-import { getLernaAliases } from '@fluentui/scripts-monorepo';
+import { getWorkspaceProjects, getWorkspaceProjectsAliases } from '@fluentui/scripts-monorepo';
+import * as _ from 'lodash';
+import * as webpack from 'webpack';
 
-// northstar packages should pull these from npm, not the repo
-const excludedPackages = ['@fluentui/dom-utilities'];
-const lernaAliases = (options: Omit<Parameters<typeof getLernaAliases>[number], 'excludedPackages'>) =>
-  getLernaAliases({ excludedPackages, ...options });
+const excludedPackages = [
+  // northstar packages should pull these from npm, not the repo
+  '@fluentui/dom-utilities',
+  // we need to apply aliases only for v0 projects - otherwise webpack will explode. This will(can) be mitigated by implementing no-build needed for v0 e2e (https://github.com/microsoft/fluentui/pull/26928/commits/6dbc149b54c251ba74b3ebb70057846389ed3f88#diff-f1ffee4111d5db5b78ed08c5318068a3b5e313d6dbc72b60231cc65e4bd5eb2a)
+  ...getProjectsExceptV0(),
+];
+
+const webpackAliases = getWorkspaceProjectsAliases({ excludeProjects: excludedPackages, type: 'webpack' });
+
+function getProjectsExceptV0() {
+  const projectConfigs = getWorkspaceProjects().values();
+  const projects: string[] = [];
+  for (const projectConfig of projectConfigs) {
+    const tags = projectConfig.tags ?? [];
+    if (!tags.includes('react-northstar')) {
+      projects.push(projectConfig.name!);
+    }
+  }
+
+  return projects;
+}
 
 // ------------------------------------
 // Environment vars
@@ -182,7 +199,7 @@ const config = {
   isRoot,
   /** Package name the task is running against: default to react if running at root, or cwd otherwise */
   package: packageName,
-  lernaAliases,
+  webpackAliases,
 };
 
 export default config;

scripts/gulp/src/tasks/test-dependencies/utils.ts

@@ -1,4 +1,5 @@
 import * as path from 'path';
+
 import { LicenseWebpackPlugin } from 'license-webpack-plugin';
 import webpack from 'webpack';
 
@@ -59,7 +60,7 @@ export const prepareWebpackConfig = (options: WebpackOptions) => {
     resolve: {
       extensions: ['.ts', '.tsx', '.js', '.json'],
       alias: {
-        ...config.lernaAliases({ type: 'webpack' }),
+        ...config.webpackAliases,
         src: paths.packageSrc('react-northstar'),
       },
     },

scripts/gulp/src/webpack/webpack.config.e2e.ts

@@ -57,7 +57,7 @@ const webpackConfig: webpack.Configuration = {
       path: require.resolve('path-browserify'),
     },
     extensions: ['.ts', '.tsx', '.js', '.json'],
-    alias: config.lernaAliases({ type: 'webpack' }),
+    alias: config.webpackAliases,
   },
   performance: {
     hints: false, // to (temporarily) disable "WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit")

scripts/gulp/src/webpack/webpack.config.ts

@@ -1,13 +1,12 @@
+import { getDefaultEnvironmentVars } from '@fluentui/scripts-monorepo';
 import CopyWebpackPlugin from 'copy-webpack-plugin';
+import ForkTsCheckerWebpackPlugin from 'fork-ts-checker-webpack-plugin';
 import HtmlWebpackPlugin from 'html-webpack-plugin';
 import _ from 'lodash';
-import webpack from 'webpack';
 import TerserPlugin from 'terser-webpack-plugin';
-import ForkTsCheckerWebpackPlugin from 'fork-ts-checker-webpack-plugin';
+import webpack from 'webpack';
 import { BundleAnalyzerPlugin } from 'webpack-bundle-analyzer';
 
-import { getDefaultEnvironmentVars } from '@fluentui/scripts-monorepo';
-
 import config from '../config';
 
 const { paths } = config;
@@ -125,7 +124,7 @@ const webpackConfig: webpack.Configuration &
   resolve: {
     extensions: ['.ts', '.tsx', '.js', '.json'],
     alias: {
-      ...config.lernaAliases({ type: 'webpack' }),
+      ...config.webpackAliases,
       src: paths.packageSrc('react-northstar'),
       faker: 'faker/locale/en',
       'react-hook-form': 'react-hook-form/dist/react-hook-form.ie11',

scripts/jest/src/jest.preset.v0.js

@@ -1,4 +1,4 @@
-const { getLernaAliases, workspaceRoot } = require('@fluentui/scripts-monorepo');
+const { getWorkspaceProjectsAliases } = require('@fluentui/scripts-monorepo');
 
 // northstar packages should pull these from npm, not the repo
 const excludedPackages = ['@fluentui/dom-utilities'];
@@ -20,10 +20,9 @@ const createConfig = (/** @type {import('@jest/types').Config.InitialOptions} */
   clearMocks: true,
   ...customConfig,
   moduleNameMapper: {
-    ...getLernaAliases({
+    ...getWorkspaceProjectsAliases({
       type: 'jest',
-      excludedPackages,
-      directory: workspaceRoot,
+      excludeProjects: excludedPackages,
     }),
     ...customConfig.moduleNameMapper,
   },

scripts/lint-staged/eslint.js

@@ -6,7 +6,8 @@ const fs = require('fs');
 const os = require('os');
 const path = require('path');
 const { promisify } = require('util');
-const { rollup: lernaAliases } = require('lerna-alias');
+
+const { getWorkspaceProjects, workspaceRoot } = require('@fluentui/scripts-monorepo');
 const { default: PQueue } = require('p-queue');
 const exec = promisify(child_process.exec);
 
@@ -28,13 +29,14 @@ function groupFilesByPackage() {
   /** @type {{ [packagePath: string]: string[] }} */
   const filesByPackage = {};
 
-  const packagesWithEslint = Object.values(lernaAliases({ sourceDirectory: false })).filter(
-    packagePath =>
-      // exclude @fluentui/noop (northstar packages root)
-      path.basename(packagePath) !== 'fluentui' &&
-      // only include packages with an eslintrc (any extension)
-      fs.readdirSync(packagePath).some(f => f.startsWith('.eslintrc')),
-  );
+  const packagesWithEslint = [];
+  const projects = getWorkspaceProjects();
+  for (const [, projectConfig] of projects) {
+    const absoluteRootPath = path.join(workspaceRoot, projectConfig.root);
+    if (fs.readdirSync(absoluteRootPath).some(f => f.startsWith('.eslintrc'))) {
+      packagesWithEslint.push(absoluteRootPath);
+    }
+  }
 
   for (const file of files) {
     // eslint-disable-next-line no-shadow

scripts/monorepo/src/getAllPackageInfo.js

@@ -1,7 +1,9 @@
-const fs = require('fs-extra');
+const fs = require('fs');
 const path = require('path');
-const lernaAlias = require('lerna-alias');
-const findGitRoot = require('./findGitRoot');
+
+const { workspaceRoot } = require('@nx/devkit');
+
+const { getWorkspaceProjects } = require('./workspace-utils');
 
 /**
  * @type {import('./types').AllPackageInfo}
@@ -20,19 +22,15 @@ function getAllPackageInfo() {
     return packageInfo;
   }
 
-  // Get mapping from package name to package path
-  // (rollup helper happens to be good for getting basic package name/path pairs)
-  const packagePaths = lernaAlias.rollup({ sourceDirectory: false });
-  delete packagePaths['@fluentui/noop']; // not a real package
+  const projects = getWorkspaceProjects();
 
   packageInfo = {};
   cwdForPackageInfo = process.cwd();
-  const gitRoot = findGitRoot();
 
-  for (const [packageName, packagePath] of Object.entries(packagePaths)) {
-    packageInfo[packageName] = {
-      packagePath: path.relative(gitRoot, packagePath),
-      packageJson: fs.readJSONSync(path.join(packagePath, 'package.json')),
+  for (const [projectName, projectConfig] of projects) {
+    packageInfo[projectName] = {
+      packagePath: projectConfig.root,
+      packageJson: JSON.parse(fs.readFileSync(path.join(workspaceRoot, projectConfig.root, 'package.json'), 'utf-8')),
     };
   }
 

scripts/monorepo/src/index.d.ts

@@ -5,9 +5,9 @@ export { default as findRepoDeps } from './findRepoDeps';
 export { default as getAllPackageInfo } from './getAllPackageInfo';
 export { isConvergedPackage, shipsAMD } from './isConvergedPackage';
 export { getAffectedPackages } from './getAffectedPackages';
-export { getLernaAliases } from './get-lerna-aliases';
 export { getDefaultEnvironmentVars } from './getDefaultEnvironmentVars';
 export { getProjectMetadata, workspaceRoot, getUncommittedFiles, getUntrackedFiles } from './utils';
 export * as eslintConstants from './eslint-constants';
 export { getNthCommit } from './getNthCommit';
 export { tree, flushTreeChanges } from './tree';
+export { getWorkspaceProjects, getWorkspaceProjectsAliases } from './workspace-utils';