feat: replace lerna-alias with nx APIs #30149

Hotell · 2023-12-21T15:47:35Z

Previous Behavior

lerna-alias (which uses deprecated lerna apis under the hood) is used to construct monorepo mappings to project paths

New Behavior

lerna-alias is completely replaced with nx

Related Issue(s)

Follows chore: migrate to lerna 7 #28647
Partially implements [Feature]: replace lerna with nx / make v0 release work #30265

fabricteam · 2023-12-21T15:57:13Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender-with-unmount	89	84	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	662	648	5000
Button	mount	305	320	5000
Field	mount	1159	1183	5000
FluentProvider	mount	719	722	5000
FluentProviderWithTheme	mount	93	94	10
FluentProviderWithTheme	virtual-rerender	78	78	10
FluentProviderWithTheme	virtual-rerender-with-unmount	89	84	10	Possible regression
MakeStyles	mount	846	857	50000
Persona	mount	1768	1770	5000
SpinButton	mount	1410	1422	5000

codesandbox-ci · 2023-12-21T16:01:03Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4c32728:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-12-21T16:01:54Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-12-21T16:02:31Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ReactionMinimalPerf.default	219	200	1.1:1
ChatDuplicateMessagesPerf.default	150	137	1.09:1
AlertMinimalPerf.default	156	146	1.07:1
CardMinimalPerf.default	322	300	1.07:1
LabelMinimalPerf.default	222	207	1.07:1
TreeWith60ListItems.default	85	80	1.06:1
ListMinimalPerf.default	312	296	1.05:1
PopupMinimalPerf.default	361	344	1.05:1
HeaderSlotsPerf.default	471	452	1.04:1
ImageMinimalPerf.default	231	222	1.04:1
InputMinimalPerf.default	552	533	1.04:1
ProviderMergeThemesPerf.default	658	632	1.04:1
TableMinimalPerf.default	223	214	1.04:1
AnimationMinimalPerf.default	297	289	1.03:1
AttachmentSlotsPerf.default	662	640	1.03:1
DialogMinimalPerf.default	450	437	1.03:1
EmbedMinimalPerf.default	1903	1852	1.03:1
ListWith60ListItems.default	377	367	1.03:1
SegmentMinimalPerf.default	195	189	1.03:1
SplitButtonMinimalPerf.default	2306	2241	1.03:1
TextMinimalPerf.default	199	193	1.03:1
AvatarMinimalPerf.default	108	106	1.02:1
CheckboxMinimalPerf.default	1131	1114	1.02:1
DropdownManyItemsPerf.default	404	397	1.02:1
DropdownMinimalPerf.default	1430	1403	1.02:1
HeaderMinimalPerf.default	206	201	1.02:1
PortalMinimalPerf.default	88	86	1.02:1
StatusMinimalPerf.default	382	373	1.02:1
CustomToolbarPrototype.default	1490	1455	1.02:1
ToolbarMinimalPerf.default	520	508	1.02:1
TreeMinimalPerf.default	466	458	1.02:1
BoxMinimalPerf.default	189	187	1.01:1
CarouselMinimalPerf.default	266	263	1.01:1
ChatMinimalPerf.default	424	420	1.01:1
FlexMinimalPerf.default	156	154	1.01:1
ListNestedPerf.default	322	318	1.01:1
MenuMinimalPerf.default	494	490	1.01:1
IconMinimalPerf.default	384	381	1.01:1
ButtonOverridesMissPerf.default	646	647	1:1
GridMinimalPerf.default	192	192	1:1
RosterPerf.default	1571	1564	1:1
VideoMinimalPerf.default	423	425	1:1
ButtonMinimalPerf.default	81	82	0.99:1
ChatWithPopoverPerf.default	193	194	0.99:1
DatepickerMinimalPerf.default	3533	3580	0.99:1
DividerMinimalPerf.default	198	201	0.99:1
ListCommonPerf.default	382	387	0.99:1
MenuButtonMinimalPerf.default	952	966	0.99:1
RefMinimalPerf.default	106	108	0.98:1
SliderMinimalPerf.default	734	749	0.98:1
TableManyItemsPerf.default	1085	1105	0.98:1
AttachmentMinimalPerf.default	76	78	0.97:1
ButtonSlotsPerf.default	315	324	0.97:1
RadioGroupMinimalPerf.default	252	260	0.97:1
FormMinimalPerf.default	219	227	0.96:1
LoaderMinimalPerf.default	184	191	0.96:1
ProviderMinimalPerf.default	192	201	0.96:1
TextAreaMinimalPerf.default	280	293	0.96:1
ItemLayoutMinimalPerf.default	689	723	0.95:1
LayoutMinimalPerf.default	187	196	0.95:1
SkeletonMinimalPerf.default	189	198	0.95:1
TooltipMinimalPerf.default	1244	1307	0.95:1
AccordionMinimalPerf.default	78	83	0.94:1

fabricteam · 2023-12-21T16:05:48Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2023-12-21T16:08:01Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`priority-overflow` createOverflowManager	`4.447 kB` `1.853 kB`
`react-accordion` Accordion (including children components)	`93.888 kB` `28.673 kB`
`react-alert` Alert	`83.737 kB` `23.474 kB`
`react-avatar` Avatar	`50.175 kB` `15.944 kB`
`react-avatar` AvatarGroup	`19.704 kB` `7.796 kB`
`react-avatar` AvatarGroupItem	`64.831 kB` `20.274 kB`
`react-badge` Badge	`26.905 kB` `8.729 kB`
`react-badge` CounterBadge	`27.806 kB` `9.024 kB`
`react-badge` PresenceBadge	`25.311 kB` `9.306 kB`
`react-button` Button	`39.513 kB` `11.169 kB`
`react-button` CompoundButton	`46.874 kB` `12.661 kB`
`react-button` MenuButton	`44.292 kB` `12.542 kB`
`react-button` SplitButton	`52.306 kB` `14.134 kB`
`react-button` ToggleButton	`56.559 kB` `13.068 kB`
`react-calendar-compat` Calendar Compat	`142.162 kB` `37.149 kB`
`react-card` Card - All	`94.685 kB` `27.248 kB`
`react-card` Card	`89.509 kB` `25.733 kB`
`react-card` CardFooter	`13.064 kB` `5.385 kB`
`react-card` CardHeader	`15.307 kB` `6.143 kB`
`react-card` CardPreview	`14.015 kB` `5.752 kB`
`react-checkbox` Checkbox	`34.746 kB` `11.902 kB`
`react-combobox` Combobox (including child components)	`95.057 kB` `30.655 kB`
`react-combobox` Dropdown (including child components)	`93.643 kB` `30.333 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`69.901 kB` `20.261 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`209.783 kB` `59.86 kB`
`react-components` react-components: FluentProvider & webLightTheme	`42.388 kB` `14.103 kB`
`react-datepicker-compat` DatePicker Compat	`213.537 kB` `59.885 kB`
`react-dialog` Dialog (including children components)	`95.452 kB` `28.456 kB`
`react-divider` Divider	`20.82 kB` `7.763 kB`
`react-field` Field	`22.427 kB` `8.573 kB`
`react-image` Image	`15.736 kB` `6.228 kB`
`react-infobutton` InfoButton	`132.618 kB` `41.704 kB`
`react-infobutton` InfoLabel	`136.305 kB` `42.845 kB`
`react-input` Input	`26.887 kB` `9.118 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.783 kB` `1.648 kB`
`react-jsx-runtime` JSX Runtime	`4.377 kB` `1.881 kB`
`react-label` Label	`14.149 kB` `5.759 kB`
`react-link` Link	`17.082 kB` `6.911 kB`
`react-menu` Menu (including children components)	`141.968 kB` `43.516 kB`
`react-menu` Menu (including selectable components)	`144.654 kB` `44.025 kB`
`react-message-bar` MessageBar (all components)	`25.181 kB` `9.039 kB`
`react-overflow` hooks only	`12.837 kB` `4.818 kB`
`react-persona` Persona	`57.066 kB` `17.821 kB`
`react-popover` Popover	`120.812 kB` `38.11 kB`
`react-portal` Portal	`12.788 kB` `4.67 kB`
`react-portal-compat` PortalCompatProvider	`7.099 kB` `2.385 kB`
`react-positioning` usePositioning	`25.767 kB` `9.308 kB`
`react-progress` ProgressBar	`17.428 kB` `6.898 kB`
`react-provider` FluentProvider	`22.928 kB` `8.472 kB`
`react-radio` Radio	`31.746 kB` `10.365 kB`
`react-radio` RadioGroup	`15.345 kB` `6.263 kB`
`react-select` Select	`28.609 kB` `10.205 kB`
`react-slider` Slider	`39.15 kB` `12.769 kB`
`react-spinbutton` SpinButton	`36.774 kB` `11.788 kB`
`react-spinner` Spinner	`23.402 kB` `8.467 kB`
`react-switch` Switch	`34.23 kB` `10.995 kB`
`react-table` DataGrid	`154.896 kB` `43.531 kB`
`react-table` Table (Primitives only)	`43.899 kB` `13.781 kB`
`react-table` Table as DataGrid	`128.117 kB` `34.788 kB`
`react-table` Table (Selection only)	`73.296 kB` `20.012 kB`
`react-table` Table (Sort only)	`71.903 kB` `19.613 kB`
`react-tags` InteractionTag	`15.259 kB` `6.058 kB`
`react-tags` Tag	`29.982 kB` `9.439 kB`
`react-tags` TagGroup	`74.331 kB` `22.28 kB`
`react-text` Text - Default	`16.705 kB` `6.569 kB`
`react-text` Text - Wrappers	`19.878 kB` `6.896 kB`
`react-textarea` Textarea	`30.947 kB` `10.476 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.616 kB` `7.317 kB`
`react-theme` Teams: Light theme	`19.287 kB` `5.498 kB`
`react-timepicker-compat` TimePicker	`96.894 kB` `32.105 kB`
`react-timepicker-compat-preview` TimePicker	`96.894 kB` `32.105 kB`
`react-toast` Toast (including Toaster)	`93.203 kB` `28.026 kB`
`react-tooltip` Tooltip	`53.252 kB` `18.806 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against 65122012b486987f3cf7204e1c17c5ad81962e26}

size-auditor · 2023-12-21T16:09:18Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 65122012b486987f3cf7204e1c17c5ad81962e26 (build)

fabricteam · 2023-12-21T16:11:56Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-12-21T16:12:55Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	638	635	5000
Breadcrumb	mount	1642	1667	1000
Checkbox	mount	1696	1711	5000
CheckboxBase	mount	1492	1486	5000
ChoiceGroup	mount	2980	2951	5000
ComboBox	mount	652	648	1000
CommandBar	mount	6315	6163	1000
ContextualMenu	mount	12839	12679	1000
DefaultButton	mount	746	760	5000
DetailsRow	mount	2205	2225	5000
DetailsRowFast	mount	2206	2242	5000
DetailsRowNoStyles	mount	2028	2004	5000
Dialog	mount	2761	2686	1000
DocumentCardTitle	mount	227	230	1000
Dropdown	mount	2028	2017	5000
FocusTrapZone	mount	1153	1119	5000
FocusZone	mount	1071	1080	5000
GroupedList	mount	42001	41697	2
GroupedList	virtual-rerender	19922	20048	2
GroupedList	virtual-rerender-with-unmount	51087	50756	2
GroupedListV2	mount	229	224	2
GroupedListV2	virtual-rerender	213	204	2
GroupedListV2	virtual-rerender-with-unmount	226	230	2
IconButton	mount	1094	1107	5000
Label	mount	343	328	5000
Layer	mount	2763	2729	5000
Link	mount	410	399	5000
MenuButton	mount	970	930	5000
MessageBar	mount	21434	21392	5000
Nav	mount	1948	2002	1000
OverflowSet	mount	792	770	5000
Panel	mount	2074	1844	1000
Persona	mount	763	754	1000
Pivot	mount	867	866	1000
PrimaryButton	mount	864	854	5000
Rating	mount	4649	4733	5000
SearchBox	mount	950	924	5000
Shimmer	mount	1892	1904	5000
Slider	mount	1343	1316	5000
SpinButton	mount	2944	2888	5000
Spinner	mount	389	382	5000
SplitButton	mount	1889	1841	5000
Stack	mount	414	410	5000
StackWithIntrinsicChildren	mount	849	855	5000
StackWithTextChildren	mount	2646	2621	5000
SwatchColorPicker	mount	6152	6198	5000
TagPicker	mount	1502	1465	5000
Text	mount	381	386	5000
TextField	mount	960	949	5000
ThemeProvider	mount	836	840	5000
ThemeProvider	virtual-rerender	603	597	5000
ThemeProvider	virtual-rerender-with-unmount	1296	1287	5000
Toggle	mount	640	641	5000
buttonNative	mount	190	194	5000

scripts/lint-staged/eslint.js

…nx api

github-actions bot added this to the December Project Cycle Q1 2024 milestone Dec 21, 2023

Hotell added the Area: Build System label Dec 21, 2023

Hotell commented Dec 28, 2023

View reviewed changes

scripts/lint-staged/eslint.js Outdated Show resolved Hide resolved

Hotell changed the title ~~Lerna/aggregate lerna alias usage~~ feat: replace lerna-alias with nx APIs Dec 28, 2023

Hotell added the CI label Dec 28, 2023

Hotell force-pushed the lerna/aggregate-lerna-alias-usage branch from 8a124ad to 9c3d1f7 Compare December 28, 2023 15:49

Hotell commented Dec 29, 2023

View reviewed changes

scripts/lint-staged/eslint.js Show resolved Hide resolved

Hotell marked this pull request as ready for review December 29, 2023 09:11

Hotell requested review from a team as code owners December 29, 2023 09:11

Hotell mentioned this pull request Dec 29, 2023

feat(scripts-monorepo): replace lerna/utils with pure nx apis #30178

Merged

Hotell added the NX: core label Jan 2, 2024

Hotell mentioned this pull request Jan 3, 2024

chore: remove executors that use lerna under the hood, improve/cleanup northstar release cli tool, cleanup global npm scripts #30202

Merged

1 task

ling1726 approved these changes Jan 4, 2024

View reviewed changes

Hotell added 5 commits January 5, 2024 14:25

feat(scripts): migrate lerna-alias api usage to 1 single source of truth

a24f44c

feat(scripts-monorepo): implement lerna-alias replacement leveraging …

dfd9c93

…nx api

chore: replace lerna-aliases usage with new workspace-tools apis

d55f51b

style: apply formatting after eslint -fix

5bd66da

chore: remove lerna-alias package

4c32728

Hotell force-pushed the lerna/aggregate-lerna-alias-usage branch from 9c3d1f7 to 4c32728 Compare January 5, 2024 13:27

github-actions bot modified the milestones: December Project Cycle Q1 2023, January Project Cycle Q1 2024 Jan 5, 2024

Hotell merged commit a493617 into microsoft:master Jan 5, 2024

Hotell deleted the lerna/aggregate-lerna-alias-usage branch January 5, 2024 14:27

Leolewin pushed a commit to Leolewin/fluentui that referenced this pull request Jan 9, 2024

feat: replace lerna-alias with nx APIs (microsoft#30149)

d66043e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: replace lerna-alias with nx APIs #30149

feat: replace lerna-alias with nx APIs #30149

Uh oh!

Hotell commented Dec 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2023 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Dec 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2023 •

edited

Loading

Uh oh!

size-auditor bot commented Dec 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: replace lerna-alias with nx APIs #30149

feat: replace lerna-alias with nx APIs #30149

Uh oh!

Conversation

Hotell commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

codesandbox-ci bot commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

size-auditor bot commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hotell commented Dec 21, 2023 •

edited

Loading

fabricteam commented Dec 21, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

codesandbox-ci bot commented Dec 21, 2023 •

edited

Loading

fabricteam commented Dec 21, 2023 •

edited

Loading

fabricteam commented Dec 21, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Dec 21, 2023 •

edited

Loading

fabricteam commented Dec 21, 2023 •

edited

Loading

size-auditor bot commented Dec 21, 2023 •

edited

Loading

fabricteam commented Dec 21, 2023 •

edited

Loading

fabricteam commented Dec 21, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)