Revert fix: useOnScrollOutside should invoke callback on dragging scrollbar #29412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `useOnScrollOutside` with event type cast (microsoft#29062)" This reverts commit e1a8824.
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 648 | 598 | 5000 | |
| Button | mount | 317 | 321 | 5000 | |
| Field | mount | 1099 | 1146 | 5000 | |
| FluentProvider | mount | 715 | 698 | 5000 | |
| FluentProviderWithTheme | mount | 75 | 77 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 65 | 67 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 75 | 10 | |
| InfoButton | mount | 16 | 11 | 5000 | |
| MakeStyles | mount | 875 | 886 | 50000 | |
| Persona | mount | 1745 | 1713 | 5000 | |
| SpinButton | mount | 1328 | 1359 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ecf2bcc:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 118c00164b2397b764e9e3d8d01b459df1fcfd29 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
2 tasks
ling1726
approved these changes
Oct 5, 2023
jurokapsiar
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #29062
Why revert:
When moving focus, browser can trigger scroll event and causing unwanted popover close.
In this example https://codesandbox.io/s/nervous-bush-j9qkzw?file=/example.tsx, when Tabbing to the popover trigger, popover opens. And then tab again closes the popover, while the expected behavior is popover stays open.
Real life case where it can happen:
When there is a long message that takes up the entire height of the message pane, opening the popover on the message can cause scroll.