Skip to content

fix(react-accordion): fix memory leak caused by context assignment #29193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
layershifter merged 2 commits into from
Sep 20, 2023
Merged

fix(react-accordion): fix memory leak caused by context assignment #29193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52b5434
fix(react-accordion): fix memory leak caused by context assignment
layershifter Sep 20, 2023
3958902
Merge branch 'master' into fix/memory-leak-by-context
layershifter Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-accordion-cf1198e4-5432-4f0c-8bca-ed8a883c2454.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: fix memory leak caused by context assignment",
"packageName": "@fluentui/react-accordion",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 3 additions & 2 deletions packages/react-components/react-accordion/src/contexts/accordionItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,6 @@ const accordionItemContextDefaultValue: AccordionItemContextValue<unknown> = {

export const { Provider: AccordionItemProvider } = AccordionItemContext;

export const useAccordionItemContext_unstable = () =>
React.useContext(AccordionItemContext) ?? accordionItemContextDefaultValue;
export const useAccordionItemContext_unstable = () => {
return React.useContext(AccordionItemContext) ?? accordionItemContextDefaultValue;
};