-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(react-accordion): fix memory leak caused by context assignment #29193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-accordion): fix memory leak caused by context assignment #29193
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3958902:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 15 | 16 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 627 | 653 | 5000 | |
| Button | mount | 306 | 335 | 5000 | |
| Field | mount | 1117 | 1092 | 5000 | |
| FluentProvider | mount | 680 | 697 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 71 | 72 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 71 | 10 | |
| InfoButton | mount | 15 | 16 | 5000 | Possible regression |
| MakeStyles | mount | 855 | 839 | 50000 | |
| Persona | mount | 1753 | 1710 | 5000 | |
| SpinButton | mount | 1358 | 1372 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
Asset size changesUnable to find bundle size details for Baseline commit: b824db7 Possible causes
Recommendations
|
🕵 fluentuiv9 No visual regressions between this PR and main |
|
Force merged to unblock upgrade of Fluent in Teams: approvals from team members are present, CI is green. |

Previous Behavior
Accordioncauses memory leaks.New Behavior
Accordiondoes not cause memory leaks via a workaround.Related Issue(s)