chore(react-tabster): Upgrade tabster to v4.4.1. #27850

mshoho · 2023-05-15T19:47:11Z

No description provided.

fabricteam · 2023-05-15T19:52:46Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-accordion` Accordion (including children components)	`86.064 kB` `26.1 kB`	`88.117 kB` `26.675 kB`	`2.053 kB` `575 B`
`react-card` Card - All	`86.061 kB` `24.345 kB`	`88.344 kB` `24.985 kB`	`2.283 kB` `640 B`
`react-card` Card	`80.997 kB` `22.895 kB`	`83.279 kB` `23.537 kB`	`2.282 kB` `642 B`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`203.937 kB` `57.086 kB`	`205.711 kB` `57.692 kB`	`1.774 kB` `606 B`
`react-datepicker-compat` DatePicker Compat	`220.303 kB` `58.486 kB`	`222.077 kB` `59.071 kB`	`1.774 kB` `585 B`
`react-dialog` Dialog (including children components)	`90.972 kB` `27.056 kB`	`92.576 kB` `27.593 kB`	`1.604 kB` `537 B`
`react-infobutton` InfoButton	`127.977 kB` `39.012 kB`	`129.58 kB` `39.558 kB`	`1.603 kB` `546 B`
`react-infobutton` InfoLabel	`131.26 kB` `40 kB`	`132.862 kB` `40.574 kB`	`1.602 kB` `574 B`
`react-menu` Menu (including children components)	`128.254 kB` `39.184 kB`	`130.308 kB` `39.777 kB`	`2.054 kB` `593 B`
`react-menu` Menu (including selectable components)	`131.238 kB` `39.7 kB`	`133.292 kB` `40.296 kB`	`2.054 kB` `596 B`
`react-popover` Popover	`114.969 kB` `35.392 kB`	`116.571 kB` `35.938 kB`	`1.602 kB` `546 B`
`react-table` DataGrid	`147.583 kB` `40.523 kB`	`149.637 kB` `41.14 kB`	`2.054 kB` `617 B`
`react-table` Table as DataGrid	`130.142 kB` `33.083 kB`	`132.195 kB` `33.652 kB`	`2.053 kB` `569 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`560 B` `352 B`
`priority-overflow` createOverflowManager	`3.194 kB` `1.315 kB`
`react-alert` Alert	`93.534 kB` `22.497 kB`
`react-avatar` Avatar	`57.754 kB` `15.041 kB`
`react-avatar` AvatarGroup	`15.632 kB` `6.258 kB`
`react-avatar` AvatarGroupItem	`73.968 kB` `19.552 kB`
`react-badge` Badge	`23.512 kB` `7.197 kB`
`react-badge` CounterBadge	`24.416 kB` `7.506 kB`
`react-badge` PresenceBadge	`32.094 kB` `8.367 kB`
`react-button` Button	`36.724 kB` `9.458 kB`
`react-button` CompoundButton	`43.873 kB` `10.939 kB`
`react-button` MenuButton	`41.411 kB` `10.791 kB`
`react-button` SplitButton	`49.635 kB` `12.364 kB`
`react-button` ToggleButton	`54.866 kB` `11.367 kB`
`react-card` CardFooter	`9.158 kB` `3.844 kB`
`react-card` CardHeader	`11.048 kB` `4.538 kB`
`react-card` CardPreview	`9.963 kB` `4.192 kB`
`react-checkbox` Checkbox	`34.268 kB` `10.793 kB`
`react-combobox` Combobox (including child components)	`87.251 kB` `28.1 kB`
`react-combobox` Dropdown (including child components)	`85.635 kB` `27.697 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`64.855 kB` `17.852 kB`
`react-components` react-components: FluentProvider & webLightTheme	`36.086 kB` `11.9 kB`
`react-divider` Divider	`17.399 kB` `6.298 kB`
`react-field` Field	`18.864 kB` `7.004 kB`
`react-image` Image	`11.479 kB` `4.573 kB`
`react-input` Input	`24.024 kB` `7.682 kB`
`react-label` Label	`10.104 kB` `4.185 kB`
`react-link` Link	`12.304 kB` `5.061 kB`
`react-overflow` hooks only	`11.214 kB` `4.271 kB`
`react-persona` Persona	`64.675 kB` `16.968 kB`
`react-portal` Portal	`11.649 kB` `4.262 kB`
`react-portal-compat` PortalCompatProvider	`6.446 kB` `2.186 kB`
`react-positioning` usePositioning	`24.008 kB` `8.798 kB`
`react-progress` ProgressBar	`13.856 kB` `5.434 kB`
`react-provider` FluentProvider	`18.033 kB` `6.666 kB`
`react-radio` Radio	`27.282 kB` `8.661 kB`
`react-radio` RadioGroup	`11.312 kB` `4.71 kB`
`react-select` Select	`25.357 kB` `8.798 kB`
`react-slider` Slider	`34.164 kB` `11.024 kB`
`react-spinbutton` SpinButton	`33.934 kB` `10.328 kB`
`react-spinner` Spinner	`20.882 kB` `6.798 kB`
`react-switch` Switch	`29.806 kB` `9.274 kB`
`react-table` Table (Primitives only)	`44.348 kB` `12.347 kB`
`react-table` Table (Selection only)	`78.056 kB` `19.084 kB`
`react-table` Table (Sort only)	`77.386 kB` `18.896 kB`
`react-tags` Tag	`21.687 kB` `7.868 kB`
`react-text` Text - Default	`12.492 kB` `4.92 kB`
`react-text` Text - Wrappers	`15.624 kB` `5.232 kB`
`react-textarea` Textarea	`27.451 kB` `9.046 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.33 kB` `6.764 kB`
`react-theme` Teams: Light theme	`17.895 kB` `5.162 kB`
`react-tooltip` Tooltip	`46.708 kB` `16.376 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against bdc00a85606c5a225be1df2a24db1ccecbc65b64}

size-auditor · 2023-05-15T20:01:06Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bdc00a85606c5a225be1df2a24db1ccecbc65b64 (build)

codesandbox-ci · 2023-05-15T20:04:02Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8480575:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-05-15T20:08:13Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
InfoButton	mount	24	20	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	811	831	5000
Button	mount	447	433	5000
Field	mount	1538	1510	5000
FluentProvider	mount	1109	1075	5000
FluentProviderWithTheme	mount	141	138	10
FluentProviderWithTheme	virtual-rerender	115	112	10
FluentProviderWithTheme	virtual-rerender-with-unmount	124	122	10
InfoButton	mount	24	20	5000	Possible regression
MakeStyles	mount	1345	1296	50000
Persona	mount	2514	2360	5000
SpinButton	mount	1883	1847	5000

fabricteam · 2023-05-15T20:08:52Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-05-15T20:10:10Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
RefMinimalPerf.default	180	159	1.13:1
AvatarMinimalPerf.default	183	165	1.11:1
FlexMinimalPerf.default	253	231	1.1:1
HeaderMinimalPerf.default	331	307	1.08:1
ImageMinimalPerf.default	344	319	1.08:1
ListCommonPerf.default	664	612	1.08:1
TreeMinimalPerf.default	770	713	1.08:1
ButtonSlotsPerf.default	514	487	1.06:1
SkeletonMinimalPerf.default	324	305	1.06:1
ButtonMinimalPerf.default	133	127	1.05:1
LoaderMinimalPerf.default	307	293	1.05:1
IconMinimalPerf.default	615	586	1.05:1
TreeWith60ListItems.default	137	131	1.05:1
AlertMinimalPerf.default	247	237	1.04:1
AttachmentMinimalPerf.default	122	117	1.04:1
SliderMinimalPerf.default	1125	1086	1.04:1
StatusMinimalPerf.default	641	615	1.04:1
LabelMinimalPerf.default	350	339	1.03:1
ListMinimalPerf.default	462	450	1.03:1
BoxMinimalPerf.default	310	305	1.02:1
CheckboxMinimalPerf.default	1934	1900	1.02:1
AccordionMinimalPerf.default	129	128	1.01:1
AttachmentSlotsPerf.default	1028	1013	1.01:1
DividerMinimalPerf.default	318	315	1.01:1
HeaderSlotsPerf.default	707	698	1.01:1
ListNestedPerf.default	522	515	1.01:1
MenuMinimalPerf.default	765	755	1.01:1
PortalMinimalPerf.default	144	142	1.01:1
ReactionMinimalPerf.default	327	323	1.01:1
TableManyItemsPerf.default	1765	1743	1.01:1
CustomToolbarPrototype.default	2323	2301	1.01:1
ToolbarMinimalPerf.default	829	824	1.01:1
VideoMinimalPerf.default	652	643	1.01:1
AnimationMinimalPerf.default	443	444	1:1
ButtonOverridesMissPerf.default	1020	1016	1:1
CardMinimalPerf.default	458	459	1:1
ChatWithPopoverPerf.default	300	299	1:1
DropdownMinimalPerf.default	2222	2227	1:1
GridMinimalPerf.default	298	298	1:1
InputMinimalPerf.default	859	861	1:1
PopupMinimalPerf.default	544	544	1:1
RadioGroupMinimalPerf.default	421	420	1:1
SegmentMinimalPerf.default	301	301	1:1
SplitButtonMinimalPerf.default	3701	3685	1:1
DropdownManyItemsPerf.default	610	616	0.99:1
FormMinimalPerf.default	325	327	0.99:1
MenuButtonMinimalPerf.default	1545	1562	0.99:1
ProviderMergeThemesPerf.default	1192	1204	0.99:1
ChatMinimalPerf.default	635	648	0.98:1
DatepickerMinimalPerf.default	5543	5664	0.98:1
DialogMinimalPerf.default	701	716	0.98:1
ListWith60ListItems.default	570	583	0.98:1
TableMinimalPerf.default	363	369	0.98:1
CarouselMinimalPerf.default	414	427	0.97:1
ItemLayoutMinimalPerf.default	1104	1135	0.97:1
RosterPerf.default	2264	2329	0.97:1
TooltipMinimalPerf.default	2030	2084	0.97:1
EmbedMinimalPerf.default	2915	3032	0.96:1
TextMinimalPerf.default	299	312	0.96:1
TextAreaMinimalPerf.default	421	440	0.96:1
LayoutMinimalPerf.default	311	329	0.95:1
ProviderMinimalPerf.default	327	348	0.94:1
ChatDuplicateMessagesPerf.default	233	256	0.91:1

fabricteam · 2023-05-15T20:18:27Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-05-15T20:19:15Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2023-05-15T20:27:17Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1003	1023	5000
Breadcrumb	mount	2719	2785	1000
Checkbox	mount	2695	2630	5000
CheckboxBase	mount	2307	2304	5000
ChoiceGroup	mount	4606	4580	5000
ComboBox	mount	1109	1098	1000
CommandBar	mount	9892	10049	1000
ContextualMenu	mount	22676	22131	1000
DefaultButton	mount	1156	1258	5000
DetailsRow	mount	3460	3472	5000
DetailsRowFast	mount	3477	3519	5000
DetailsRowNoStyles	mount	3169	3131	5000
Dialog	mount	4052	4131	1000
DocumentCardTitle	mount	386	371	1000
Dropdown	mount	2991	3023	5000
FocusTrapZone	mount	1746	1861	5000
FocusZone	mount	1755	1711	5000
GroupedList	mount	60460	68201	2
GroupedList	virtual-rerender	29397	29351	2
GroupedList	virtual-rerender-with-unmount	90722	87918	2
GroupedListV2	mount	387	438	2
GroupedListV2	virtual-rerender	368	373	2
GroupedListV2	virtual-rerender-with-unmount	388	416	2
IconButton	mount	1815	1810	5000
Label	mount	539	547	5000
Layer	mount	4414	4531	5000
Link	mount	688	661	5000
MenuButton	mount	1536	1587	5000
MessageBar	mount	33992	33683	5000
Nav	mount	2998	2998	1000
OverflowSet	mount	1203	1232	5000
Panel	mount	2640	2687	1000
Persona	mount	1148	1157	1000
Pivot	mount	1406	1381	1000
PrimaryButton	mount	1293	1314	5000
Rating	mount	6829	6835	5000
SearchBox	mount	1356	1338	5000
Shimmer	mount	2818	2770	5000
Slider	mount	2016	2010	5000
SpinButton	mount	4431	4481	5000
Spinner	mount	622	617	5000
SplitButton	mount	2890	2850	5000
Stack	mount	638	646	5000
StackWithIntrinsicChildren	mount	1336	1321	5000
StackWithTextChildren	mount	3854	3828	5000
SwatchColorPicker	mount	9523	9528	5000
TagPicker	mount	2317	2352	5000
Text	mount	617	608	5000
TextField	mount	1412	1423	5000
ThemeProvider	mount	1336	1338	5000
ThemeProvider	virtual-rerender	926	929	5000
ThemeProvider	virtual-rerender-with-unmount	2041	2077	5000
Toggle	mount	953	956	5000
buttonNative	mount	349	342	5000

Hotell · 2023-05-17T10:58:29Z

can we add changelog as PR description next time ? https://github.com/microsoft/tabster/blob/master/CHANGELOG.md

Hotell · 2023-05-17T10:57:16Z

change/@fluentui-react-tabster-57b7754a-68fe-4e13-b419-cc877b452a24.json

@@ -0,0 +1,10 @@
+{
+  "type": "none",


hmm this looks wrong, it should by type:feat with minor bump as the bump is adding new features

bsunderhus · 2023-05-17T13:54:28Z

I'll close this PR in favour of #27540

chore(react-tabster): Upgrade tabster to v4.4.1.

2d6d432

msft-fluent-ui-bot assigned TristanWatanabe May 15, 2023

Change file.

8480575

mshoho marked this pull request as ready for review May 16, 2023 07:57

mshoho requested review from a team as code owners May 16, 2023 07:57

tudorpopams self-requested a review May 16, 2023 12:22

tudorpopams approved these changes May 16, 2023

View reviewed changes

Hotell requested changes May 17, 2023

View reviewed changes

msft-fluent-ui-bot added the Needs: Author Feedback label May 17, 2023

bsunderhus closed this May 17, 2023

chore(react-tabster): Upgrade tabster to v4.4.1. #27850

chore(react-tabster): Upgrade tabster to v4.4.1. #27850

Uh oh!

Conversation

mshoho commented May 15, 2023

Uh oh!

fabricteam commented May 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

size-auditor bot commented May 15, 2023

Asset size changes

Uh oh!

codesandbox-ci bot commented May 15, 2023

Uh oh!

fabricteam commented May 15, 2023

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented May 15, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented May 15, 2023

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented May 15, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented May 15, 2023

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

fabricteam commented May 15, 2023

Perf Analysis (@fluentui/react)

Uh oh!

Hotell commented May 17, 2023

Uh oh!

Hotell May 17, 2023

Choose a reason for hiding this comment

Uh oh!

bsunderhus commented May 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fabricteam commented May 15, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)