Skip to content

chore(react-utilities): add test to ensure slot render functions #27575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsunderhus merged 1 commit into from
Apr 14, 2023
Merged

chore(react-utilities): add test to ensure slot render functions #27575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/react-components/react-utilities/src/compose/getSlots.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as React from 'react';
import { getSlots } from './getSlots';
import type { Slot } from './types';
import { resolveShorthand } from './resolveShorthand';

describe('getSlots', () => {
type FooProps = { id?: string; children?: React.ReactNode };
Expand Down Expand Up @@ -126,6 +127,24 @@ describe('getSlots', () => {
});
});

it('can use slot children functions from resolveShorthand to replace default slot rendering', () => {
type Slots = {
root: Slot<'div'>;
icon: Slot<'a'>;
};
const renderFunction = (C: React.ElementType, p: {}) => <C {...p} />;
expect(
getSlots<Slots>({
components: { root: 'div', icon: Foo },
root: resolveShorthand({ as: 'div' }, { required: true }),
icon: resolveShorthand({ id: 'bar', children: renderFunction }),
}),
).toEqual({
slots: { root: 'div', icon: React.Fragment },
slotProps: { root: {}, icon: { children: <Foo id="bar" /> } },
});
});

it('can render a primitive input with no children', () => {
type Slots = {
root: Slot<'div'>;
Expand Down
20 changes: 20 additions & 0 deletions packages/react-components/react-utilities/src/compose/getSlotsNext.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import * as React from 'react';
import { getSlotsNext } from './getSlotsNext';
import type { Slot } from './types';
import { resolveShorthand } from './resolveShorthand';
import { SLOT_RENDER_FUNCTION_SYMBOL } from './constants';

describe('getSlotsNext', () => {
type FooProps = { id?: string; children?: React.ReactNode };
Expand Down Expand Up @@ -127,6 +129,24 @@ describe('getSlotsNext', () => {
});
});

it('can use slot children functions from resolveShorthand to replace default slot rendering', () => {
type Slots = {
root: Slot<'div'>;
icon: Slot<'a'>;
};
const renderFunction = (C: React.ElementType, p: {}) => <C {...p} />;
expect(
getSlotsNext<Slots>({
components: { root: 'div', icon: Foo },
root: resolveShorthand({ as: 'div' }, { required: true }),
icon: resolveShorthand({ id: 'bar', children: renderFunction }),
}),
).toEqual({
slots: { root: 'div', icon: Foo },
slotProps: { root: {}, icon: { children: undefined, id: 'bar', [SLOT_RENDER_FUNCTION_SYMBOL]: renderFunction } },
});
});

it('can render a primitive input with no children', () => {
type Slots = {
root: Slot<'div'>;
Expand Down