Skip to content

chore(react-utilities): add test to ensure slot render functions #27575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bsunderhus merged 1 commit into from
Apr 14, 2023
Merged

chore(react-utilities): add test to ensure slot render functions #27575

bsunderhus merged 1 commit into from
Apr 14, 2023

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Apr 14, 2023 •
edited
Loading

New Behavior

  1. Add test to ensure slot render function to avoid regressions on getSlots
  2. Add test to ensure slot render function new functionality on getSlotsNext

Related Issue(s)

@bsunderhus bsunderhus self-assigned this Apr 14, 2023
@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 14, 2023
@bsunderhus
Copy link
Contributor Author

bsunderhus commented Apr 14, 2023

Blocked by #27561

@bsunderhus bsunderhus mentioned this pull request Apr 14, 2023
Merged
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 14, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b36e4eb:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 19 21 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 642 634 5000
Button mount 378 338 5000
Field mount 1115 1288 5000
FluentProvider mount 846 846 5000
FluentProviderWithTheme mount 99 116 10
FluentProviderWithTheme virtual-rerender 98 87 10
FluentProviderWithTheme virtual-rerender-with-unmount 100 96 10
InfoButton mount 19 21 5000 Possible regression
MakeStyles mount 988 1125 50000
Persona mount 1899 1990 5000
SpinButton mount 1548 1541 5000

@size-auditor
Copy link

size-auditor bot commented Apr 14, 2023 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 25f87de

Possible causes

  • The baseline build 25f87de is broken
  • The Size Auditor run for the baseline build 25f87de was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
react-accordion
Accordion (including children components)		 88.978 kB
26.586 kB
react-alert
Alert		 95.877 kB
23.104 kB
react-avatar
Avatar		 59.542 kB
15.569 kB
react-avatar
AvatarGroup		 18.19 kB
6.706 kB
react-avatar
AvatarGroupItem		 75.803 kB
20.072 kB
react-badge
Badge		 26.075 kB
7.629 kB
react-badge
CounterBadge		 27.058 kB
7.938 kB
react-badge
PresenceBadge		 34.547 kB
8.726 kB
react-button
Button		 39.845 kB
10 kB
react-button
CompoundButton		 47.017 kB
11.469 kB
react-button
MenuButton		 44.532 kB
11.352 kB
react-button
SplitButton		 53.027 kB
12.914 kB
react-button
ToggleButton		 58.217 kB
11.922 kB
react-card
Card - All		 86.164 kB
24.342 kB
react-card
Card		 80.983 kB
22.881 kB
react-card
CardFooter		 9.122 kB
3.832 kB
react-card
CardHeader		 11.048 kB
4.537 kB
react-card
CardPreview		 9.927 kB
4.18 kB
react-checkbox
Checkbox		 37.109 kB
11.286 kB
react-combobox
Combobox (including child components)		 89.878 kB
28.552 kB
react-combobox
Dropdown (including child components)		 88.562 kB
28.275 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 68.093 kB
18.424 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 207.629 kB
57.6 kB
react-components
react-components: FluentProvider & webLightTheme		 38.833 kB
12.37 kB
react-datepicker-compat
DatePicker Compat		 251.37 kB
67.359 kB
react-dialog
Dialog (including children components)		 93.338 kB
27.391 kB
react-divider
Divider		 19.958 kB
6.736 kB
react-field
Field		 21.589 kB
7.453 kB
react-image
Image		 14.023 kB
5.008 kB
react-infobutton
InfoButton		 130.692 kB
39.476 kB
react-infobutton
InfoLabel		 133.988 kB
40.514 kB
react-input
Input		 26.796 kB
8.148 kB
react-label
Label		 12.657 kB
4.618 kB
react-link
Link		 12.313 kB
5.081 kB
react-menu
Menu (including children components)		 131.151 kB
39.687 kB
react-menu
Menu (including selectable components)		 134.287 kB
40.226 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 66.568 kB
17.513 kB
react-popover
Popover		 117.611 kB
35.839 kB
react-portal
Portal		 11.649 kB
4.263 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.185 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 16.409 kB
5.855 kB
react-provider
FluentProvider		 20.78 kB
7.135 kB
react-radio
Radio		 29.921 kB
9.118 kB
react-radio
RadioGroup		 13.952 kB
5.163 kB
react-select
Select		 28.004 kB
9.223 kB
react-slider
Slider		 36.934 kB
11.514 kB
react-spinbutton
SpinButton		 36.705 kB
10.792 kB
react-spinner
Spinner		 23.515 kB
7.226 kB
react-switch
Switch		 32.528 kB
9.73 kB
react-table
DataGrid		 150.956 kB
41.072 kB
react-table
Table (Primitives only)		 47.215 kB
12.749 kB
react-table
Table as DataGrid		 133.551 kB
33.685 kB
react-table
Table (Selection only)		 81.384 kB
19.67 kB
react-table
Table (Sort only)		 80.714 kB
19.479 kB
react-text
Text - Default		 15.03 kB
5.339 kB
react-text
Text - Wrappers		 15.584 kB
5.245 kB
react-textarea
Textarea		 30.203 kB
9.519 kB
react-tooltip
Tooltip		 49.478 kB
16.853 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against c156e7682a89d7766bed3c0b9f231dc2e0a2058b

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus removed the Status: Blocked Resolution blocked by another issue label Apr 14, 2023
@bsunderhus bsunderhus force-pushed the react-utilities/chore--adds-test-to-ensure-getSlots-children-render-function branch from 79a7477 to 4398340 Compare April 14, 2023 11:54
@bsunderhus bsunderhus force-pushed the react-utilities/chore--adds-test-to-ensure-getSlots-children-render-function branch from 4398340 to b36e4eb Compare April 14, 2023 12:13
@bsunderhus bsunderhus marked this pull request as ready for review April 14, 2023 12:13
@bsunderhus bsunderhus requested a review from a team as a code owner April 14, 2023 12:13
@bsunderhus bsunderhus merged commit c0d55f7 into microsoft:master Apr 14, 2023
@bsunderhus bsunderhus deleted the react-utilities/chore--adds-test-to-ensure-getSlots-children-render-function branch April 14, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

Assignees

@bsunderhus bsunderhus

Labels

Area: Testing Fluent UI react-components (v9) Package: utilities

Projects

None yet

Milestone

April Project Cycle Q2 2023

Development

Successfully merging this pull request may close these issues.

chore: Add conformance tests for slot render functions

4 participants

@bsunderhus @fabricteam @layershifter @msft-fluent-ui-bot