Skip to content

fix(react-virtualizer): remove disallowed v9 react-fabric/v8 from dependencies to mitigate dep-tree creep #27334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hotell merged 4 commits into from
Mar 27, 2023
Merged

fix(react-virtualizer): remove disallowed v9 react-fabric/v8 from dependencies to mitigate dep-tree creep #27334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38e59f9
fix(reat-virtualizer): remove disallowed v9 react-fabric/v8 from depe…
Hotell Mar 27, 2023
dbd0467
generate changefile
Hotell Mar 27, 2023
f72945c
generate changefile
Hotell Mar 27, 2023
639f342
fixup! fix(reat-virtualizer): remove disallowed v9 react-fabric/v8 fr…
Hotell Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-virtualizer-32407628-78bb-4307-bbf4-d0a366f48deb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: remove disallowed v9 react-fabric/v8 from dependency to mitigate dep-tree creep",
"packageName": "@fluentui/react-virtualizer",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 0 additions & 1 deletion packages/react-components/react-virtualizer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
},
"dependencies": {
"@fluentui/react-utilities": "^9.7.2",
"@fluentui/react": "^8.106.9",
"@griffel/react": "^1.5.2",
"@swc/helpers": "^0.4.14"
},
Expand Down
1 change: 1 addition & 0 deletions packages/react-components/react-virtualizer/stories/Virtualizer/DefaultUnbounded.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as React from 'react';
import { Virtualizer, useStaticVirtualizerMeasure } from '@fluentui/react-components/unstable';
import { makeStyles } from '@fluentui/react-components';
// @ts-expect-error - we don support path aliases for libraries with both v8 and v9 as dependencies
import { ThemeProvider } from '@fluentui/react';

import { useFluent } from '@fluentui/react-components';
Expand Down
1 change: 1 addition & 0 deletions packages/react-components/react-virtualizer/stories/Virtualizer/MultiUnbounded.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as React from 'react';
import { Virtualizer, useStaticVirtualizerMeasure } from '@fluentui/react-components/unstable';
import { makeStyles, useFluent } from '@fluentui/react-components';
// @ts-expect-error - we don support path aliases for libraries with both v8 and v9 as dependencies
import { ThemeProvider } from '@fluentui/react';

const useStyles = makeStyles({
Expand Down
1 change: 1 addition & 0 deletions ...ages/react-components/react-virtualizer/stories/VirtualizerScrollView/Default.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as React from 'react';
import { VirtualizerScrollView } from '@fluentui/react-components/unstable';
import { makeStyles } from '@fluentui/react-components';
// @ts-expect-error - we don support path aliases for libraries with both v8 and v9 as dependencies
import { ThemeProvider } from '@fluentui/react';

const useStyles = makeStyles({
Expand Down