Skip to content

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Mar 27, 2023

Previous Behavior

react-virtualizer introduced a forbidden project dependency on react(v8), which caused pipeline creep ( on any v8 change all v9 project would be affected).

Simplified Example:

  • user makes changes within @fluentui/react
  • this triggers build/lint/test task on following packages because their dependency tree
    • @fluentui/ssr-test-v9 -->  @fluentui/react-components --> @fluentui/react-virtualizer --> @fluentui/react

This caused Out of memory/timeout issues for both PR pipelines and release pipelines

Example of failing PR/pipeline that triggers everything because of this: #27323

New Behavior

react v8 is no longer a v9 package direct or indirect dependency.

Notes:

  • We have currently no tooling in place that explicitly fails pipeline when such a violation occurs.
  • To be able to start/build storybook locally for this package, one needs to manually build react project lage build --to @fluentui/react.

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 27, 2023
@Hotell Hotell changed the title Hotell/build/fix virtualized deps fix(reat-virtualizer): remove disallowed v9 react-fabric/v8 from dependency to mitigate dep-tree creep Mar 27, 2023
@Hotell Hotell changed the title fix(reat-virtualizer): remove disallowed v9 react-fabric/v8 from dependency to mitigate dep-tree creep fix(react-virtualizer): remove disallowed v9 react-fabric/v8 from dependency to mitigate dep-tree creep Mar 27, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 639f342:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 27, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
67.994 kB
18.395 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.4 kB
57.516 kB
react-components
react-components: FluentProvider & webLightTheme
38.819 kB
12.351 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against 1625b0d4ff24603fed32632f67b238fcc2c0c426

@size-auditor
Copy link

size-auditor bot commented Mar 27, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4fad4cbbcbdb48847857c388135a3abda472add7 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 27, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 817 891 5000
Button mount 510 509 5000
Field mount 1479 1468 5000
FluentProvider mount 1102 1118 5000
FluentProviderWithTheme mount 303 299 10
FluentProviderWithTheme virtual-rerender 244 249 10
FluentProviderWithTheme virtual-rerender-with-unmount 294 274 10
InfoButton mount 192 190 5000
MakeStyles mount 1303 1294 50000
Persona mount 2276 1976 5000
SpinButton mount 1929 1821 5000

@Hotell Hotell changed the title fix(react-virtualizer): remove disallowed v9 react-fabric/v8 from dependency to mitigate dep-tree creep fix(react-virtualizer): remove disallowed v9 react-fabric/v8 from dependencies to mitigate dep-tree creep Mar 27, 2023
@Hotell Hotell marked this pull request as ready for review March 27, 2023 15:44
@Hotell Hotell requested review from a team and Mitch-At-Work as code owners March 27, 2023 15:44
@Hotell
Copy link
Contributor Author

Hotell commented Mar 27, 2023

1 hour threshold reached for bundle-size pipeline, re-running

@Hotell Hotell merged commit 5c53cfd into microsoft:master Mar 27, 2023
@Hotell Hotell deleted the hotell/build/fix-virtualized-deps branch March 27, 2023 17:37
@Hotell Hotell mentioned this pull request Mar 28, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants