-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(react-virtualizer): remove disallowed v9 react-fabric/v8 from dependencies to mitigate dep-tree creep #27334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-virtualizer): remove disallowed v9 react-fabric/v8 from dependencies to mitigate dep-tree creep #27334
Conversation
…ndency to mitigate dep-tree creep
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 639f342:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4fad4cbbcbdb48847857c388135a3abda472add7 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 817 | 891 | 5000 | |
| Button | mount | 510 | 509 | 5000 | |
| Field | mount | 1479 | 1468 | 5000 | |
| FluentProvider | mount | 1102 | 1118 | 5000 | |
| FluentProviderWithTheme | mount | 303 | 299 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 244 | 249 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 294 | 274 | 10 | |
| InfoButton | mount | 192 | 190 | 5000 | |
| MakeStyles | mount | 1303 | 1294 | 50000 | |
| Persona | mount | 2276 | 1976 | 5000 | |
| SpinButton | mount | 1929 | 1821 | 5000 |
…om dependency to mitigate dep-tree creep
packages/react-components/react-virtualizer/stories/Virtualizer/DefaultUnbounded.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-virtualizer/stories/Virtualizer/DefaultUnbounded.stories.tsx
Show resolved
Hide resolved
|
1 hour threshold reached for |
Previous Behavior
react-virtualizerintroduced a forbidden project dependency on react(v8), which caused pipeline creep ( on any v8 change all v9 project would be affected).Simplified Example:
@fluentui/react@fluentui/ssr-test-v9-->@fluentui/react-components-->@fluentui/react-virtualizer-->@fluentui/reactThis caused Out of memory/timeout issues for both PR pipelines and release pipelines
Example of failing PR/pipeline that triggers everything because of this: #27323
New Behavior
react v8 is no longer a v9 package direct or indirect dependency.
Notes:
lage build --to @fluentui/react.Related Issue(s)