fix(DialogContent): adds padding to allow focus visibility #27248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c56a950:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 77bb9ec1eeedef91315dee3750bd06b15168c693 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1076 | 1064 | 5000 | |
| Button | mount | 679 | 770 | 5000 | |
| Field | mount | 1930 | 1899 | 5000 | |
| FluentProvider | mount | 1444 | 1489 | 5000 | |
| FluentProviderWithTheme | mount | 377 | 362 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 311 | 272 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 356 | 350 | 10 | |
| InfoButton | mount | 248 | 239 | 5000 | |
| MakeStyles | mount | 1691 | 1695 | 50000 | |
| Persona | mount | 2718 | 2758 | 5000 | |
| SpinButton | mount | 2343 | 2349 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Mar 17, 2023
ling1726
reviewed
Mar 17, 2023
packages/react-components/react-dialog/src/components/DialogContent/useDialogContentStyles.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-dialog/fix--add-padding-to-dialog-content
branch
from
398ad62 to
25febcd
Compare
ling1726
reviewed
Mar 22, 2023
packages/react-components/react-dialog/src/components/DialogActions/useDialogActionsStyles.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-dialog/fix--add-padding-to-dialog-content
branch
from
db3201b to
c56a950
Compare
ling1726
approved these changes
Mar 22, 2023
|
This makes the scrollbar always visible. It's pretty ugly.
|
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 27, 2023
* master: (47 commits) fix: Fix vertical alignment of inline Checkbox when checked vs. unchecked (microsoft#27324) applying package updates Fix: Revert microsoft#26931 change due to new bug it introduced (microsoft#27323) chore(react-infobutton): Renaming content slot to info (microsoft#27316) applying package updates Fix bad release mismatch of react-select (microsoft#27321) applying package updates Fix react-combobox mismatch after bad release (microsoft#27319) docs: add section about media query sorting (microsoft#27307) applying package updates fix: sync packages and changefiles after bad release (microsoft#27317) applying package updates chore(react-datepicker-compat): Cleanup types, unused code, and restore utils tests (microsoft#27297) [Fluent 2 Theme] Fixing link color in dark theme (microsoft#27203) Tree documentation and stories (microsoft#27270) feat: Render theme CSS variables in SSR style element (microsoft#27277) chore (scripts): update create-package plop templates to use swc/helpers in deps (microsoft#27286) fix(DialogContent): adds padding to allow focus visibility (microsoft#27248) Adding Card component style hooks to shared context (microsoft#27295) Virtualizer: Static scroll hooks and embedded scrollview (microsoft#26985) ...
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Without proper padding the border of focusable elements inside
DialogContentwould be lost.New Behavior
Related Issue(s)