Virtualizer: Static scroll hooks and embedded scrollview #26985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 77bb9ec1eeedef91315dee3750bd06b15168c693 (build) |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3a81dc1:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1067 | 1120 | 5000 | |
| Button | mount | 684 | 680 | 5000 | |
| Field | mount | 1966 | 2009 | 5000 | |
| FluentProvider | mount | 1389 | 1388 | 5000 | |
| FluentProviderWithTheme | mount | 352 | 373 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 288 | 289 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 345 | 346 | 10 | |
| InfoButton | mount | 246 | 241 | 5000 | |
| MakeStyles | mount | 1542 | 1635 | 50000 | |
| Persona | mount | 2705 | 2597 | 5000 | |
| SpinButton | mount | 2313 | 2328 | 5000 |
Mitch-At-Work
force-pushed
the
user/mifraser/virtualizer-scroll-hooks
branch
3 times, most recently
from
7f3a9ed to
4f31318
Compare
ling1726
reviewed
Mar 14, 2023
packages/react-components/react-virtualizer/src/components/Virtualizer/Virtualizer.types.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
packages/react-components/react-virtualizer/src/components/Virtualizer/useVirtualizer.ts
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
packages/react-components/react-virtualizer/src/components/Virtualizer/useVirtualizer.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
...omponents/react-virtualizer/src/components/VirtualizerScrollView/useVirtualizerScrollView.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
...t-components/react-virtualizer/src/components/VirtualizerScrollView/VirtualizerScrollView.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
packages/react-components/react-virtualizer/src/hooks/useVirtualizerMeasure.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
packages/react-components/react-virtualizer/src/hooks/useVirtualizerMeasure.ts
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
packages/react-components/react-virtualizer/src/hooks/useVirtualizerMeasure.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
packages/react-components/react-virtualizer/src/hooks/useVirtualizerMeasure.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
...nts/react-virtualizer/src/components/VirtualizerScrollView/useVirtualizerScrollViewStyles.ts
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
packages/react-components/react-virtualizer/stories/VirtualizerScrollView/Default.stories.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 14, 2023
packages/react-components/react-virtualizer/src/hooks/useVirtualizerMeasure.ts
Outdated
Show resolved
Hide resolved
Mitch-At-Work
force-pushed
the
user/mifraser/virtualizer-scroll-hooks
branch
2 times, most recently
from
b4d012a to
47a9a46
Compare
ling1726
reviewed
Mar 20, 2023
packages/react-components/react-virtualizer/src/hooks/useVirtualizerMeasure.types.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 20, 2023
packages/react-components/react-virtualizer/src/hooks/useVirtualizerMeasure.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Mar 20, 2023
packages/react-components/react-virtualizer/src/hooks/useVirtualizerMeasure.ts
Outdated
Show resolved
Hide resolved
Mitch-At-Work
force-pushed
the
user/mifraser/virtualizer-scroll-hooks
branch
from
5df23bf to
65ec330
Compare
ling1726
reviewed
Mar 22, 2023
packages/react-components/react-virtualizer/src/components/Virtualizer/useVirtualizer.ts
Show resolved
Hide resolved
brandonthomas
approved these changes
Mar 22, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 27, 2023
* master: (47 commits) fix: Fix vertical alignment of inline Checkbox when checked vs. unchecked (microsoft#27324) applying package updates Fix: Revert microsoft#26931 change due to new bug it introduced (microsoft#27323) chore(react-infobutton): Renaming content slot to info (microsoft#27316) applying package updates Fix bad release mismatch of react-select (microsoft#27321) applying package updates Fix react-combobox mismatch after bad release (microsoft#27319) docs: add section about media query sorting (microsoft#27307) applying package updates fix: sync packages and changefiles after bad release (microsoft#27317) applying package updates chore(react-datepicker-compat): Cleanup types, unused code, and restore utils tests (microsoft#27297) [Fluent 2 Theme] Fixing link color in dark theme (microsoft#27203) Tree documentation and stories (microsoft#27270) feat: Render theme CSS variables in SSR style element (microsoft#27277) chore (scripts): update create-package plop templates to use swc/helpers in deps (microsoft#27286) fix(DialogContent): adds padding to allow focus visibility (microsoft#27248) Adding Card component style hooks to shared context (microsoft#27295) Virtualizer: Static scroll hooks and embedded scrollview (microsoft#26985) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Currently Virtualizer requires users to implement their own scroll containers, or provide their own logic for resize of windows and ensuring optimal VirtualizerLength parameters.
New Behavior
Users can now use the hooks to measure the body bounds, or provide a scrollview ref to measure the perfect Virtualizer parameters for window size.
Users can now also implement the Virtualizer as a default scrollView with uniform column/row sizes, removing complexity for simple use cases.
Related Issue(s)
ToDo (Future PR):