Skip to content

Conversation

@GeoffCoxMSFT
Copy link
Member

Issue

Published package was missing lib and lib-commonjs code

Changes

  • Updated ts.config to build to dist folder like a v8 component

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Oct 27, 2022
@GeoffCoxMSFT GeoffCoxMSFT requested a review from a team as a code owner October 27, 2022 18:53
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 27, 2022

📊 Bundle size report

🤖 This report was generated against 8af3b4d39ad1649ceeb5a2797ad00aa3f0b1547c

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 450d5a5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 27, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8af3b4d39ad1649ceeb5a2797ad00aa3f0b1547c (build)

@TristanWatanabe
Copy link
Member

I think you need to update the api.extractor.json file to use the old setup as well

{
  "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
  "extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json",
  "mainEntryPointFilePath": "<projectFolder>/dist/index.d.ts"
}

@GeoffCoxMSFT GeoffCoxMSFT merged commit e799d65 into microsoft:master Oct 28, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 31, 2022
* master: (22 commits)
  fix(react-menu): removes exposing of internal type FluentTriggerComponent (microsoft#25410)
  fix(react-popover): removes exposing of internal type FluentTriggerComponent (microsoft#25411)
  applying package updates
  fix(react-tooltip): removes exposing of internal type FluentTriggerComponent (microsoft#25409)
  chore: Reducing bundle size of Stack by moving selector used in multiple places to local const (microsoft#25429)
  docs(rfcs): Simple component implementation (microsoft#25139)
  Fix migration publishing (microsoft#25422)
  Integrate storywright for story tests - As part of exploring screener alternative (microsoft#25399)
  fix(react-utilities): exposes internal methods used in API surface (microsoft#25406)
  fix(react-dialog): removes exposing of internal type FluentTriggerComponent (microsoft#25408)
  fix(react-context-selector): exposes internal type ContextSelector (microsoft#25404)
  fix(react-aria): exposes internal leaking types (microsoft#25403)
  fix(react-shared-contexts): exposes internal leaks used in the API surface (microsoft#25405)
  fix(react-positioning): exposes new typings to avoid exposing internal methods (microsoft#25407)
  applying package updates
  fix: Allowing DatePicker to be focusable within FocusZones by default (microsoft#25428)
  fix: Pad in slider so the thumb does not render outside the bounds of the root element (microsoft#25378)
  feat: Add enableScopedSelectors prop to Stack that, when true, makes the Stack styles selectors be more scoped to not be as expensive in style recalculation (microsoft#25397)
  fix(react-avatar): Remove gaps between AvatarGroupItem/OveflowButton and its outline (microsoft#25382)
  fix: Combobox text attribute ignored when empty string is passed (microsoft#24665)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
* Updated to build to dist

* yarn change

* Updated api-extractor path

* Update change/@fluentui-react-migration-v8-v9-3cbbe105-994c-407f-9441-2c2ce867d5f0.json

Co-authored-by: Makoto Morimoto <[email protected]>

* Update api-extractor.json

* Update packages/react-migration-v8-v9/config/api-extractor.json

Co-authored-by: Tristan Watanabe <[email protected]>

Co-authored-by: Makoto Morimoto <[email protected]>
Co-authored-by: Tristan Watanabe <[email protected]>
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* Updated to build to dist

* yarn change

* Updated api-extractor path

* Update change/@fluentui-react-migration-v8-v9-3cbbe105-994c-407f-9441-2c2ce867d5f0.json

Co-authored-by: Makoto Morimoto <[email protected]>

* Update api-extractor.json

* Update packages/react-migration-v8-v9/config/api-extractor.json

Co-authored-by: Tristan Watanabe <[email protected]>

Co-authored-by: Makoto Morimoto <[email protected]>
Co-authored-by: Tristan Watanabe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants