fix: Pad in slider so the thumb does not render outside the bounds of the root element #25378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the root element
2 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0ed7414:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1278 | 1289 | 5000 | |
| Button | mount | 931 | 921 | 5000 | |
| FluentProvider | mount | 1508 | 1487 | 5000 | |
| FluentProviderWithTheme | mount | 583 | 584 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 546 | 546 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 570 | 578 | 10 | |
| MakeStyles | mount | 1957 | 1942 | 50000 | |
| SpinButton | mount | 2346 | 2362 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 870f51fc39736198871559d6e12ece5663b0525f (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
micahgodbolt
approved these changes
Oct 27, 2022
Contributor
|
I see two small issues with Screener.
|
Contributor
Author
|
@spmonahan I fixed the VR tests, and added some 0% and 100% ones as well, to test this particular change. The fixes to the VR tests resulted in some extra test-only padding changes. |
khmakoto
approved these changes
Oct 27, 2022
spmonahan
approved these changes
Oct 27, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 31, 2022
* master: (22 commits) fix(react-menu): removes exposing of internal type FluentTriggerComponent (microsoft#25410) fix(react-popover): removes exposing of internal type FluentTriggerComponent (microsoft#25411) applying package updates fix(react-tooltip): removes exposing of internal type FluentTriggerComponent (microsoft#25409) chore: Reducing bundle size of Stack by moving selector used in multiple places to local const (microsoft#25429) docs(rfcs): Simple component implementation (microsoft#25139) Fix migration publishing (microsoft#25422) Integrate storywright for story tests - As part of exploring screener alternative (microsoft#25399) fix(react-utilities): exposes internal methods used in API surface (microsoft#25406) fix(react-dialog): removes exposing of internal type FluentTriggerComponent (microsoft#25408) fix(react-context-selector): exposes internal type ContextSelector (microsoft#25404) fix(react-aria): exposes internal leaking types (microsoft#25403) fix(react-shared-contexts): exposes internal leaks used in the API surface (microsoft#25405) fix(react-positioning): exposes new typings to avoid exposing internal methods (microsoft#25407) applying package updates fix: Allowing DatePicker to be focusable within FocusZones by default (microsoft#25428) fix: Pad in slider so the thumb does not render outside the bounds of the root element (microsoft#25378) feat: Add enableScopedSelectors prop to Stack that, when true, makes the Stack styles selectors be more scoped to not be as expensive in style recalculation (microsoft#25397) fix(react-avatar): Remove gaps between AvatarGroupItem/OveflowButton and its outline (microsoft#25382) fix: Combobox text attribute ignored when empty string is passed (microsoft#24665) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
… the root element (microsoft#25378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The thumb of Slider extends beyond the bounds of its root, which causes it to appear misaligned with a label or other form controls:
New Behavior
Add padding to the edges of slider, so the track is now inset by half of the thumb width. The edges of the thumb will never extend past the bounds of the root element.
Preview: https://fluentuipr.z22.web.core.windows.net/pull/25378/public-docsite-v9/storybook/index.html?path=/docs/components-slider--default
Related Issue(s)