feat: adds disableButtonEnhancement property on triggers #25112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b48083b3009bc75f28c328de0024eb400b989145 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5ac8e8e:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1268 | 1267 | 5000 | |
| Button | mount | 923 | 905 | 5000 | |
| FluentProvider | mount | 1463 | 1486 | 5000 | |
| FluentProviderWithTheme | mount | 568 | 584 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 539 | 542 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 574 | 571 | 10 | |
| MakeStyles | mount | 1980 | 1935 | 50000 | |
| SpinButton | mount | 2369 | 2292 | 5000 |
bsunderhus
force-pushed
the
react-utilities/feat--disableButtonEnchancement
branch
from
b4fc9f7 to
5ac8e8e
Compare
Contributor
Author
|
This will be blocked while RFC #24960 is resolved |
ling1726
approved these changes
Oct 13, 2022
bsunderhus
deleted the
react-utilities/feat--disableButtonEnchancement
branch
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #24960
Implementing the
disableButtonEnhancementproperty that will ensure triggers can opt out of the current behavior where child is enhanced with button-like handlers and properties