-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(react-dialog): updates disallowed change types #25214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ling1726
merged 1 commit into
microsoft:master
from
bsunderhus:react-dialog/chore--updates-disallowedChangeTypes
Oct 13, 2022
Merged
chore(react-dialog): updates disallowed change types #25214
ling1726
merged 1 commit into
microsoft:master
from
bsunderhus:react-dialog/chore--updates-disallowedChangeTypes
Oct 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3808921 to
4aa6b7f
Compare
Collaborator
📊 Bundle size reportUnchanged fixtures
|
4aa6b7f to
83fa476
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e4feedc:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 39189c2f82910e8b87d1905eee23da0cac7c1770 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1295 | 1300 | 5000 | |
| Button | mount | 936 | 965 | 5000 | |
| FluentProvider | mount | 1577 | 1536 | 5000 | |
| FluentProviderWithTheme | mount | 638 | 630 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 515 | 589 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 620 | 641 | 10 | |
| MakeStyles | mount | 1889 | 1888 | 50000 | |
| SpinButton | mount | 2506 | 2336 | 5000 |
83fa476 to
4203fe2
Compare
4203fe2 to
e4feedc
Compare
ling1726
approved these changes
Oct 13, 2022
layershifter
approved these changes
Oct 13, 2022
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
prereleaseas disallowed change type forreact-dialogas it was released.react-dialogversion