Skip to content

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Oct 13, 2022

New Behavior

  1. add prerelease as disallowed change type for react-dialog as it was released.
  2. fix react-dialog version

@bsunderhus bsunderhus self-assigned this Oct 13, 2022
@bsunderhus bsunderhus force-pushed the react-dialog/chore--updates-disallowedChangeTypes branch from 3808921 to 4aa6b7f Compare October 13, 2022 13:00
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 13, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.827 kB
17.599 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.375 kB
52.561 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-dialog
Dialog (including children components)
82.626 kB
24.504 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 39189c2f82910e8b87d1905eee23da0cac7c1770

@bsunderhus bsunderhus changed the title bugfix: updates change files to be patch chore(react-dialog): updates disallowed change types Oct 13, 2022
@bsunderhus bsunderhus force-pushed the react-dialog/chore--updates-disallowedChangeTypes branch from 4aa6b7f to 83fa476 Compare October 13, 2022 13:04
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e4feedc:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 13, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 39189c2f82910e8b87d1905eee23da0cac7c1770 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 13, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1295 1300 5000
Button mount 936 965 5000
FluentProvider mount 1577 1536 5000
FluentProviderWithTheme mount 638 630 10
FluentProviderWithTheme virtual-rerender 515 589 10
FluentProviderWithTheme virtual-rerender-with-unmount 620 641 10
MakeStyles mount 1889 1888 50000
SpinButton mount 2506 2336 5000

@bsunderhus bsunderhus force-pushed the react-dialog/chore--updates-disallowedChangeTypes branch from 83fa476 to 4203fe2 Compare October 13, 2022 13:50
@bsunderhus bsunderhus force-pushed the react-dialog/chore--updates-disallowedChangeTypes branch from 4203fe2 to e4feedc Compare October 13, 2022 14:09
@bsunderhus bsunderhus marked this pull request as ready for review October 13, 2022 16:57
@bsunderhus bsunderhus requested a review from a team as a code owner October 13, 2022 16:57
@ling1726 ling1726 enabled auto-merge (squash) October 13, 2022 16:59
@ling1726 ling1726 merged commit 083a2c4 into microsoft:master Oct 13, 2022
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants