chore: bump @octokit/rest to v18 #24919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 06b7c59:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 7ab1b2af48066e24961610b68762683c4698eb00 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1281 | 1270 | 5000 | |
| Button | mount | 920 | 946 | 5000 | |
| FluentProvider | mount | 1481 | 1469 | 5000 | |
| FluentProviderWithTheme | mount | 578 | 584 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 536 | 553 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 580 | 564 | 10 | |
| MakeStyles | mount | 1960 | 1955 | 50000 | |
| SpinButton | mount | 2347 | 2310 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 129 | 118 | 1.09:1 |
| VideoMinimalPerf.default | 627 | 588 | 1.07:1 |
| AlertMinimalPerf.default | 230 | 218 | 1.06:1 |
| ButtonSlotsPerf.default | 433 | 410 | 1.06:1 |
| RefMinimalPerf.default | 196 | 185 | 1.06:1 |
| ChatDuplicateMessagesPerf.default | 225 | 215 | 1.05:1 |
| IconMinimalPerf.default | 590 | 563 | 1.05:1 |
| TableMinimalPerf.default | 370 | 354 | 1.05:1 |
| PortalMinimalPerf.default | 143 | 137 | 1.04:1 |
| AnimationMinimalPerf.default | 479 | 463 | 1.03:1 |
| AttachmentMinimalPerf.default | 128 | 124 | 1.03:1 |
| FormMinimalPerf.default | 336 | 326 | 1.03:1 |
| GridMinimalPerf.default | 300 | 290 | 1.03:1 |
| ProviderMinimalPerf.default | 322 | 313 | 1.03:1 |
| ButtonOverridesMissPerf.default | 1033 | 1012 | 1.02:1 |
| CarouselMinimalPerf.default | 359 | 353 | 1.02:1 |
| ChatMinimalPerf.default | 647 | 635 | 1.02:1 |
| LayoutMinimalPerf.default | 318 | 311 | 1.02:1 |
| DatepickerMinimalPerf.default | 4743 | 4684 | 1.01:1 |
| DropdownManyItemsPerf.default | 544 | 541 | 1.01:1 |
| FlexMinimalPerf.default | 250 | 248 | 1.01:1 |
| ImageMinimalPerf.default | 343 | 340 | 1.01:1 |
| InputMinimalPerf.default | 869 | 861 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 984 | 976 | 1.01:1 |
| ListCommonPerf.default | 519 | 515 | 1.01:1 |
| ListNestedPerf.default | 466 | 462 | 1.01:1 |
| ListWith60ListItems.default | 492 | 487 | 1.01:1 |
| PopupMinimalPerf.default | 561 | 554 | 1.01:1 |
| SegmentMinimalPerf.default | 298 | 296 | 1.01:1 |
| TreeMinimalPerf.default | 706 | 697 | 1.01:1 |
| AttachmentSlotsPerf.default | 880 | 882 | 1:1 |
| AvatarMinimalPerf.default | 162 | 162 | 1:1 |
| BoxMinimalPerf.default | 300 | 300 | 1:1 |
| ButtonMinimalPerf.default | 134 | 134 | 1:1 |
| CheckboxMinimalPerf.default | 1527 | 1529 | 1:1 |
| DialogMinimalPerf.default | 687 | 684 | 1:1 |
| DividerMinimalPerf.default | 316 | 317 | 1:1 |
| DropdownMinimalPerf.default | 2179 | 2173 | 1:1 |
| EmbedMinimalPerf.default | 2646 | 2637 | 1:1 |
| HeaderMinimalPerf.default | 313 | 312 | 1:1 |
| HeaderSlotsPerf.default | 682 | 682 | 1:1 |
| SplitButtonMinimalPerf.default | 3266 | 3265 | 1:1 |
| StatusMinimalPerf.default | 606 | 605 | 1:1 |
| TextMinimalPerf.default | 303 | 304 | 1:1 |
| TextAreaMinimalPerf.default | 417 | 418 | 1:1 |
| CustomToolbarPrototype.default | 2158 | 2154 | 1:1 |
| TooltipMinimalPerf.default | 1856 | 1855 | 1:1 |
| ChatWithPopoverPerf.default | 301 | 303 | 0.99:1 |
| ListMinimalPerf.default | 451 | 457 | 0.99:1 |
| MenuMinimalPerf.default | 724 | 734 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1341 | 1361 | 0.99:1 |
| RosterPerf.default | 1716 | 1728 | 0.99:1 |
| ProviderMergeThemesPerf.default | 990 | 995 | 0.99:1 |
| ReactionMinimalPerf.default | 322 | 326 | 0.99:1 |
| SkeletonMinimalPerf.default | 298 | 300 | 0.99:1 |
| TableManyItemsPerf.default | 1555 | 1568 | 0.99:1 |
| ToolbarMinimalPerf.default | 792 | 799 | 0.99:1 |
| TreeWith60ListItems.default | 126 | 127 | 0.99:1 |
| LabelMinimalPerf.default | 335 | 343 | 0.98:1 |
| RadioGroupMinimalPerf.default | 383 | 389 | 0.98:1 |
| SliderMinimalPerf.default | 1228 | 1250 | 0.98:1 |
| CardMinimalPerf.default | 461 | 474 | 0.97:1 |
| LoaderMinimalPerf.default | 503 | 517 | 0.97:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| ContextualMenu | mount | 6819 | 11491 | 1000 | Possible regression |
| DefaultButton | mount | 1387 | 2486 | 5000 | Possible regression |
| ThemeProvider | virtual-rerender-with-unmount | 2156 | 2133 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1180 | 1191 | 5000 | |
| Breadcrumb | mount | 2970 | 3009 | 1000 | |
| Checkbox | mount | 2538 | 2654 | 5000 | |
| CheckboxBase | mount | 2333 | 2295 | 5000 | |
| ChoiceGroup | mount | 4342 | 4377 | 5000 | |
| ComboBox | mount | 1252 | 1255 | 1000 | |
| CommandBar | mount | 9571 | 9578 | 1000 | |
| ContextualMenu | mount | 6819 | 11491 | 1000 | Possible regression |
| DefaultButton | mount | 1387 | 2486 | 5000 | Possible regression |
| DetailsRow | mount | 3666 | 5069 | 5000 | |
| DetailsRowFast | mount | 3671 | 3644 | 5000 | |
| DetailsRowNoStyles | mount | 3494 | 3478 | 5000 | |
| Dialog | mount | 3101 | 3107 | 1000 | |
| DocumentCardTitle | mount | 583 | 575 | 1000 | |
| Dropdown | mount | 3232 | 3244 | 5000 | |
| FocusTrapZone | mount | 2020 | 2013 | 5000 | |
| FocusZone | mount | 1972 | 1992 | 5000 | |
| GroupedList | mount | 53992 | 60976 | 2 | |
| GroupedList | virtual-rerender | 25654 | 25392 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 93705 | 94857 | 2 | |
| GroupedListV2 | mount | 568 | 561 | 2 | |
| GroupedListV2 | virtual-rerender | 519 | 533 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 559 | 575 | 2 | |
| IconButton | mount | 1933 | 1918 | 5000 | |
| Label | mount | 735 | 734 | 5000 | |
| Layer | mount | 4270 | 4228 | 5000 | |
| Link | mount | 833 | 821 | 5000 | |
| MenuButton | mount | 1652 | 1693 | 5000 | |
| MessageBar | mount | 2298 | 2377 | 5000 | |
| Nav | mount | 3263 | 3273 | 1000 | |
| OverflowSet | mount | 1365 | 1352 | 5000 | |
| Panel | mount | 2555 | 2555 | 1000 | |
| Persona | mount | 1254 | 1290 | 1000 | |
| Pivot | mount | 1650 | 1674 | 1000 | |
| PrimaryButton | mount | 1519 | 1534 | 5000 | |
| Rating | mount | 7005 | 7073 | 5000 | |
| SearchBox | mount | 1506 | 1535 | 5000 | |
| Shimmer | mount | 2877 | 2896 | 5000 | |
| Slider | mount | 2089 | 2109 | 5000 | |
| SpinButton | mount | 4707 | 4592 | 5000 | |
| Spinner | mount | 800 | 784 | 5000 | |
| SplitButton | mount | 2993 | 3110 | 5000 | |
| Stack | mount | 851 | 860 | 5000 | |
| StackWithIntrinsicChildren | mount | 2312 | 2274 | 5000 | |
| StackWithTextChildren | mount | 4812 | 4741 | 5000 | |
| SwatchColorPicker | mount | 10476 | 10538 | 5000 | |
| TagPicker | mount | 2557 | 2634 | 5000 | |
| TeachingBubble | mount | 89870 | 89566 | 5000 | |
| Text | mount | 803 | 797 | 5000 | |
| TextField | mount | 1594 | 1595 | 5000 | |
| ThemeProvider | mount | 1512 | 1519 | 5000 | |
| ThemeProvider | virtual-rerender | 1079 | 1073 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2156 | 2133 | 5000 | Possible regression |
| Toggle | mount | 1120 | 1132 | 5000 | |
| buttonNative | mount | 548 | 554 | 5000 |
ling1726
approved these changes
Sep 23, 2022
Hotell
force-pushed
the
hotell/deps/bump-octokit
branch
from
94d83fc to
ad1e817
Compare
auto-merge was automatically disabled
September 26, 2022 16:22
Pull request was closed
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 28, 2022
* master: (21 commits) chore: Migrate react-avatar to use new build (microsoft#24969) applying package updates chore(react-input, react-textarea): Deprecating filled with shadow appearance variants (microsoft#24900) fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant (microsoft#24593) feat: v0 Tooltip migration from v9 (microsoft#24908) chore: bump devDeps to fix critical security vulnerability (microsoft#24891) Fixing Tree chart issues (microsoft#24752) init: new package react-avatar-context (microsoft#24968) ci(.github): add issues write permisions to triage-bot worflow (microsoft#24963) applying package updates fix(Toolbar): close previous submenu when opening another submenu (microsoft#24836) fix: update non-focus-trap Popover role to be group (microsoft#24897) feat: Avatar's aria label includes 'active' or 'inactive' when using the active prop (microsoft#24901) feat(scripts): implement triage-bot module (microsoft#24911) chore: bump @octokit/rest to v18 (microsoft#24919) stress test: add "build-fixture" command (microsoft#24928) BREAKING-CHANGE: new ChatMessageContent for style caching (microsoft#24691) bugfix: fix changefile to properly update version of react-components with a patch (microsoft#24949) feat(scripts): enable strict checking for additional sub-folders(packages) (microsoft#24526) chore: exports DialogContent as unstable (microsoft#24943) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* chore: bump @octokit/rest to v18 * fixup! chore: bump @octokit/rest to v18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
we use v 16. Danger uses v18
New Behavior
we use v18
NOTE:
Lot of things changed since v16 including types... those types moves are not very well documented, so I did the best I could. If we are no 100% confident we can drop this and use v16.