Skip to content

fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant #24593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smhigley merged 2 commits into from
Sep 27, 2022
Merged

fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant #24593

smhigley merged 2 commits into from
Sep 27, 2022
+7 −8

Conversation

@smhigley
Copy link
Contributor

@smhigley smhigley commented Aug 30, 2022

The v8 Dropdown uses keyboard focus to move between options when the popup is open, but still sets aria-activedescendant on the trigger. The attribute currently serves no use, since the trigger does not have focus when the popup is open.

Because activedescendant is based on an internally generated id, rendering custom options that do not receive the internal id results in an automated a11y test failure. This PR removes the attribute entirely to fix that issue and simplify the component.

@smhigley smhigley self-assigned this Aug 30, 2022
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Aug 30, 2022
@smhigley smhigley marked this pull request as ready for review August 30, 2022 17:52
@smhigley smhigley requested a review from a team as a code owner August 30, 2022 17:52
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 30, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f912df5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 30, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-Dropdown 220.136 kB 220.049 kB BelowBaseline     -87 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: d1e8f0764fb477271da45f0dd1f4c1b3beb06699 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 30, 2022

📊 Bundle size report

🤖 This report was generated against d1e8f0764fb477271da45f0dd1f4c1b3beb06699

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 30, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 724 702 5000
Breadcrumb mount 2217 2376 1000
Checkbox mount 2203 2190 5000
CheckboxBase mount 1943 1853 5000
ChoiceGroup mount 3545 3797 5000
ComboBox mount 723 801 1000
CommandBar mount 8895 8524 1000
ContextualMenu mount 10274 10539 1000
DefaultButton mount 960 956 5000
DetailsRow mount 3154 3023 5000
DetailsRowFast mount 3250 3216 5000
DetailsRowNoStyles mount 3002 2899 5000
Dialog mount 2542 2449 1000
DocumentCardTitle mount 148 155 1000
Dropdown mount 2810 2547 5000
FocusTrapZone mount 1626 1574 5000
FocusZone mount 1427 1487 5000
IconButton mount 1464 1437 5000
Label mount 300 278 5000
Layer mount 3808 3620 5000
Link mount 393 347 5000
MenuButton mount 1249 1224 5000
MessageBar mount 1818 1707 5000
Nav mount 2700 2702 1000
OverflowSet mount 886 835 5000
Panel mount 2040 1984 1000
Persona mount 766 829 1000
Pivot mount 1176 1103 1000
PrimaryButton mount 1062 1039 5000
Rating mount 6252 5938 5000
SearchBox mount 1018 1002 5000
Shimmer mount 2409 2271 5000
Slider mount 1644 1511 5000
SpinButton mount 4136 4029 5000
Spinner mount 344 387 5000
SplitButton mount 2452 2593 5000
Stack mount 383 381 5000
StackWithIntrinsicChildren mount 1865 1877 5000
StackWithTextChildren mount 4353 4015 5000
SwatchColorPicker mount 9645 9746 5000
TagPicker mount 2217 2056 5000
TeachingBubble mount 86051 86589 5000
Text mount 321 325 5000
TextField mount 1101 1062 5000
ThemeProvider mount 1084 1082 5000
ThemeProvider virtual-rerender 574 647 5000
ThemeProvider virtual-rerender-with-unmount 1635 1739 5000
Toggle mount 690 678 5000
buttonNative mount 114 120 5000

@smhigley smhigley merged commit adea89e into microsoft:master Sep 27, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 28, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
419ff48 
* master: (21 commits)
  chore: Migrate react-avatar to use new build (microsoft#24969)
  applying package updates
  chore(react-input, react-textarea): Deprecating filled with shadow appearance variants (microsoft#24900)
  fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant (microsoft#24593)
  feat: v0 Tooltip migration from v9 (microsoft#24908)
  chore: bump devDeps to fix critical security vulnerability (microsoft#24891)
  Fixing Tree chart issues (microsoft#24752)
  init: new package react-avatar-context (microsoft#24968)
  ci(.github): add issues write permisions to triage-bot worflow (microsoft#24963)
  applying package updates
  fix(Toolbar): close previous submenu when opening another submenu (microsoft#24836)
  fix: update non-focus-trap Popover role to be group (microsoft#24897)
  feat: Avatar's aria label includes 'active' or 'inactive' when using the active prop (microsoft#24901)
  feat(scripts): implement triage-bot module (microsoft#24911)
  chore: bump @octokit/rest to v18 (microsoft#24919)
  stress test: add "build-fixture" command (microsoft#24928)
  BREAKING-CHANGE: new ChatMessageContent for style caching (microsoft#24691)
  bugfix: fix changefile to properly update version of react-components with a patch (microsoft#24949)
  feat(scripts): enable strict checking for additional sub-folders(packages) (microsoft#24526)
  chore: exports DialogContent as unstable (microsoft#24943)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@smhigley @NotWoods
fix: v8 Dropdown no longer sets incorrect and unnecessary aria-active…
353d5d0 
…descendant (microsoft#24593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sopranopillow sopranopillow sopranopillow approved these changes

@spmonahan spmonahan spmonahan approved these changes

Assignees

@smhigley smhigley

Labels

Component: Dropdown

Projects

None yet

Milestone

July Project Cycle Q3 2022

Development

Successfully merging this pull request may close these issues.

5 participants

@smhigley @fabricteam @sopranopillow @spmonahan @msft-fluent-ui-bot