fix: react-combobox Option focus outline only shows with keyboard nav #24700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 79dc9cb:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4c31b27421360e80d8435235092a634a67b0418a (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1314 | 1319 | 5000 | |
| Button | mount | 960 | 971 | 5000 | |
| FluentProvider | mount | 1605 | 1570 | 5000 | |
| FluentProviderWithTheme | mount | 620 | 633 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 588 | 597 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 641 | 633 | 10 | |
| MakeStyles | mount | 1936 | 1898 | 50000 | |
| SpinButton | mount | 2544 | 2513 | 5000 |
smhigley
force-pushed
the
combo-focus-outline
branch
from
2bc6771 to
ac6c4c7
Compare
micahgodbolt
approved these changes
Sep 9, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 14, 2022
* master: (28 commits) Fix value font-weight inside heatmap chart (microsoft#24726) Fix legend overflow-indication-text role (microsoft#24756) Support custom locale in date axis (microsoft#24753) Cleanup env variables (microsoft#24739) ci(github): add GH Action to add issue labels based on new GH issue template (microsoft#24788) Update disallowedChangeTypes for newly created packages, to allow only 'prerelease' change types by default (microsoft#24763) feat(react-components): Adding missing AvatarGroup exports (microsoft#24770) remove unnecessary nohoist (microsoft#24760) feat(react-dialog): supports 1st rule of ARIA (microsoft#24525) BREAKING: TableCell layouts are handled by layout components (microsoft#24762) feat: Implement table cell layout components (microsoft#24773) applying package updates fix: remove readonly from DetailsList (microsoft#24615) chore: Cleaning up tokens in Button components so they better adhere to the design spec (microsoft#24732) fix: react-combobox listbox popup width matches trigger width (microsoft#24733) fix: react-combobox Option focus outline only shows with keyboard nav (microsoft#24700) feat: Publish react-field package, and export from react-components/unstable (microsoft#24235) fix: Replacing bottom border styles with text decoration underline in Link (microsoft#24734) docs(react-theme): Update readme (microsoft#24755) Add tests for hover states (microsoft#24390) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an item on the design review, #23926
Existing focus outline helpers and even
useKeyboardNavAttributefrom tabster don't work in this case, since keyboard focus doesn't move from the trigger, and the style is on the options.My solution was to set a
focusVisiblestate, set to true by keyboard interactions that open the listbox, move theactiveOption, or type characters; and set to false bymouseOverevents.