Skip to content

fix: remove readonly from DetailsList #24615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smhigley merged 2 commits into from
Sep 13, 2022
Merged

fix: remove readonly from DetailsList #24615

smhigley merged 2 commits into from
Sep 13, 2022

Conversation

@smhigley
Copy link
Contributor

@smhigley smhigley commented Aug 31, 2022

Fixes 15360

Related to the Calendar/Datepicker fix (#20324), Talkback (more or less correctly) doesn't allow interaction with controls inside of elements with readonly, so the selection checkboxes and any author-provided nested form inputs in DetailsList were not interactive.

@smhigley smhigley self-assigned this Aug 31, 2022
@smhigley smhigley requested review from a team and ThomasMichon as code owners August 31, 2022 16:50
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Aug 31, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 31, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8cd51f7:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 31, 2022 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-ShimmeredDetailsList 232.33 kB 232.288 kB BelowBaseline     -42 bytes
office-ui-fabric-react fluentui-react-DetailsList 221.839 kB 221.797 kB BelowBaseline     -42 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 8235a36f9e429f17a72e7e933627ea02825107cd (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2022 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 8235a36f9e429f17a72e7e933627ea02825107cd

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 770 790 5000
Breadcrumb mount 2387 2377 1000
Checkbox mount 2230 2231 5000
CheckboxBase mount 1963 1939 5000
ChoiceGroup mount 3882 3859 5000
ComboBox mount 764 762 1000
CommandBar mount 8890 8937 1000
ContextualMenu mount 9923 10047 1000
DefaultButton mount 927 948 5000
DetailsRow mount 3020 2906 5000
DetailsRowFast mount 3023 2930 5000
DetailsRowNoStyles mount 2897 2846 5000
Dialog mount 2586 2539 1000
DocumentCardTitle mount 144 140 1000
Dropdown mount 2763 2741 5000
FocusTrapZone mount 1547 1549 5000
FocusZone mount 1522 1522 5000
IconButton mount 1387 1381 5000
Label mount 324 301 5000
Layer mount 3672 3710 5000
Link mount 437 435 5000
MenuButton mount 1201 1189 5000
MessageBar mount 1946 1912 5000
Nav mount 2663 2662 1000
OverflowSet mount 1005 976 5000
Panel mount 2079 2046 1000
Persona mount 843 831 1000
Pivot mount 1110 1129 1000
PrimaryButton mount 1056 1078 5000
Rating mount 6503 6560 5000
SearchBox mount 1085 1089 5000
Shimmer mount 2478 2522 5000
Slider mount 1675 1651 5000
SpinButton mount 3875 4087 5000
Spinner mount 394 401 5000
SplitButton mount 2420 2427 5000
Stack mount 466 477 5000
StackWithIntrinsicChildren mount 1860 1842 5000
StackWithTextChildren mount 4514 4497 5000
SwatchColorPicker mount 9115 9071 5000
TagPicker mount 1922 1945 5000
TeachingBubble mount 77894 77774 5000
Text mount 394 399 5000
TextField mount 1125 1139 5000
ThemeProvider mount 1032 1033 5000
ThemeProvider virtual-rerender 708 710 5000
ThemeProvider virtual-rerender-with-unmount 1598 1591 5000
Toggle mount 711 710 5000
buttonNative mount 110 103 5000

@smhigley smhigley requested a review from a team as a code owner September 2, 2022 16:27
@smhigley smhigley merged commit a40ef34 into microsoft:master Sep 13, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 14, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
b8b4b55 
* master: (28 commits)
  Fix value font-weight inside heatmap chart (microsoft#24726)
  Fix legend overflow-indication-text role (microsoft#24756)
  Support custom locale in date axis  (microsoft#24753)
  Cleanup env variables (microsoft#24739)
  ci(github): add GH Action to add issue labels based on new GH issue template (microsoft#24788)
  Update disallowedChangeTypes for newly created packages, to allow only 'prerelease' change types by default (microsoft#24763)
  feat(react-components): Adding missing AvatarGroup exports (microsoft#24770)
  remove unnecessary nohoist (microsoft#24760)
  feat(react-dialog): supports 1st rule of ARIA (microsoft#24525)
  BREAKING: TableCell layouts are handled by layout components (microsoft#24762)
  feat: Implement table cell layout components (microsoft#24773)
  applying package updates
  fix: remove readonly from DetailsList (microsoft#24615)
  chore: Cleaning up tokens in Button components so they better adhere to the design spec (microsoft#24732)
  fix: react-combobox listbox popup width matches trigger width (microsoft#24733)
  fix: react-combobox Option focus outline only shows with keyboard nav (microsoft#24700)
  feat: Publish react-field package, and export from react-components/unstable (microsoft#24235)
  fix: Replacing bottom border styles with text decoration underline in Link (microsoft#24734)
  docs(react-theme): Update readme (microsoft#24755)
  Add tests for hover states (microsoft#24390)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sopranopillow sopranopillow sopranopillow approved these changes

@khmakoto khmakoto khmakoto approved these changes

@spmonahan spmonahan spmonahan approved these changes

@ThomasMichon ThomasMichon Awaiting requested review from ThomasMichon ThomasMichon is a code owner

Assignees

@smhigley smhigley

Labels

Component: DetailsList

Projects

None yet

Milestone

July Project Cycle Q3 2022

Development

Successfully merging this pull request may close these issues.

6 participants

@smhigley @fabricteam @sopranopillow @khmakoto @spmonahan @msft-fluent-ui-bot