Add all Field components to react-field #24426
Conversation
…d statusIcon to validationMessageIcon
📊 Bundle size report🤖 This report was generated against ff6eaee1c2f0702585ec8b5d6545e564a0ef5a86 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a5d5b04:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ff6eaee1c2f0702585ec8b5d6545e564a0ef5a86 (build) |
… branch 'master' of https://github.com/microsoft/fluentui into field/implement
…into field/add-all-components
…into field/add-all-components
…ield/add-all-components
It makes the documentation super conufsing because all of the underlying controls also have a primary slot, and both show up in the storybook.
…ield/add-all-components
packages/react-components/react-field/src/stories/InputField/index.stories.tsx
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| SwitchField adds a Label, validation message, and hint text to the Switch control. | |||
There was a problem hiding this comment.
Should this be like CheckboxField where a Label is not mentioned since Switch already has one?
| SwitchField adds a Label, validation message, and hint text to the Switch control. | |
| SwitchField adds a validation message and hint text to the Switch control. |
There was a problem hiding this comment.
This behavior is pending discussion with design. I'll update it once we decide how SwitchField should work.
| import type { FieldProps } from '../../Field'; | ||
| import { getFieldClassNames, renderField_unstable, useFieldStyles_unstable, useField_unstable } from '../../Field'; | ||
|
|
||
| export type CheckboxFieldProps = Omit<FieldProps<typeof Checkbox>, 'label'> & { |
There was a problem hiding this comment.
Does Switch also need to implement this behavior since it also already has a label prop?
There was a problem hiding this comment.
I'm talking to Design about how the label prop of Switch should work. I logged this issue to implement the final behavior once we decide how it should work:
packages/react-components/react-field/src/stories/CheckboxField/CheckboxFieldDescription.md
Show resolved
Hide resolved
packages/react-components/react-field/src/stories/Field/FieldDescription.md
Outdated
Show resolved
Hide resolved
4 participants
Current Behavior
Only
InputFieldwas added by PR #24394. The rest of the Field components still need to be implemented.New Behavior
Add the following components:
Move most storybook stories directly under Field/*. Each individual component has one Default story to display props and basic example usage.
Related Issue(s)
Spec: