Initial implementation of Field and InputField #24394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report🤖 This report was generated against d0017be0862c4927c0ea0801b1e0d636adb71f88 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 11aa35b:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d0017be0862c4927c0ea0801b1e0d636adb71f88 (build) |
…d statusIcon to validationMessageIcon
This was referenced Aug 19, 2022
Merged
spmonahan
reviewed
Aug 31, 2022
packages/react-components/react-field/src/components/Field/Field.types.ts
Show resolved
Hide resolved
packages/react-components/react-field/src/components/Field/Field.types.ts
Show resolved
Hide resolved
spmonahan
approved these changes
Sep 1, 2022
sopranopillow
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The Field component is not implemented.
New Behavior
Other field types like CheckboxField, ComboboxField, SliderField, etc. will be added in a separate PR to be merged after this one:
Related Issues
Spec: