Skip to content

Conversation

@theerebuss
Copy link
Contributor

Current Behavior

Due to the moving of the package, the usage of hardcoded absolute URLs to access GitHub raw assets in our stories is using the wrong path.

New Behavior

Path now accounts for the react-components/ move.

Related Issue(s)

#22692

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0960d8b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 3e0ff753cbb3375f28477b2249ecd8b012e2e946

@size-auditor
Copy link

size-auditor bot commented May 3, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3e0ff753cbb3375f28477b2249ecd8b012e2e946 (build)

@theerebuss
Copy link
Contributor Author

Screener fail is expected, will approve the changes after I get PR approval.

@theerebuss theerebuss merged commit bb2a042 into microsoft:master May 3, 2022
@theerebuss theerebuss deleted the fix-card-vr-tests branch May 3, 2022 11:02
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants