(chore) Move react-card, react-dialog, react-image to react-components subfolder #22692

TristanWatanabe · 2022-04-28T13:29:48Z

Changes

Moves @fluentui/react-card, @fluentui/react-dialog and @fluentui/react-image to react-components common folder using move-packages nx generator.

Related Issue(s)

Part of #22427

codesandbox-ci · 2022-04-28T13:35:53Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 40d48ae:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-04-28T13:39:41Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	910	902	5000
Button	mount	576	577	5000
FluentProvider	mount	1796	1749	5000
FluentProviderWithTheme	mount	266	256	10
FluentProviderWithTheme	virtual-rerender	225	230	10
FluentProviderWithTheme	virtual-rerender-with-unmount	291	288	10
MakeStyles	mount	1672	1662	50000

size-auditor · 2022-04-28T13:41:09Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f8b29e77dbcc19f83896c910464c33346a2d5ace (build)

fabricteam · 2022-04-28T13:49:00Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	153	140	1.09:1
BoxMinimalPerf.default	290	272	1.07:1
PortalMinimalPerf.default	146	137	1.07:1
AttachmentSlotsPerf.default	926	873	1.06:1
AvatarMinimalPerf.default	168	160	1.05:1
RefMinimalPerf.default	200	191	1.05:1
CardMinimalPerf.default	466	447	1.04:1
ChatWithPopoverPerf.default	327	314	1.04:1
DropdownManyItemsPerf.default	570	550	1.04:1
LayoutMinimalPerf.default	299	288	1.04:1
ButtonMinimalPerf.default	137	133	1.03:1
ButtonSlotsPerf.default	461	449	1.03:1
LabelMinimalPerf.default	319	309	1.03:1
PopupMinimalPerf.default	526	510	1.03:1
CarouselMinimalPerf.default	397	390	1.02:1
DialogMinimalPerf.default	642	628	1.02:1
DropdownMinimalPerf.default	2601	2561	1.02:1
FlexMinimalPerf.default	236	231	1.02:1
HeaderSlotsPerf.default	633	623	1.02:1
ListCommonPerf.default	534	526	1.02:1
ListWith60ListItems.default	558	547	1.02:1
LoaderMinimalPerf.default	574	565	1.02:1
MenuMinimalPerf.default	717	705	1.02:1
ProviderMergeThemesPerf.default	1061	1039	1.02:1
SliderMinimalPerf.default	1414	1391	1.02:1
IconMinimalPerf.default	508	498	1.02:1
AlertMinimalPerf.default	222	220	1.01:1
AttachmentMinimalPerf.default	124	123	1.01:1
ChatMinimalPerf.default	623	615	1.01:1
CheckboxMinimalPerf.default	2286	2270	1.01:1
DatepickerMinimalPerf.default	4866	4822	1.01:1
FormMinimalPerf.default	332	330	1.01:1
GridMinimalPerf.default	276	273	1.01:1
ImageMinimalPerf.default	297	294	1.01:1
ItemLayoutMinimalPerf.default	994	983	1.01:1
MenuButtonMinimalPerf.default	1430	1410	1.01:1
ReactionMinimalPerf.default	301	298	1.01:1
SegmentMinimalPerf.default	285	283	1.01:1
SkeletonMinimalPerf.default	281	279	1.01:1
SplitButtonMinimalPerf.default	3676	3643	1.01:1
TableMinimalPerf.default	340	337	1.01:1
TextAreaMinimalPerf.default	397	392	1.01:1
ToolbarMinimalPerf.default	788	779	1.01:1
AccordionMinimalPerf.default	113	113	1:1
AnimationMinimalPerf.default	452	454	1:1
ButtonOverridesMissPerf.default	1253	1254	1:1
DividerMinimalPerf.default	292	291	1:1
EmbedMinimalPerf.default	3457	3466	1:1
HeaderMinimalPerf.default	292	291	1:1
InputMinimalPerf.default	1099	1096	1:1
ListMinimalPerf.default	418	419	1:1
ProviderMinimalPerf.default	331	330	1:1
RadioGroupMinimalPerf.default	361	361	1:1
TableManyItemsPerf.default	1617	1609	1:1
CustomToolbarPrototype.default	2264	2272	1:1
TooltipMinimalPerf.default	888	892	1:1
TreeMinimalPerf.default	677	680	1:1
StatusMinimalPerf.default	551	559	0.99:1
TextMinimalPerf.default	277	281	0.99:1
ChatDuplicateMessagesPerf.default	232	237	0.98:1
ListNestedPerf.default	447	457	0.98:1
VideoMinimalPerf.default	522	537	0.97:1
RosterPerf.default	882	957	0.92:1

fabricteam · 2022-04-28T13:50:17Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`73.754 kB` `22.494 kB`
`react-badge` Badge	`20.965 kB` `6.605 kB`
`react-badge` CounterBadge	`21.918 kB` `6.919 kB`
`react-badge` PresenceBadge	`22.005 kB` `6.582 kB`
`react-combobox` Combobox	`60.564 kB` `20.751 kB`
`react-divider` Divider	`15.455 kB` `5.57 kB`
`react-input` Input	`21.775 kB` `7.228 kB`
`react-label` Label	`8.441 kB` `3.541 kB`
`react-link` Link	`11.176 kB` `4.545 kB`
`react-positioning` usePopper	`23.21 kB` `8.084 kB`
`react-priority-overflow` hooks only	`10.792 kB` `4.125 kB`
`react-provider` FluentProvider	`14.079 kB` `5.274 kB`
`react-radio` Radio	`23.488 kB` `7.889 kB`
`react-radio` RadioGroup	`8.205 kB` `3.516 kB`
`react-spinbutton` SpinButton	`41.955 kB` `11.856 kB`
`react-spinner` Spinner	`17.224 kB` `5.856 kB`
`react-switch` Switch	`24.333 kB` `8.019 kB`
`react-text` Text - Default	`10.867 kB` `4.269 kB`
`react-text` Text - Wrappers	`14.183 kB` `4.61 kB`
`react-textarea` Textarea	`20.672 kB` `7.07 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.098 kB` `6.657 kB`
`react-theme` Teams: Light theme	`18.632 kB` `5.317 kB`
`react-tooltip` Tooltip	`42.907 kB` `14.761 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against f8b29e77dbcc19f83896c910464c33346a2d5ace}

fabricteam · 2022-04-28T13:51:39Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	789	793	5000
Breadcrumb	mount	2278	2277	1000
Checkbox	mount	1253	1259	5000
CheckboxBase	mount	1077	1061	5000
ChoiceGroup	mount	3940	3921	5000
ComboBox	mount	774	825	1000
CommandBar	mount	8794	9214	1000
ContextualMenu	mount	9258	9196	1000
DefaultButton	mount	946	964	5000
DetailsRow	mount	3073	3027	5000
DetailsRowFast	mount	3096	3079	5000
DetailsRowNoStyles	mount	2879	2914	5000
Dialog	mount	1847	1853	1000
DocumentCardTitle	mount	146	151	1000
Dropdown	mount	2790	2802	5000
FocusTrapZone	mount	1475	1573	5000
FocusZone	mount	1530	1540	5000
IconButton	mount	1394	1429	5000
Label	mount	325	322	5000
Layer	mount	2550	2563	5000
Link	mount	431	434	5000
MenuButton	mount	1217	1211	5000
MessageBar	mount	1903	1848	5000
Nav	mount	2648	2630	1000
OverflowSet	mount	1003	992	5000
Panel	mount	1806	1840	1000
Persona	mount	841	849	1000
Pivot	mount	1140	1129	1000
PrimaryButton	mount	1084	1080	5000
Rating	mount	6624	6753	5000
SearchBox	mount	1112	1120	5000
Shimmer	mount	2212	2212	5000
Slider	mount	1664	1682	5000
SpinButton	mount	3952	3982	5000
Spinner	mount	407	408	5000
SplitButton	mount	2486	2502	5000
Stack	mount	504	500	5000
StackWithIntrinsicChildren	mount	1876	1868	5000
StackWithTextChildren	mount	4635	4658	5000
SwatchColorPicker	mount	9028	9117	5000
TagPicker	mount	2011	2008	5000
TeachingBubble	mount	72179	70201	5000
Text	mount	399	404	5000
TextField	mount	1192	1172	5000
ThemeProvider	mount	942	959	5000
ThemeProvider	virtual-rerender	593	605	5000
ThemeProvider	virtual-rerender-with-unmount	1440	1415	5000
Toggle	mount	722	714	5000
buttonNative	mount	103	100	5000

Hotell

bellisima

…s subfolder (microsoft#22692) * move react-card * move react-dialog * move react-image * Change Files * fix codeowners

TristanWatanabe added 5 commits April 28, 2022 06:20

move react-card

d2b0252

move react-dialog

5085865

move react-image

04121ce

Change Files

bb2c5ed

fix codeowners

40d48ae

TristanWatanabe requested review from a team, JustSlone and jurokapsiar as code owners April 28, 2022 13:29

msft-fluent-ui-bot assigned miroslavstastny Apr 28, 2022

TristanWatanabe mentioned this pull request Apr 28, 2022

group vNext to common folder (as people will start check vNext) #22427

Closed

23 tasks

TristanWatanabe assigned TristanWatanabe and unassigned miroslavstastny Apr 28, 2022

TristanWatanabe added the Area: Build System label Apr 28, 2022

Hotell approved these changes Apr 28, 2022

View reviewed changes

TristanWatanabe merged commit b8dde55 into microsoft:master Apr 28, 2022

TristanWatanabe deleted the move-cxe-prg-pkgs-batch-1 branch April 28, 2022 17:40

This was referenced Apr 29, 2022

fix(react-card): change storybook asset url #22713

Merged

fix(react-card): add react-components to vr-tests asset path #22785

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(chore) Move react-card, react-dialog, react-image to react-components subfolder #22692

(chore) Move react-card, react-dialog, react-image to react-components subfolder #22692

Uh oh!

TristanWatanabe commented Apr 28, 2022

Uh oh!

codesandbox-ci bot commented Apr 28, 2022

Uh oh!

fabricteam commented Apr 28, 2022

Uh oh!

size-auditor bot commented Apr 28, 2022

Uh oh!

fabricteam commented Apr 28, 2022

Uh oh!

fabricteam commented Apr 28, 2022

Uh oh!

fabricteam commented Apr 28, 2022

Uh oh!

Hotell left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

(chore) Move react-card, react-dialog, react-image to react-components subfolder #22692

(chore) Move react-card, react-dialog, react-image to react-components subfolder #22692

Uh oh!

Conversation

TristanWatanabe commented Apr 28, 2022

Changes

Related Issue(s)

Uh oh!

codesandbox-ci bot commented Apr 28, 2022

Uh oh!

fabricteam commented Apr 28, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor bot commented Apr 28, 2022

Asset size changes

Uh oh!

fabricteam commented Apr 28, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Apr 28, 2022

📊 Bundle size report

Uh oh!

fabricteam commented Apr 28, 2022

Perf Analysis (@fluentui/react)

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)