Skip to content

fix(react-radio): Allow data argument on onChange #22753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miroslavstastny merged 2 commits into from
May 3, 2022
Merged

fix(react-radio): Allow data argument on onChange #22753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6482546
fix(react-radio): Allow data argument on onChange
miroslavstastny May 2, 2022
6f7edfc
changefile
miroslavstastny May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-radio-eec73af1-4507-40ff-990d-62a0622eddeb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Allow data argument on onChange",
"packageName": "@fluentui/react-radio",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-radio/etc/react-radio.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export type RadioOnChangeData = {
};

// @public
export type RadioProps = Omit<ComponentProps<Partial<RadioSlots>, 'input'>, 'size'> & {
export type RadioProps = Omit<ComponentProps<Partial<RadioSlots>, 'input'>, 'onChange' | 'size'> & {
value?: string;
labelPosition?: 'after' | 'below';
disabled?: boolean;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-radio/src/components/Radio/Radio.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export type RadioSlots = {
/**
* Radio Props
*/
export type RadioProps = Omit<ComponentProps<Partial<RadioSlots>, 'input'>, 'size'> & {
export type RadioProps = Omit<ComponentProps<Partial<RadioSlots>, 'input'>, 'onChange' | 'size'> & {
Copy link
Member Author

@miroslavstastny miroslavstastny May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is supposed to be consistent with InputProps in react-input.

/**
* The value of the RadioGroup when this Radio item is selected.
*/
Expand Down