-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(react-radio): Allow data argument on onChange #22753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-radio): Allow data argument on onChange #22753
Conversation
| * Radio Props | ||
| */ | ||
| export type RadioProps = Omit<ComponentProps<Partial<RadioSlots>, 'input'>, 'size'> & { | ||
| export type RadioProps = Omit<ComponentProps<Partial<RadioSlots>, 'input'>, 'onChange' | 'size'> & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach is supposed to be consistent with InputProps in react-input.
|
@micahgodbolt - you are helping out with radio and checkbox right? If so, you should review too :) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6f7edfc:
|
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1115 | 1121 | 5000 | |
| Button | mount | 679 | 676 | 5000 | |
| FluentProvider | mount | 2267 | 2259 | 5000 | |
| FluentProviderWithTheme | mount | 331 | 340 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 293 | 295 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 369 | 343 | 10 | |
| MakeStyles | mount | 1848 | 1848 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 55e2b1b53e81efa510a5bc15c6ab0398b52ace7f (build) |
* fix(react-radio): Allow data argument on onChange * changefile
Current Behavior
Radio.onChange(event, data)results in typescript error,dataargument is not allowed:New Behavior
Radio.onChangenow has two arguments -eventanddata.Related Issue(s)
Fixes #22752