Skip to content

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Apr 12, 2022

Current Behavior

After introduction of new issue templates there is lot of churn in the issue crossorads

image

New Behavior

Easy to navigate issue crossroad for contributors

image

Related Issue(s)

Follows #22337

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 620ee5e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 12, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 65897f7924362a8c8bf581ddca162c8ed4247011 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 906 923 5000
Button mount 588 533 5000
FluentProvider mount 1768 1757 5000
FluentProviderWithTheme mount 263 248 10
FluentProviderWithTheme virtual-rerender 217 214 10
FluentProviderWithTheme virtual-rerender-with-unmount 285 274 10
MakeStyles mount 1672 1636 50000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
priority-overflow
createOverflowManager
2.836 kB
1.209 kB
react-accordion
Accordion (including children components)
74.792 kB
22.516 kB
react-avatar
Avatar
45.142 kB
13.111 kB
react-badge
Badge
20.895 kB
6.567 kB
react-badge
CounterBadge
21.848 kB
6.883 kB
react-badge
PresenceBadge
21.951 kB
6.565 kB
react-button
Button
28.013 kB
8.059 kB
react-button
CompoundButton
33.508 kB
9.092 kB
react-button
MenuButton
29.796 kB
8.665 kB
react-button
SplitButton
36.268 kB
9.863 kB
react-button
ToggleButton
37.395 kB
8.68 kB
react-card
Card - All
53.619 kB
15.372 kB
react-card
Card
48.904 kB
14.089 kB
react-card
CardFooter
7.686 kB
3.264 kB
react-card
CardHeader
9.251 kB
3.78 kB
react-card
CardPreview
7.658 kB
3.291 kB
react-combobox
Combobox
54.566 kB
18.884 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
176.089 kB
49.113 kB
react-components
react-components: FluentProvider & webLightTheme
32.601 kB
10.668 kB
react-divider
Divider
15.385 kB
5.539 kB
react-image
Image
10.109 kB
3.958 kB
react-input
Input
21.661 kB
7.18 kB
react-label
Label
8.371 kB
3.504 kB
react-link
Link
11.106 kB
4.507 kB
react-menu
Menu (including children components)
105.852 kB
32.433 kB
react-menu
Menu (including selectable components)
109.031 kB
32.897 kB
react-popover
Popover
96.787 kB
29.559 kB
react-portal
Portal
6.272 kB
2.17 kB
react-positioning
usePopper
23.21 kB
8.084 kB
react-priority-overflow
hooks only
10.606 kB
4.087 kB
react-provider
FluentProvider
14.009 kB
5.25 kB
react-select
Select
16.562 kB
6.264 kB
react-slider
Slider
25.549 kB
8.25 kB
react-spinbutton
SpinButton
41.512 kB
11.912 kB
react-spinner
Spinner
16.459 kB
5.549 kB
react-switch
Switch
24.279 kB
8.001 kB
react-text
Text - Default
10.797 kB
4.233 kB
react-text
Text - Wrappers
14.113 kB
4.576 kB
react-textarea
Textarea
20.602 kB
7.033 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.676 kB
6.604 kB
react-theme
Teams: Light theme
18.492 kB
5.296 kB
react-tooltip
Tooltip
42.837 kB
14.727 kB
react-utilities
SSRProvider
189 B
161 B
🤖 This report was generated against 65897f7924362a8c8bf581ddca162c8ed4247011

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderSlotsPerf.default 637 545 1.17:1
FormMinimalPerf.default 331 286 1.16:1
ImageMinimalPerf.default 304 261 1.16:1
ButtonSlotsPerf.default 459 398 1.15:1
FlexMinimalPerf.default 230 204 1.13:1
GridMinimalPerf.default 283 252 1.12:1
LayoutMinimalPerf.default 292 261 1.12:1
ReactionMinimalPerf.default 304 272 1.12:1
DropdownManyItemsPerf.default 566 512 1.11:1
ListMinimalPerf.default 417 382 1.09:1
AlertMinimalPerf.default 215 201 1.07:1
ProviderMinimalPerf.default 306 287 1.07:1
ChatMinimalPerf.default 609 572 1.06:1
SplitButtonMinimalPerf.default 3496 3298 1.06:1
StatusMinimalPerf.default 513 483 1.06:1
ButtonMinimalPerf.default 139 132 1.05:1
ButtonOverridesMissPerf.default 1219 1157 1.05:1
ChatDuplicateMessagesPerf.default 242 230 1.05:1
DividerMinimalPerf.default 265 253 1.05:1
MenuMinimalPerf.default 670 638 1.05:1
ToolbarMinimalPerf.default 724 695 1.04:1
VideoMinimalPerf.default 498 478 1.04:1
CardMinimalPerf.default 468 455 1.03:1
RefMinimalPerf.default 200 195 1.03:1
SkeletonMinimalPerf.default 285 278 1.03:1
DialogMinimalPerf.default 642 630 1.02:1
InputMinimalPerf.default 1081 1062 1.02:1
SegmentMinimalPerf.default 251 247 1.02:1
CustomToolbarPrototype.default 2151 2106 1.02:1
AnimationMinimalPerf.default 457 453 1.01:1
BoxMinimalPerf.default 278 275 1.01:1
MenuButtonMinimalPerf.default 1392 1381 1.01:1
PopupMinimalPerf.default 507 500 1.01:1
RadioGroupMinimalPerf.default 369 366 1.01:1
TextMinimalPerf.default 279 277 1.01:1
TextAreaMinimalPerf.default 408 402 1.01:1
AttachmentSlotsPerf.default 861 865 1:1
HeaderMinimalPerf.default 260 259 1:1
ListWith60ListItems.default 491 493 1:1
LoaderMinimalPerf.default 503 503 1:1
AttachmentMinimalPerf.default 113 114 0.99:1
AvatarMinimalPerf.default 154 155 0.99:1
CarouselMinimalPerf.default 339 341 0.99:1
ChatWithPopoverPerf.default 313 317 0.99:1
ListNestedPerf.default 436 442 0.99:1
ProviderMergeThemesPerf.default 1050 1061 0.99:1
SliderMinimalPerf.default 1387 1398 0.99:1
DropdownMinimalPerf.default 2459 2500 0.98:1
LabelMinimalPerf.default 272 277 0.98:1
IconMinimalPerf.default 435 444 0.98:1
RosterPerf.default 836 862 0.97:1
TooltipMinimalPerf.default 832 856 0.97:1
TreeMinimalPerf.default 647 665 0.97:1
TableManyItemsPerf.default 1530 1601 0.96:1
EmbedMinimalPerf.default 3185 3338 0.95:1
PortalMinimalPerf.default 134 141 0.95:1
TreeWith60ListItems.default 124 130 0.95:1
DatepickerMinimalPerf.default 4338 4616 0.94:1
CheckboxMinimalPerf.default 2018 2177 0.93:1
ItemLayoutMinimalPerf.default 891 971 0.92:1
TableMinimalPerf.default 296 331 0.89:1
ListCommonPerf.default 464 530 0.88:1
AccordionMinimalPerf.default 104 124 0.84:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1030 1003 5000
Breadcrumb mount 2863 2992 1000
Checkbox mount 1655 1659 5000
CheckboxBase mount 1376 1405 5000
ChoiceGroup mount 5145 5166 5000
ComboBox mount 1047 1077 1000
CommandBar mount 10856 11371 1000
ContextualMenu mount 11534 11622 1000
DefaultButton mount 1255 1253 5000
DetailsRow mount 4158 4058 5000
DetailsRowFast mount 4143 4173 5000
DetailsRowNoStyles mount 4082 3944 5000
Dialog mount 2427 2377 1000
DocumentCardTitle mount 180 201 1000
Dropdown mount 3606 3647 5000
FocusTrapZone mount 1947 1886 5000
FocusZone mount 1870 1896 5000
IconButton mount 1928 1932 5000
Label mount 362 393 5000
Layer mount 3172 3195 5000
Link mount 527 502 5000
MenuButton mount 1654 1656 5000
MessageBar mount 2198 2183 5000
Nav mount 3664 3662 1000
OverflowSet mount 1152 1167 5000
Panel mount 2342 2326 1000
Persona mount 1083 1076 1000
Pivot mount 1506 1571 1000
PrimaryButton mount 1449 1468 5000
Rating mount 8783 8541 5000
SearchBox mount 1445 1458 5000
Shimmer mount 2769 2739 5000
Slider mount 2080 2084 5000
SpinButton mount 5469 5380 5000
Spinner mount 453 448 5000
SplitButton mount 3408 3430 5000
Stack mount 550 581 5000
StackWithIntrinsicChildren mount 2649 2611 5000
StackWithTextChildren mount 5921 5895 5000
SwatchColorPicker mount 12386 12603 5000
TagPicker mount 2939 2932 5000
TeachingBubble mount 89269 90133 5000
Text mount 487 474 5000
TextField mount 1547 1541 5000
ThemeProvider mount 1264 1264 5000
ThemeProvider virtual-rerender 665 677 5000
ThemeProvider virtual-rerender-with-unmount 2024 2042 5000
Toggle mount 861 908 5000
buttonNative mount 135 146 5000

@Hotell Hotell merged commit dca2e94 into microsoft:master Apr 18, 2022
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants