Overflow set by micahgodbolt · Pull Request #1537 · microsoft/fluentui

micahgodbolt · 2017-04-17T21:49:32Z

Pull request checklist

New Overflow Set component

dzearing

various

dzearing · 2017-04-18T16:46:41Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.Props.ts

+   * Method to call when trying to render an item.
+   * If item contains an onRender, that function will be used instead.
+  */
+  onRenderItem?: (item?: any, index?: number) => React.ReactNode;


Should this use an IRenderFunction?

There is no default internal function, so is there any need for IRenderFunction?

guess i can use it anyway. Done.

dzearing · 2017-04-18T16:48:22Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+    return (
+      <IconButton
+        icon={ iconProps.iconName }
+        menuIconName='none'


icon and menuIconName is deprecated. You should be seeing warnings in your console after merging.

yup, changed this prop to full iconprops in anticipation of this.

dzearing · 2017-04-18T16:49:36Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+    let { items, overflowItems } = this.props;
+    return (
+      <FocusZone direction={ FocusZoneDirection.horizontal } role='menubar' >
+        <div className={ css('ms-OverflowSet', styles.root) } >


You can put the className on the FocusZone, which renders a div, to avoid the extra unnecessary div.

dzearing · 2017-04-18T16:49:45Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+
+export class OverflowSet extends BaseComponent<IOverflowSetProps, null> {
+
+  constructor(props: IOverflowSetProps) {


no need for constructor.

dzearing · 2017-04-18T16:52:49Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+        <div
+          className={ css('ms-OverflowSet-item', styles.item) }
+          key={ key }
+          ref={ key } >


ref is not needed...

dzearing · 2017-04-18T16:53:03Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSetPage.tsx

+          </div>
+        }
+        bestPractices={
+          <div></div>


dzearing · 2017-04-18T16:53:46Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+      <FocusZone direction={ FocusZoneDirection.horizontal } role='menubar' >
+        <div className={ css('ms-OverflowSet', styles.root) } >
+          { items && this._onRenderItems(items) }
+          { overflowItems && this._onRenderOverflowButton(overflowItems) }


if overflowItems is an empty array, you still render the button...

so .length instead?

dzearing · 2017-04-18T16:55:00Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+    iconProps.iconName = iconProps.iconName ? iconProps.iconName : 'More';
+    return (
+      <IconButton
+        icon={ iconProps.iconName }


this iconbutton has no styling. shouldn't it be 100% height of the parent?

…-ui-fabric-react into overflow-set

micahgodbolt · 2017-04-18T18:33:20Z

@dzearing covered everything you mentioned. Would love to get generic types working here too.

micahgodbolt · 2017-04-21T15:49:00Z

@dzearing are we going to work on type safety here before merging, or come back to that later? I.E. what next for this PR?

dzearing · 2017-04-25T18:01:59Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.scss

+  flex-wrap: nowrap;
+}
+
+


dzearing · 2017-04-25T18:06:43Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+  private _onRenderItems(items) {
+    return items.map((item, i) => {
+      let key = item.key ? item.key : i;
+      let onRender = item.onRender ? item.onRender : this.props.onRenderItem;


This won't work;

onRender has a signature (item) => JSX.Element
onRenderItem has a signature (props, defaultRender) => JSX.element

Youre passing item and index, which satisfies neither.

dzearing · 2017-04-25T18:10:08Z

...ges/office-ui-fabric-react/src/components/OverflowSet/examples/OverflowSet.Basic.Example.tsx

+/* tslint:enable:no-unused-variable */
+import { BaseComponent } from 'office-ui-fabric-react/lib/Utilities';
+import { PrimaryButton } from 'office-ui-fabric-react/lib/Button';
+import { DefaultButton } from 'office-ui-fabric-react/lib/Button';


you can collapse these two

dzearing · 2017-04-25T18:13:45Z

packages/office-ui-fabric-react/src/components/OverflowSet/index.ts

@@ -0,0 +1,2 @@
+export * from './OverflowSet';


don't add this here until we're using it and happy with it.

dzearing · 2017-04-25T18:15:40Z

...ges/office-ui-fabric-react/src/components/OverflowSet/examples/OverflowSet.Basic.Example.tsx

+import { DefaultButton } from 'office-ui-fabric-react/lib/Button';
+import {
+  OverflowSet
+} from '../index';


examples should have imports that the user would do...

cschleiden · 2017-04-27T23:03:17Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSetPage.tsx

+        overview={
+          <div>
+            <p>
+              The Overflow Set component is a flexible container component that is usefull for displaying a primary set of content with additional content in an overflow callout.


cschleiden · 2017-04-27T23:03:24Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSetPage.tsx

+        overview={
+          <div>
+            <p>
+              The Overflow Set component is a flexible container component that is usefull for displaying a primary set of content with additional content in an overflow callout.


OverflowSet ?

dzearing · 2017-04-28T00:43:41Z

packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx

+export class BaseButton extends BaseComponent<IButtonProps, IBaseButtonState> implements IButton {

-  public static defaultProps: IBaseButtonProps = {
+  public static defaultProps: IButtonProps = {


I just realized this is a really bad contract; for example, it is unclear from a user how to define the color on an icon that is disabled. We need to tweak this a bit.

Can we hold off adding something that would be deprecated fast just for a sec? Sorry, know this has been a long time.

So no exposing of the IButtonClassNames or any of that? Revert all the changes on the button files?

christiango · 2017-04-28T16:46:50Z

packages/office-ui-fabric-react/src/components/Button/Button.Props.ts

 }
+
+export interface IButtonClassNames {
+  base?: string;


We should add some comments here saying what the class names correspond to so that consumers know what class names to override when customizing button styles

christiango · 2017-04-28T16:54:23Z

packages/office-ui-fabric-react/src/components/Button/CommandButton/CommandButton.tsx

      <BaseButton
-        classNames={ CLASS_NAMES }
+        { ...this.props }
+        classNames={ assign({}, CLASS_NAMES, this.props.classNames) }


Can we use the spread operator here instead of assign?

The assign is to allow prop classnames to override the button specific class names. i.e. I want a new .isEnabled:hover style, I can override their isEnabled with my own. And since it's css modules, even if I use the same isEnabled class name, the hash will be different.

That should still work with object spread though. They are equivalent and is more compact: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-1.html

It would be something like this classNames = { ...CLASS_NAMES, ..this.props.classNames }

Pulled this out. @dzearing is doing this using glamor, and yes, spreads.

christiango · 2017-04-28T16:57:12Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.Props.ts

+  /**
+   * An array of items to be passed to overflow contextual menu
+  */
+  overflowItems?: IContextualMenuItem[];


Why are the types different items vs overflow items?

OverflowItems are meant to be rendered in a contextual menu. Of course there isn't anything stopping someone from rendering them in something else....If any[] is prefered I have no problems either way.

I think contextualmenuitem already has a mechanism to render anything else inside them, so I think it is ok.

christiango · 2017-04-28T17:24:25Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+  private _onRenderItems(items: any[]): JSX.Element[] {
+    return items.map((item, i) => {
+      return (
+        <div key={ i } className={ css('ms-OverflowSet-item', styles.item) }>


This isn't a great way to assign keys since it wouldn't let React's reconciler detect reorderings and insertions/deletions. More details can be found here https://facebook.github.io/react/docs/lists-and-keys.html

Can we provide a way for the consumer to pass in a unique identifier for each item?

Yeah, i think I originally had that in the map. Let me put it back in. Look for a key and fall back to i if there is no key.

christiango · 2017-04-28T17:28:43Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+    return (
+      <FocusZone className={ css('ms-OverflowSet', styles.root) } direction={ FocusZoneDirection.horizontal } role='menubar' >
+        { items && this._onRenderItems(items) }
+        { overflowItems.length && onRenderOverflowButton(overflowButtonProps) }


No default value here?

What do you mean by default value?

For the onrenderoverflowbutton? I guess it makes sense given your other comment regarding how overflow items are rendered.

Yeah, i had a default button at one time, but what does the button look like? Hover/active/selected? I'm expecting each user will customize the button to their use case. A default button wouldn't serve much purpose unless we determined what the default usecase was.

Seems reasonable, we can add it later if there is a "common" button that arises

christiango · 2017-04-28T17:32:08Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.Props.ts

+  /**
+   * Rendering method for overflow button and contextual menu.
+  */
+  onRenderOverflowButton: IRenderFunction<IButtonProps>;


I'm a little unsure about this API. We definitely want to be able to provide flexibility for rendering the overflow button, but it seems like we would have an onRenderMenuItem function for handling items in the contextual menu

The rendering of the menu items is already handled by the contextual menu. and in fact IContextualMenuItem can accept an onRender function already.

Ah I see. I guess I was expecting the API to list "top level controls" and "overflow controls" in a similar manner. But given the existing mechanism for overriding menu items in contextualmenuitem, this seems to make sense and also allows customization of the button itself.

christiango · 2017-04-28T17:33:34Z

...ges/office-ui-fabric-react/src/components/OverflowSet/examples/OverflowSet.Basic.Example.tsx

+      <OverflowSet
+        items={ [
+          {
+            key: 'item1',


How come these aren't being used in the overflow set?

christiango · 2017-04-30T05:37:22Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.tsx

+  @autobind
+  private _onRenderItems(items: any[]): JSX.Element[] {
+    return items.map((item, i) => {
+      let key = item.key ? item.key : i;


The props definition should say that items can take a key. It might even be worth explicitly stating this in the type definition instead of just putting any (though not sure how to best do that, maybe an intersection type?

I can do this in the prop items?: any[] | { key: string }[];

Not sure if this really solves it though. Basically it's either anything, or just a key. Unless I don't understand intersection properly.

You actually probably don't need an intersection, you can just say items?: {key?: string} []. You can assign anything to that.

items?: {key?: string} [] would mean that [{key: foo, bar: baz}] would be invalid. I can either specify no props or all of the props.

…-ui-fabric-react into overflow-set

micahgodbolt · 2017-05-01T19:53:41Z

@dzearing i THINK i'm 100% set. Give me a thumbs up if you want me to merge it in.

christiango · 2017-05-02T00:01:43Z

It looks good to me, I think a quick cleanup of the items type to get rid of the pesky any would be great.

christiango · 2017-05-02T00:02:31Z

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.Props.ts

+  /**
+   * An array of items to be rendered by your onRenderItem function in the primary content area
+  */
+  items?: any[] | IObjectWithKey[];


I think all you want here is { id? : string}[]

cschleiden · 2017-05-02T02:09:31Z

Why didn't we go with the IProps<TItem = any> approach?

…c-react

cschleiden · 2017-05-03T17:50:56Z

common/changes/master_2017-05-02-22-52.json

      "packageName": "office-ui-fabric-react",
      "comment": "Dropdown: New placeHolder text feature allows dropdown to act more like a traditional input field",
      "type": "minor"
+<<<<<<< HEAD


unresolved merge?

@cschleiden

* Add aria labels for Calendar items * Add change file * support onRender * Added change file * fix build error * address comments * text field semantic slots first draft * Check for Intl API method existence * input field semantics draft * rename generic input category to more specific field category * remove commented code * add rush change file * Initial checkin for @uifabric/styling package (microsoft#1558) * Updates to button. * Updating all buttons. * More button updates. * Moving customizable utilities. * Merge fixes. * Replacing all usages of Button in examples with the appropriate BaseButton variant. * Reverting command button example * Re-adding deprecationMap as a parameter. * Reverting one change because of a cyclic versioning issue. * Fixing lint error. * Adding style package. * Adding animations and icons. * Fixing * Fixing. * Updates, adding classes and animation pages. * Refactored animation page. * Adding theming and all the color classes. * Updating icons to be exported as separate consts. * Updates for lint and gulp. * Updating based on PR feedback. * Updating rush, variety of things in the styling package. * Adding change file. * Removing unnecessary space. * Updating change file, removing unneceessary changes. * Removing yarn lock. * Update package.json * Update package.json * Update package.json * Update package.json * Applying package updates. * Modal: Remove Fabric Core dep by moving to local transitions. (microsoft#1567) * Converted Modal to interal transition so remove core dependency * Change file * Update Modal.scss * Update Modal.tsx * Fixed tests and pulled in animation timing value * Update Modal.tsx * microsoft#1302 Callout: Allow callout to specify background color (microsoft#1403) * microsoft#1302 Callout: Allow callout to specify beak background color * microsoft#1302 Add changes description * Callout: Allow Callout to specify background color. * microsoft#1302 Add change description * microsoft#1302 remove earlier change description * microsoft#1302 add backgroundColor props comment * clean up a todo * make focus async to get rid of sync focus in detailsList (microsoft#1193) * make focus async to get rid of sync focus * change back to setTimeout * rush change * rush change * Update zhiliu-reduceFocusCost_2017-04-21-22-11.json * fix test failure * Remove logos for Fabric JS & Angular project and bring down to same line as iOS project * Searchbox: Fixes for IE11 keystroke miss + flex overflow (microsoft#1583) * Searchbox: Fixes for IE11 key stroke misses and overflow styling * change log * minor fix * Edge doesn't understand flex-basis: 0% * The 'npm start' command now works when adding/removing css classes. (microsoft#1576) * Updates to how we import the styles so that typescript doesn't get confused when classes are added or removed. * Removing unnecessary change. * Message bar mouse events (microsoft#1585) * Fixed pseudo element blocking links in message bars * Added change file * Moved the content attribute into media query so that pseudo element only displays in MQ * microsoft#1097-- DropDown: Adds require to DropDown when required, and adds error message property/state * microsoft#1097-- DropDown: Adds require to DropDown when required, and adds error message property/state * microsoft#1097-- DropDown: removes MessageBox + change file + ScreenShot * microsoft#1097-- DropDown: revises error state per designer feedback * microsoft#1097-- lint * microsoft#1097-- PR feedback, removing dup change file, removing test values * Panel left shadow (microsoft#1586) * Add proper shadow for left hand panel * Add change file * microsoft#1097-- Fix for UnitTests, checking if errorMessage is null. * Applying package updates. * Added focus zone around navigation to make it more keyboard accessible (microsoft#1596) * Added focus zone around navigation to make it more keyboard accessible * Remove ref and change role to menu * removed redundant role attribute * Dropdown: Fix for ellipsis for dropdown items with long strings (microsoft#1589) * Dropdown: Fix for overflow in dropdown * Dropdown: Fix for overflow * Dropdown: Fix for overflow * Dropdown: Fix for overflow * Update dropDownOverlow_2017-04-24-23-48.json * semantic slotify the toggle control * semantic slot-ify radio buttons, border colors are different * Applying package updates. * Show tooltip only on overflow (microsoft#1444) * TooltipHost: Enable showing tooltip only on overflow * Add overflow mode property * Remove redundant code * Fix bad merge (microsoft#1626) * TextField: Convert to flexbox, support addons (microsoft#1574) * Init textfield flexbox updates * Add changefile * Reduced text padding to 1px * Updated docs and fixed linting errors * Fixed caps of Utilities * Fixed icons in multi line * Update TextField.Basic.Example.tsx * Added type to onRender method and fixed hex colors * Removed icon exampe in textfield * People picker edge keyboarding (microsoft#1496) * Adding vertical-align and horizontal only keyboarding to the member list people picker focus zone. * Rush change. * Using FocusZoneDirection enum instead of just the number. * Removing horizontal only param from the member list people picker focus zone. * Use overflow-wrap: break-word instead of word-break: break-all in tooltips, labels and dropdowns (microsoft#1630) * Use overflow-wrap: break-word instead of word-break: break-all in tooltips. Fix microsoft#1627 * Apply word wrapping fixes to other components. * Add fixes keyword to pull request tempmlate * Support auto-navigation to next previous month when selected date changes via props * Fix a few small bugs * change file * Applying package updates. * Updating website paths * Model the toggle control as a checkbox for more universal screen reader support. * Edge + Narrator and FireFox + NVDA have good support for aria-pressed and do not require this change. * JAWS and VoiceOver do not announce anything when aria-pressed changes, so they do not read anything when changing the toggle. * Fix build * Add change file * fix some Textfield bugs, wip * Update Calendar.Inline.Example.tsx * Feature/dropdown ax (microsoft#1625) * Fix some accessibility issues with Dropdown. Inspiration from the example on https://www.w3.org/TR/wai-aria/roles#combobox. * Make the menu be role="listbox" and items role="option" * Add aria-owns to the combobox * Fix aria labels on the items to fix JAWS + IE * Add change file * Fix lint error * Use ariaLabel in Panel and fix up/down keyboard nav for links in DetailsList. (microsoft#1645) * Update Fabric website version number (microsoft#1646) * Updated textfield examples fixes microsoft#1648 (microsoft#1649) * TooltipHost: Include aria-described (microsoft#1628) * Include aria-describedf by on tooltips * Patch notes * id * Condition describedby on visibility * read id from props * Update README.md (microsoft#1653) Minor spelling correction * Applying package updates. * Triple equals! * Re-committing triple equals * Fixing AMD dependency break introduced in 2.23.1. (microsoft#1656) * Fixing import. * Adding change file. * Update tooltiphost-fix_2017-04-28-17-38.json * Applying package updates. * remove a todo * update disabled colors * semantic slotify details list * add rush change file * Applying package updates. * Pivot: render headers only (microsoft#1438) * Pivot: new props headersOnly and getTabId. * New example for separate render of pivot content. * Describe change. * Fixed change description to be higher level. * Update Pivot.Separate.Example.tsx Fix linter error * Update Pivot.Separate.Example.tsx Make state private in pivot example to fix linter issues * Update Pivot.Separate.Example.tsx Undo last change * Declare state public. Should fix TSLint error in CI. * Bumping package dependencies. (microsoft#1671) * Bumping dependencies. * Fixing build errors. * Fixing urls. * Use TS 2.3.2 * withViewport: preserve forceUpdate on update loop. (microsoft#1657) * Fix issue with items not updating on first save * Touch file * Add changes file. Reverse touch. * Update jostrick-fix-viewport_2017-04-28-20-56.json * microsoft#1664 -- Panel: Close button, size, margin and container. Updated to … (microsoft#1668) * microsoft#1664 -- Panel: Close button, size, margin and container. Updated to match spec. * microsoft#1664 -- Rush Change * Update 1664_PanelCloseButton_2017-05-01-23-02.json * List: Correctly measure pages when using display: none. (microsoft#1582) * Prevent hidden measurements. This forces measurement to happen when page is displayed, so next pages will show up properly. This avoids that average gets distorted with zero values. * Added public patch description. * Callout: Support for aria role, label and description (microsoft#1622) * Callout: support for aria role, label and description * change log * Resolving CR comments * Update master_2017-04-27-00-31.json * Calendar: Support auto-navigation when selected date changes via props (microsoft#1632) * Support auto-navigation to next previous month when selected date changes via props * Fix a few small bugs * change file * Update Calendar.Inline.Example.tsx * Triple equals! * Re-committing triple equals * Update master_2017-04-27-00-31.json * ContextMenus: change to using semantic slots (microsoft#1658) * semantic slot-ify context menus * add rush change file * Applying package updates. * Ysliu/calendar aria label nit (microsoft#1676) * fix aria-label from 'next' to 'prev' * rush change * Update ysliu-Calendar-aria-label-nit_2017-05-02-11-44.json * TooltipHost: Add className and fix example button (microsoft#1675) * Fixed bug where props/state were passed in reverse order (microsoft#1679) * Fixed bug where props/state were passed in reverse order * Add change file * Applying package updates. * fix some color choices * Backing out typescript bump, reverting to 2.2.2, due to breaking changes we've found. (microsoft#1686) * Textfield text fixes (microsoft#1663) * Fixed input font * Fixed textfield bugs, fonts, focus * Change file * Applying package updates. * Regression Test: Tests updates (microsoft#1644) * trying * Delete try.ts * updates * RegressionTests: Toggle Tests * REgression Test: test class * Regression Tests: Helper class * RegressionTests: Class updates * Regression Test: Helper Class updates * Regression Tests: helper class updates * Regression Tests: Test Helper class updates * Regression Tests: Test Helper class updates * Regression Tests: Event function * updates * Regression Tests: Test helper functions * Regression Tests: Rush change * Regression Test: Helper function Updates * Regression Tests: linting error updates * Regression Tests: Test helper class * Regression Tests: Test helper functions * Regression Test: Test helper updates * Regression Test: Test helper updates * Regression test: Test helper updates * Regression Tes: test helper updates * Regression Tests: Dialog tests * Regression Tests: Updates * Regression Test: Test updates. * Regression Test: Test udpates * Regression Test: test updates * Regression test: test updates * Regression Test: test updates * Regression Test: Test updates * Regression Test: tests * Regression Test: Tests updates * Regression Test: Tooltip test updates * Regression Test: Toggle Test * Regression tests * Regression Tests * REgression Tests * Regression Tests * Regression Tests * Update visualTests_2017-04-27-23-02.json * Regression Tests * Regression Tests * Regression Test * Regression Test document update * Regression Test document update * Update Facepile.Props.ts * Update visualTests_2017-04-27-23-02.json * Dropdown placeholder text (microsoft#1684) * Updated dropdown to have defaultText * Added change file * Update master_2017-05-02-22-52.json * Update Dropdown.Props.ts * Update Dropdown.tsx * Update Dropdown.Basic.Example.tsx * Dropdown: Tab should close dropdown and tab to next item in tab order * Added change file * Revert "Dropdown: Tab should close dropdown and tab to next item in tab order" This reverts commit 7d2c336. * Revert "Added change file" This reverts commit eb22bf9. * ContextMenu: give disabled text its own slot (microsoft#1682) * semantic slot-ify context menus * add rush change file * fix potential bug * add rush change file * remove old rush change file * Overflow set (microsoft#1537) * Copy Overflow Code into branch * Adding focus zone around overflow set * Updated docs and icon props * Adding change file * Update OverflowSet.Props.ts * Improve prop comments * Fixed a few PR requests * Fixed overflow icon styles * Created an IOverflowItemProps * Updated buttons to accept ClassNames, changed overflowset to use default button, exposed onRenderOverflowButton * Updated example to be more actual use case * Removed default overflow button render as each one will certainly be custom styled. updated docs * Fixed linting errors * Changed onRenderOverfowButton to be of type IButtonProps for better consistency * Update button assign to mix props into empty object * Moved custom onRender to the custom example. Created basic example with just some links * Moved class props into button props file * Commented out overflow set index.ts to keep hidden for now * Fix documentation and added key back to onRenderItems * Fixed linting errors * Revert button changes * updated example and items type * Updated dropdown to have defaultText * Added change file * Update master_2017-05-02-22-52.json * Dropdown: Tab should close dropdown and tab to next item in tab order (microsoft#1691) * Dropdown: Tab should close dropdown and tab to next item in tab order * Added change file * this places the aria label on the menu div as asked by some vendors d… (microsoft#1694) * this places the aria label on the menu div as asked by some vendors doing accessibility testing * added change file * DetailList: Add aria-rowcount and aria-colcount (microsoft#1667) * added aria-rowindex, colindex, rowcount and colcount properties in hope of resolving some accessibility issues * change file * Update users-petdun-gridAriaProperties_2017-05-01-21-52.json * respond to @cschleiden feedback * added null guard for adjusted columns * Fix native types (microsoft#1692) * Remove label from native properties. * Add change file. * Fix textfield test * fix tslint errors * Applying package updates. * Pivot: increased specificty to fix button styles overriding pivot styles (microsoft#1711) * Pivot: increased specificty to fix button styles overriding pivot styles * Adding change file * Fix broken links to PDFs on color and brand icon pages (microsoft#1712) * Re-enabling SSR tests, fixing SSR issues, removing deprecations (microsoft#1710) * Re-enabling SSR tests, fixing SSR issues. * Adding change file. * Removing debugger statements. * removing fsevents. * Pass in new props to _getWeeks so it properly renders when new date range type or first day of week values are passed in * Fixed persona size 28 initials size (microsoft#1715) * Fixed persona size 28 initials size * Rush change file * Dropdown, slider high contrast fixes (microsoft#1718) * Fix high contrast colors for Edge/IE11 * change log * Fixing high contrast styles for slider * Update lydutk-fixedPersonaSize28InitialsHeight_2017-05-04-15-28.json * Applying package updates. * Add readonly to combobox implementation (microsoft#1730) * Calendar: make today configurable to support different timezone (microsoft#1724) * make today configurable for different timezone * change file * revert the margin change * handle in case today was passed in as null * Remove duplicate change file * SearchBox: added the ariaLabel optional property (microsoft#1689) * Add button focus swap example * Fixed contextual menu example * PR feedback * Callout: Add minPagePadding. Dropdown: Expose calloutProps (microsoft#1735) * Callout: Add minPagePadding. Dropdown: Expose calloutProps * Add change file * Updated docs to include the required Fabric component (microsoft#1731) * Updated docs to include the required Fabric component * Updated Fabric docs in duplicate places * Unbreaking the build. Bad merge caused warnings in the build. * Applying package updates. * Tooltip custom render (microsoft#1737) * Tooltip: Added custom content render function and exposed tooltip props to host * Add change file * Moved word-wrap into content div * Let to const and fixed linting errors * Choicegroup focus (microsoft#1738) * ChoiceGroup: Fixed broken focus border * Added change efile * Added high contrast mode as well * Tweaked high contrast settings. Fixed focus on mouse * Fixing lint. (microsoft#1743) * Adds borderless option to TextField component. (microsoft#1739) * Adds borderless option for TextField component. * Adds change file. * Adds borderless option for DatePicker component. * Update joem-textfield-borderless_2017-05-06-22-56.json * Update joem-textfield-borderless_2017-05-06-22-56.json * Update joem-textfield-borderless_2017-05-06-22-56.json * Implements code review feedback. - Changes selector. - Makes border transparent instead of removing it. * Update TextField.scss * Update TextField.Basic.Example.tsx * Enable sp build web in styling (microsoft#1681) * [srdeshpa] Fix for dropdown not handling the disabling and enabling logic in all the cases. * [srdeshpa] Adding manifest.json and enabling sp-build-web * [srdeshpa] fixing the output directory location in the tsconfig.json * [srdeshpa] Adding change file * [srdeshpa] adding local .npmrc * Update enable-sp-build-web-in-styling_2017-05-02-20-15.json * removing .npmrc file * [srdeshpa] Resolved merge conflicts and updating the shrinkwrap to fix a gulp-core-build-typescript error 'The version of the typescript compiler should only be set once.' * Addressing PR comemnts * Update Dropdown.tsx * remove extra file * adding prefer-const rule to the styling ts-lint file * [srdeshpa] Removing "tslint-microsoft-contrib" from @officeui/styling. As it is using the latest version of it and the latest version has a breaking change in it. Now, we will get the stable version of "tslint-microsoft-contrib" from gulp-core-build-typescript. * [srdeshpa] locking tslint-microsoft-contrib to specific version * Removing tslint. * Fixing tslint. * [srdeshpa] Adding write-manifests.json * Applying package updates. * PR feedback * fix typo * Change file * Applying package updates. * ContextualMenu: fix submenu not showing updated props correctly (microsoft#1745) * fixed an issue where a change to submenu items, while the submenu being open would not be reflected properly * undid example changes * adding in change file * Update contextualmenu-submenu-expandfix_2017-05-08-22-07.json * fixed comments and added some safety for various null values * fixed mistype * use better for loop

micahgodbolt added 4 commits April 17, 2017 14:05

Copy Overflow Code into branch

a8e4cc3

Adding focus zone around overflow set

7345c8c

Updated docs and icon props

c3ff083

Adding change file

62a5469

micahgodbolt requested a review from dzearing April 17, 2017 21:49

msftclas added the cla-not-required label Apr 17, 2017

micahgodbolt mentioned this pull request Apr 17, 2017

Overflow Set and Resize Group - Init Review #1508

Closed

micahgodbolt added 3 commits April 18, 2017 09:01

Update OverflowSet.Props.ts

eb237c8

Improve prop comments

9de2ec2

Fixed merge conflict

d54c5c6

dzearing requested changes Apr 18, 2017

View reviewed changes

micahgodbolt added 4 commits April 18, 2017 10:10

Merge branch 'master' into overflow-set

228ddd1

Fixed a few PR requests

cd011db

Merge branch 'overflow-set' of https://github.com/micahgodbolt/office…

1085601

…-ui-fabric-react into overflow-set

Fixed overflow icon styles

850c74a

micahgodbolt added 4 commits April 18, 2017 13:21

Created an IOverflowItemProps

8155ef5

Merge branch 'master' into overflow-set

e296f1a

Merge branch 'master' into overflow-set

e8e30c0

Merge branch 'master' into overflow-set

458ad1f

micahgodbolt added 4 commits April 21, 2017 12:07

Merge branch 'master' into overflow-set

c81f76e

Merge branch 'master' into overflow-set

ac1cb5e

Merge branch 'master' into overflow-set

b526d40

Merge branch 'master' into overflow-set

7e74eef

dzearing reviewed Apr 25, 2017

View reviewed changes

packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.scss Outdated

flex-wrap: nowrap;

}

Copy link
Copy Markdown

Member

dzearing Apr 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit blank

dzearing reviewed Apr 25, 2017

View reviewed changes

micahgodbolt added 2 commits April 27, 2017 14:06

Moved class props into button props file

d57593a

Commented out overflow set index.ts to keep hidden for now

ac26ad3

cschleiden reviewed Apr 27, 2017

View reviewed changes

dzearing reviewed Apr 28, 2017

View reviewed changes

christiango requested changes Apr 28, 2017

View reviewed changes

micahgodbolt added 3 commits April 28, 2017 13:23

Fix documentation and added key back to onRenderItems

e8eff9c

Fixed linting errors

473c484

Merge branch 'master' into overflow-set

78275f9

christiango reviewed Apr 30, 2017

View reviewed changes

micahgodbolt added 4 commits May 1, 2017 09:07

Merge branch 'master' into overflow-set

35f9325

Merge branch 'overflow-set' of https://github.com/micahgodbolt/office…

bb54cbd

…-ui-fabric-react into overflow-set

Revert button changes

e8c2960

updated example and items type

6d424e3

christiango reviewed May 2, 2017

View reviewed changes

christiango approved these changes May 2, 2017

View reviewed changes

micahgodbolt added 5 commits May 2, 2017 15:51

Updated dropdown to have defaultText

038b3f7

Added change file

edb0ec5

Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…

a72004f

…c-react

Merge branch 'master' into overflow-set

30c1a74

Merge master

501956d

cschleiden reviewed May 3, 2017

View reviewed changes

micahgodbolt added 2 commits May 3, 2017 10:54

Update master_2017-05-02-22-52.json

8f64dec

Merge branch 'master' into overflow-set

2e4df29

micahgodbolt merged commit ecacf12 into microsoft:master May 3, 2017

micahgodbolt deleted the overflow-set branch May 3, 2017 22:20

microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019


		export class OverflowSet extends BaseComponent<IOverflowSetProps, null> {

		constructor(props: IOverflowSetProps) {

Conversation

micahgodbolt commented Apr 17, 2017

Pull request checklist

Uh oh!

dzearing left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

micahgodbolt commented Apr 18, 2017

Uh oh!

micahgodbolt commented Apr 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christiango Apr 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

christiango Apr 30, 2017 •

edited

Loading