Overflow Set and Resize Group - Init Review#1508
Closed
micahgodbolt wants to merge 39 commits intomicrosoft:masterfrom
micahgodbolt:overflow-container
Closed
Overflow Set and Resize Group - Init Review#1508micahgodbolt wants to merge 39 commits intomicrosoft:masterfrom micahgodbolt:overflow-container
micahgodbolt wants to merge 39 commits intomicrosoft:masterfrom
micahgodbolt:overflow-container
Conversation
micahgodbolt
commented
Apr 12, 2017
| ]; | ||
|
|
||
|
|
||
| updateOverflowState(prevState, props) => { |
Member
Author
There was a problem hiding this comment.
These are notes that I'll eventually remove
Member
Author
|
Dropping some comments in here of notes David and I took |
Member
Author
|
Breaking this up into multiple PRs to get overflow set merged in sooner. #1537 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on this for a while and wanted to get some eyeballs on it. It's not quite final, so feedback is welcome.