Skip to content

Fix for IE10 document mode issue #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Feb 28, 2017
Merged

Fix for IE10 document mode issue #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b81da4a
Fix for IE10 document mode issue
mdahamiwal Jan 19, 2017
9c92add
merge with master
mdahamiwal Feb 22, 2017
1b54bc2
change log
mdahamiwal Feb 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/textfield-IE10issue_2017-02-22-14-34.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "TextField: Fixed IE10 documentation input change behavior",
"type": "patch"
}
],
"email": "manishda@microsoft.com"
}
17 changes: 5 additions & 12 deletions packages/office-ui-fabric-react/src/components/TextField/TextField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ export class TextField extends BaseComponent<ITextFieldProps, ITextFieldState> i
ref={ this._resolveRef('_textElement') }
value={ this.state.value }
onInput={ this._onInputChange }
onChange={ this._onChange }
onChange={ this._onInputChange }
className={ this._textElementClassName }
aria-label={ this.props.ariaLabel }
aria-describedby={ this._isDescriptionAvailable ? this._descriptionId : undefined }
Expand All @@ -265,7 +265,7 @@ export class TextField extends BaseComponent<ITextFieldProps, ITextFieldState> i
ref={ this._resolveRef('_textElement') }
value={ this.state.value }
onInput={ this._onInputChange }
onChange={ this._onChange }
onChange={ this._onInputChange }
className={ this._textElementClassName }
aria-label={ this.props.ariaLabel }
aria-describedby={ this._isDescriptionAvailable ? this._descriptionId : undefined }
Expand All @@ -279,6 +279,9 @@ export class TextField extends BaseComponent<ITextFieldProps, ITextFieldState> i
private _onInputChange(event: React.FormEvent<HTMLInputElement | HTMLTextAreaElement>): void {
const element: HTMLInputElement = event.target as HTMLInputElement;
const value: string = element.value;
if (value === this.state.value) {
return;
}

this.setState({
value: value,
Expand Down Expand Up @@ -346,14 +349,4 @@ export class TextField extends BaseComponent<ITextFieldProps, ITextFieldState> i
textField.style.height = scrollHeight + 'px';
}
}

private _onChange(): void {
/**
* A noop input change handler.
* https://github.com/facebook/react/issues/7027.
* Using the native onInput handler fixes the issue but onChange
* still need to be wired to avoid React console errors
* TODO: Check if issue is resolved when React 16 is available.
*/
}
}