Fix for IE10 document mode issue#1077
Merged
dzearing merged 3 commits intomicrosoft:masterfrom Feb 28, 2017
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
Fixes issue for IE10 document support.
RCA:
We have an input element:
The problem occurs when we use this.state.value to pass the value. Since onInput is a native html handler the event.target gives and this.state.value is empty initially there is no way to retrieve the newValue for the element.
For IE11 onInput provides event.target.value given by the user instead of this.state.value but for IE10 document mode the behavior changes.
Fix:
Attach both onChange and onInput to the same handler and put a check to avoid duplicate setState and onchange validation calls. We can get rid off onInput if React 16 fixes the IE11 keystrokes missing issue.
Focus areas to test