remove --no-verify option from bpf2c and tests using it #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeagun
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
saxena-anurag
previously approved these changes
Jul 2, 2024
|
@mikeagun Can you make this draft until you have it fixed? Or push an update to fix the build break? |
|
Converting to draft until build fixed. |
mikeagun
force-pushed
the
remove-bpf2c-noverify
branch
from
31ca8f9
to
e2ac5f5
Compare
|
The problem was due to conflicting changes to noverify related code, rebasing and removing those lines fixed it, so this PR is ready for review now. |
dthaler
reviewed
Aug 31, 2024
dthaler
previously approved these changes
Sep 6, 2024
Alan-Jowett
previously approved these changes
Sep 6, 2024
mikeagun
commented
Sep 6, 2024
dthaler
previously approved these changes
Sep 7, 2024
Alan-Jowett
previously approved these changes
Sep 9, 2024
dthaler
approved these changes
Sep 12, 2024
Alan-Jowett
approved these changes
Sep 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
* remove --no-verify option from bpf2c and tests using it Closes #3571 * remove builds for unsafe programs in sample.vcxproj * remove unsafe test cases from netsh_test.cpp * remove new noverify references * Revert deletion of netsh tests. * Add back compilation of unsafe programs (but not bpf2c call) * remove invalid program tests which used noverify * remove end_to_end tests using noverify --------- Co-authored-by: Michael Agun <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3571
Description
Removes --no-verify option from bpf2c and the remaining tests using it.
Testing
Removes remaining tests that use --no-verify (the "unsafe" tests).
Documentation
Deleted documentation on --no-verify bpf2c option.
Installation
N/A