Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --no-verify option from bpf2c #3571

Closed
dthaler opened this issue May 22, 2024 · 0 comments · Fixed by #3673
Closed

Remove --no-verify option from bpf2c #3571

dthaler opened this issue May 22, 2024 · 0 comments · Fixed by #3673
Assignees
@mikeagun
Labels
cleanup Affects API usability or code maintainability but not correctness or applicability good first issue Good for newcomers P2 triaged Discussed in a triage meeting
Milestone
2410

Comments

@dthaler
Copy link
Collaborator

dthaler commented May 22, 2024

Describe the feature you'd like supported

Originally this option was added to improve coverage of the bpf2c code generation, around features bpf2c supported but the verifier didn't support yet (things like atomics) but those are now supported so this isn't needed any more. Leaving the option to generate knowingly unsafe code is bad for seurity and so this should be removed.

Proposed solution

Remove the --no-verify option.

Additional context

No response
@dthaler dthaler added the cleanup Affects API usability or code maintainability but not correctness or applicability label May 22, 2024
@dahavey dahavey added the triaged Discussed in a triage meeting label May 28, 2024
@dahavey dahavey added this to the 2406 milestone May 28, 2024
@dahavey dahavey added the P2 label May 28, 2024
@dahavey dahavey added the good first issue Good for newcomers label May 28, 2024
mikeagun pushed a commit to mikeagun/ebpf-for-windows that referenced this issue Jun 24, 2024
remove --no-verify option from bpf2c and tests using it
813ccaa 
Closes microsoft#3571
@mikeagun mikeagun mentioned this issue Jun 24, 2024
Merged
@shankarseal shankarseal modified the milestones: 2406, 2408 Jun 26, 2024
mikeagun pushed a commit to mikeagun/ebpf-for-windows that referenced this issue Aug 30, 2024
remove --no-verify option from bpf2c and tests using it
8ddf5f0 
Closes microsoft#3571
@shankarseal shankarseal modified the milestones: 2408, 2409, 2410 Sep 3, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 13, 2024
@mikeagun
remove --no-verify option from bpf2c and tests using it (#3673)
02ffe69 
* remove --no-verify option from bpf2c and tests using it

Closes #3571

* remove builds for unsafe programs in sample.vcxproj

* remove unsafe test cases from netsh_test.cpp

* remove new noverify references

* Revert deletion of netsh tests.

* Add back compilation of unsafe programs (but not bpf2c call)

* remove invalid program tests which used noverify

* remove end_to_end tests using noverify

---------

Co-authored-by: Michael Agun <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Sep 14, 2024
@mikeagun
remove --no-verify option from bpf2c and tests using it (#3673)
a41953d 
* remove --no-verify option from bpf2c and tests using it

Closes #3571

* remove builds for unsafe programs in sample.vcxproj

* remove unsafe test cases from netsh_test.cpp

* remove new noverify references

* Revert deletion of netsh tests.

* Add back compilation of unsafe programs (but not bpf2c call)

* remove invalid program tests which used noverify

* remove end_to_end tests using noverify

---------

Co-authored-by: Michael Agun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeagun mikeagun

Labels
cleanup Affects API usability or code maintainability but not correctness or applicability good first issue Good for newcomers P2 triaged Discussed in a triage meeting
Projects
None yet
Milestone
2410
Development

Successfully merging a pull request may close this issue.

remove --no-verify option from bpf2c and tests using it mikeagun/ebpf-for-windows
4 participants
@mikeagun @dthaler @dahavey @shankarseal