-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rundown files compression as an option to ebpf_tracing.cmd
.
#2537
Add rundown files compression as an option to ebpf_tracing.cmd
.
#2537
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2537 +/- ##
==========================================
+ Coverage 83.99% 84.00% +0.01%
==========================================
Files 157 157
Lines 29116 29116
==========================================
+ Hits 24455 24460 +5
+ Misses 4661 4656 -5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, other than one typo
* Fix build errors with Visual Studio 17.6.0 (#2483) * Fix build errors with Visual Studio 17.6.0 Signed-off-by: Dave Thaler <[email protected]> * PR feedback Signed-off-by: Dave Thaler <[email protected]> --------- Signed-off-by: Dave Thaler <[email protected]> * Cherry-pick #2499, #2483. * Remove wfp compression * Move the timestamp calculation. * wip * feedback * Update scripts/ebpf_tracing.cmd Co-authored-by: Dave Thaler <[email protected]> * Setting max_file_size_mb to the final max allowed. * maximize sizes --------- Co-authored-by: Dave Thaler <[email protected]> * Source update to v0.9.1 * Revert "Cherry-pick #2499, #2483." This reverts commit eab9bbe. * Capture bpftool output in diagnostic scripts (#2484) * tmp working commit * working script * working E2E scripts * minor formatting * Tune ebpf_tracing.cmd to use the least amount of CPU. (#2499) * Remove wfp compression * Move the timestamp calculation. * wip * feedback * Update scripts/ebpf_tracing.cmd Co-authored-by: Dave Thaler <[email protected]> * Setting max_file_size_mb to the final max allowed. * maximize sizes --------- Co-authored-by: Dave Thaler <[email protected]> * Add rundown files compression as an option to `ebpf_tracing.cmd`. (#2537) * Add 'compress_rundown_state_files' option * nit * typo * fix CICD failure (#2548) Co-authored-by: Dhiren Vispute <[email protected]> * nit src refresh (whitespace) * Fix redirected_by_self check for dual stack sockets (#2562) * Cherry -picks from #2600 * fix typo --------- Signed-off-by: Dave Thaler <[email protected]> Co-authored-by: Dave Thaler <[email protected]> Co-authored-by: Matthew Ige <[email protected]> Co-authored-by: Delaram Amiri <[email protected]> Co-authored-by: Dhiren Vispute <[email protected]> Co-authored-by: Anurag Saxena <[email protected]>
Closes #2429
Description
This PR:
compress_rundown_state_files
parameter toebpf_tracing.cmd
(default active), so to opportunistically address CPU spikes, while keeping backwards compatibility with the previous "hardcoded" implementation.ebpf_tracing_periodic_task.xml
.Testing
Local VM run, 4h.
Documentation
Integrated in the script.