Tune ebpf_tracing.cmd to use the least amount of CPU. #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtrevi
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft and
delaramamiri
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2499 +/- ##
==========================================
- Coverage 84.06% 84.06% -0.01%
==========================================
Files 155 157 +2
Lines 28847 28978 +131
==========================================
+ Hits 24251 24360 +109
- Misses 4596 4618 +22 |
matthewige
reviewed
May 23, 2023
matthewige
reviewed
May 23, 2023
matthewige
previously approved these changes
May 23, 2023
Alan-Jowett
previously approved these changes
May 24, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
dthaler
reviewed
May 24, 2023
Co-authored-by: Dave Thaler <[email protected]>
matthewige
approved these changes
May 25, 2023
dthaler
approved these changes
May 26, 2023
|
Previously it looks like it was tuned to use the least amount of disk space. Can you add more details to issue #2429 as to why it's more important to optimize for CPU than disk space? (It's not clear to me.) Thanks! |
delaramamiri
approved these changes
May 26, 2023
gtrevi
added a commit
that referenced
this pull request
May 31, 2023
* Remove wfp compression * Move the timestamp calculation. * wip * feedback * Update scripts/ebpf_tracing.cmd Co-authored-by: Dave Thaler <[email protected]> * Setting max_file_size_mb to the final max allowed. * maximize sizes --------- Co-authored-by: Dave Thaler <[email protected]>
Merged
gtrevi
added a commit
that referenced
this pull request
May 31, 2023
gtrevi
added a commit
that referenced
this pull request
May 31, 2023
* Remove wfp compression * Move the timestamp calculation. * wip * feedback * Update scripts/ebpf_tracing.cmd Co-authored-by: Dave Thaler <[email protected]> * Setting max_file_size_mb to the final max allowed. * maximize sizes --------- Co-authored-by: Dave Thaler <[email protected]>
saxena-anurag
added a commit
that referenced
this pull request
Jun 19, 2023
* Fix build errors with Visual Studio 17.6.0 (#2483) * Fix build errors with Visual Studio 17.6.0 Signed-off-by: Dave Thaler <[email protected]> * PR feedback Signed-off-by: Dave Thaler <[email protected]> --------- Signed-off-by: Dave Thaler <[email protected]> * Cherry-pick #2499, #2483. * Remove wfp compression * Move the timestamp calculation. * wip * feedback * Update scripts/ebpf_tracing.cmd Co-authored-by: Dave Thaler <[email protected]> * Setting max_file_size_mb to the final max allowed. * maximize sizes --------- Co-authored-by: Dave Thaler <[email protected]> * Source update to v0.9.1 * Revert "Cherry-pick #2499, #2483." This reverts commit eab9bbe. * Capture bpftool output in diagnostic scripts (#2484) * tmp working commit * working script * working E2E scripts * minor formatting * Tune ebpf_tracing.cmd to use the least amount of CPU. (#2499) * Remove wfp compression * Move the timestamp calculation. * wip * feedback * Update scripts/ebpf_tracing.cmd Co-authored-by: Dave Thaler <[email protected]> * Setting max_file_size_mb to the final max allowed. * maximize sizes --------- Co-authored-by: Dave Thaler <[email protected]> * Add rundown files compression as an option to `ebpf_tracing.cmd`. (#2537) * Add 'compress_rundown_state_files' option * nit * typo * fix CICD failure (#2548) Co-authored-by: Dhiren Vispute <[email protected]> * nit src refresh (whitespace) * Fix redirected_by_self check for dual stack sockets (#2562) * Cherry -picks from #2600 * fix typo --------- Signed-off-by: Dave Thaler <[email protected]> Co-authored-by: Dave Thaler <[email protected]> Co-authored-by: Matthew Ige <[email protected]> Co-authored-by: Delaram Amiri <[email protected]> Co-authored-by: Dhiren Vispute <[email protected]> Co-authored-by: Anurag Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2429
Description
Remove compression of the
wfpstate.xmlfile before moving it to the.\committedfolder, and in turn, its max size check should be raised to account for the final compression ratio.Testing
Local testing
Documentation
Moved embedded documentation comments into usage.