add unit tests for target based scaling, and fix 2 bugs found by tests#446
Merged
sebastianburckhardt merged 1 commit intovabachu/tbsfrom Feb 13, 2025
Merged
add unit tests for target based scaling, and fix 2 bugs found by tests#446sebastianburckhardt merged 1 commit intovabachu/tbsfrom
sebastianburckhardt merged 1 commit intovabachu/tbsfrom
Conversation
nytian
approved these changes
Feb 13, 2025
nytian
added a commit
that referenced
this pull request
Feb 14, 2025
* initial commit * port the scaling logic to compute a target instead of a scale recommendation. * moved target based scaling code to NetheriteTargetScaler * adding tests * updated test name * add instanceId to descriptor (#270) * make netherite metrics provider singleton * add deleted package reference * add unit tests for target based scaling, and fix 2 bugs found by tests (#446) * increase version to 3.1.0 * update index * add empty line * update by comments make loadpublisher class property --------- Co-authored-by: sebastianburckhardt <sburckha@microsoft.com> Co-authored-by: David Justo <david.justo.1996@gmail.com> Co-authored-by: naiyuantian@microsoft.com <naiyuantian@microsoft.com> Co-authored-by: Naiyuan Tian <110135109+nytian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a lot more unit tests for the target-based scaling feature, to exercise the logic in various places.
I also found two bugs in the scaling logic using these tests, and fixed them.