Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#4245] Mark deprecated channels as obsolete in Channels enum #4249

Merged
merged 2 commits into from
May 31, 2022
Merged

port: [#4245] Mark deprecated channels as obsolete in Channels enum #4249

merged 2 commits into from
May 31, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4245

Description

This PR marks the unsupported channels as deprecated and adds the new channel Outlook.

Unsupported channels:

  • Kik
  • SkypeForBusiness
  • Twilio-sms

New supported channels:

  • Outlook

Specific Changes

  • Unsupported channels are marked as deprecated in BotFramework-schema.

Testing

This screenshot shows the unit tests passing
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner May 30, 2022 20:16
@coveralls
Copy link

coveralls commented May 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2411149475

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 84.481%
Totals Coverage Status
Change from base Build 2387271645: 0.5%
Covered Lines: 19903
Relevant Lines: 22311
💛 - Coveralls

@gabog gabog merged commit e4dc133 into main May 31, 2022
@gabog gabog deleted the southworks/update/mark-deprecated-channels-as-obsolete branch May 31, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabog gabog gabog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark deprecated channels as obsolete in Channels enum
3 participants
@ceciliaavila @coveralls @gabog