Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark deprecated channels as obsolete in Channels enum #4245

Closed
ceciliaavila opened this issue May 23, 2022 · 0 comments · Fixed by #4249
Closed

Mark deprecated channels as obsolete in Channels enum #4245

ceciliaavila opened this issue May 23, 2022 · 0 comments · Fixed by #4249
Assignees
@JuanAr
Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.

Comments

@ceciliaavila
Copy link
Collaborator

ceciliaavila commented May 23, 2022 •
edited
Loading

Parent issue microsoft/botframework-sdk#6448

Describe the bug

Channels enum is outdated compared to its .NET counterpart.
Some channels are deprecated (Twilio-sms) while others need to be added (Outlook).

Expected behavior

We should keep parity between .NET and JS implementations.
@ceciliaavila ceciliaavila added the bug Indicates an unexpected problem or an unintended behavior. label May 23, 2022
@axelsrz axelsrz added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label May 24, 2022
@ceciliaavila ceciliaavila mentioned this issue May 30, 2022
Merged
gabog pushed a commit that referenced this issue May 31, 2022
@ceciliaavila
port: [#4245] Mark deprecated channels as obsolete in Channels enum (#…
e4dc133 
…4249)

* Unsupported channels marked as obsolete.

* Twilio-sms deprecated. Outlook channel added.

Co-authored-by: Emiliano Quiroga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4245] Mark deprecated channels as obsolete in Channels enum microsoft/botbuilder-js
3 participants
@JuanAr @axelsrz @ceciliaavila