Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove public access modifier in botframework-streaming #3794

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

stevengum
Copy link
Member

Part 2 of #3518
#minor

Description:
Removed public access modifier from botframework-streaming. botframework-streaming is now eslint compliant.

@stevengum stevengum requested a review from joshgummersall June 23, 2021 19:00
@stevengum stevengum requested a review from a team as a code owner June 23, 2021 19:00
@coveralls
Copy link

coveralls commented Jun 23, 2021

Pull Request Test Coverage Report for Build 980184654

  • 79 of 79 (100.0%) changed or added relevant lines in 19 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 83.747%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/namedPipe/namedPipeServer.ts 1 79.45%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 1 84.16%
Totals Coverage Status
Change from base Build 979956236: -0.009%
Covered Lines: 19516
Relevant Lines: 22077

💛 - Coveralls

Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments, otherwise LGTM!

* assorted cleanup, slight refactoring
* botframework-streaming is now eslint compliant
@stevengum
Copy link
Member Author

@joshgummersall thanks for the review! This PR is ready, although there are some public surface area changes that I'll mull over later today/tomorrow...

@joshgummersall
Copy link
Contributor

@joshgummersall Joshua Gummersall FTE thanks for the review! This PR is ready, although there are some public surface area changes that I'll mull over later today/tomorrow...

For posterity - we assessed the changes here and determined that they should not cause problems with consumers. We also manually linked this branch against botframework-directlinejs and ran the full build process to ensure compilation did not break.

@joshgummersall joshgummersall merged commit f193b32 into main Jun 28, 2021
@joshgummersall joshgummersall deleted the stgum/streaming branch June 28, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants