-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove public access modifier in botframework-streaming #3794
Conversation
Pull Request Test Coverage Report for Build 980184654
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small comments, otherwise LGTM!
libraries/botframework-streaming/src/assemblers/payloadAssembler.ts
Outdated
Show resolved
Hide resolved
libraries/botframework-streaming/src/disassemblers/requestDisassembler.ts
Outdated
Show resolved
Hide resolved
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts
Outdated
Show resolved
Hide resolved
* assorted cleanup, slight refactoring * botframework-streaming is now eslint compliant
18998c8
to
1306b74
Compare
@joshgummersall thanks for the review! This PR is ready, although there are some public surface area changes that I'll mull over later today/tomorrow... |
For posterity - we assessed the changes here and determined that they should not cause problems with consumers. We also manually linked this branch against |
Part 2 of #3518
#minor
Description:
Removed public access modifier from botframework-streaming. botframework-streaming is now eslint compliant.