Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code quality] Remove public access modifier where it's unnecessary #3518

Closed
2 tasks
stevengum opened this issue Apr 2, 2021 · 0 comments · Fixed by #4227
Closed
2 tasks

[Code quality] Remove public access modifier where it's unnecessary #3518

stevengum opened this issue Apr 2, 2021 · 0 comments · Fixed by #4227
Assignees
@JuanAr @stevengum
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) backlog The issue is out of scope for the current iteration but it will be evaluated in a future release.

Comments

@stevengum
Copy link
Member

stevengum commented Apr 2, 2021 •
edited
Loading

I don't think we use public on the constructors, at the very least we're not consistent... @joshgummersall since the default is public, what do you want to follow as a policy going forwards?

Sorry - merged this before you had a chance to comment. I'm typically in favor of being terse whenever possible, so I tend to omit public since it is the default. I'm open to either, though, and I agree we should use a consistent style.

-@joshgummersall #3517 (comment)

Completed packages:

  • botbuilder-ai-orchestrator
  • botbuilder-ai
  • botbuilder-applicationinsights
  • botbuilder-azure-queues
  • botbuilder-azure
@stevengum stevengum added Automation: No parity PR does not need to be applied to other languages. Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) labels Apr 2, 2021
This was referenced Apr 2, 2021
Merged
Merged
@joshgummersall joshgummersall added this to the R14 milestone Apr 6, 2021
@joshgummersall joshgummersall added backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. and removed Automation: No parity PR does not need to be applied to other languages. labels May 4, 2021
stevengum added a commit that referenced this issue Jun 7, 2021
@stevengum
remove unnecessary public access modifier (Pt. 1 #3518)
dad452f
@stevengum stevengum mentioned this issue Jun 7, 2021
Merged
stevengum added a commit that referenced this issue Jun 8, 2021
@stevengum
chore: remove unnecessary public access modifier (#3731)
e00e6c8 
* remove unnecessary public access modifier (Pt. 1 #3518)

* fix lint error

* add eslint rule to root configuration
@stevengum stevengum mentioned this issue Jun 14, 2021
Merged
@stevengum stevengum mentioned this issue Jun 23, 2021
Merged
@joshgummersall joshgummersall modified the milestones: R14, R15 Jun 24, 2021
@mrivera-ms mrivera-ms added the Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. label Dec 8, 2021
@mrivera-ms mrivera-ms removed this from the R15 milestone Dec 8, 2021
This was referenced May 2, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 2, 2022
Merged
Merged
Merged
Merged
tracyboehrer pushed a commit that referenced this issue Jun 15, 2022
@sw-joelmut
chore: [#3518] Remove public access modifier from generators, declara…
8b45b75 
…tive, testing and schema (#4214)

* Remove 'public' access modifier from generator-botbuilder folder

* Remove 'public' access modifier from botbuilder-dialogs-declarative folder

* Remove 'public' access modifier from botbuilder-testing folder

* Remove 'public' access modifier from botframework-schema folder
tracyboehrer added a commit that referenced this issue Jun 17, 2022
@sw-joelmut @tracyboehrer
chore: [#3518] Remove public access modifier from botframework-config…
b97a692 
… and connector (#4220)

* Remove 'public' access modifier from botframework-config folder

* Remove 'public' access modifier from botframework-connector folder

Co-authored-by: tracyboehrer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

@stevengum stevengum

Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) backlog The issue is out of scope for the current iteration but it will be evaluated in a future release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: [#3518] Enable 'no-public' accessibility rule in the .eslintrc file microsoft/botbuilder-js
4 participants
@JuanAr @joshgummersall @stevengum @mrivera-ms