fix: adjust adaptiveCard/action handling #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrichardson
commented
Jun 7, 2021
| @@ -133,9 +133,6 @@ export class TeamsActivityHandler extends ActivityHandler { | |||
| await this.handleTeamsTabSubmit(context, context.activity.value) | |||
| ); | |||
|
|
|||
| case 'adaptiveCard/action': | |||
There was a problem hiding this comment.
Note: Everything removed in this file and related tests is already covered on new line 138, when the default of the switch/case calls super.onInvokeActivity()
Pull Request Test Coverage Report for Build 922719961
💛 - Coveralls |
joshgummersall
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
@mdrichardson was the initial PR that introduced this functionality necessary in the first place? It seems like the handling code already existed.
|
I don't believe it was necessary, since yes, since it was handled more broadly (ActivityHandler vs TeamsActivityHandler) here |
joshgummersall
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
Per the OBI,
AdaptiveCardInvokeValue.authenticationshould actually be aTokenExchangeInvokeRequest, which has the same properties asAdaptiveCardAuthentication, which is now superfluous.In working on this, I also noticed that this PR was actually already covered.
Specific Changes
AdaptiveCardAuthenticationand replace withTokenExchangeInvokeRequestgit revertuntil I had already manually removed it.