Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: adaptive card invoke #3327

Merged
merged 6 commits into from
Mar 26, 2021
Merged

port: adaptive card invoke #3327

merged 6 commits into from
Mar 26, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3321

@joshgummersall joshgummersall requested a review from a team as a code owner February 18, 2021 18:25
@coveralls
Copy link

coveralls commented Feb 18, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 687819299

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.0%) to 84.938%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
libraries/botbuilder-core/src/activityHandler.ts 17 79.75%
Totals Coverage Status
Change from base Build 687807318: -2.0%
Covered Lines: 18827
Relevant Lines: 21105
💛 - Coveralls

stevengum
stevengum requested changes Feb 18, 2021
View reviewed changes
@joshgummersall joshgummersall marked this pull request as draft February 25, 2021 18:29
@joshgummersall joshgummersall force-pushed the jpg/port-adaptivecard-invoke branch from fa586f3 to cf25820 Compare March 1, 2021 18:54
@joshgummersall joshgummersall marked this pull request as ready for review March 1, 2021 18:55
@joshgummersall joshgummersall force-pushed the jpg/port-adaptivecard-invoke branch 2 times, most recently from 1256ebe to 567b94c Compare March 23, 2021 16:16
@joshgummersall joshgummersall force-pushed the jpg/port-adaptivecard-invoke branch 2 times, most recently from bad216a to 9a290d9 Compare March 24, 2021 17:21
@joshgummersall joshgummersall force-pushed the jpg/port-adaptivecard-invoke branch from 9a290d9 to 26346f2 Compare March 24, 2021 18:27
stevengum
stevengum approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Later if there's a requirement, we can move the Invoke-handling logic out of ActivityHandler to ActivityHandlerBase.

@stevengum stevengum merged commit 7d44ace into main Mar 26, 2021
@stevengum stevengum deleted the jpg/port-adaptivecard-invoke branch March 26, 2021 00:02
@mdrichardson mdrichardson mentioned this pull request Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Add OnAdaptiveCardInvokeAsync to ActivityHandler (#5227)
3 participants
@joshgummersall @coveralls @stevengum